diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-11-19 13:50:12 -0500 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-11-19 13:50:16 -0500 |
| commit | 09f1d7fe7243d9da76068119668ff2ebe6686c2c (patch) | |
| tree | 8371e3cfd841771a86b6719d3539281accfcba5b | |
| parent | 6d58a5c3b05585b01c960776e00856637ff1794d (diff) | |
| parent | c54e5a41c4ae0f50a27b93bda0c7d8f128101670 (diff) | |
| download | bitcoin-09f1d7fe7243d9da76068119668ff2ebe6686c2c.tar.xz | |
Merge #14718: Remove unreferenced boost headers
c54e5a41c4 Remove unreferenced boost headers (Murray Nesbitt)
Pull request description:
Building with clang (e.g. on FreeBSD) is very noisy due to `-Wthread-safety-analysis` warnings regarding boost. This change removes a number of unnecessary boost includes, and silences the rest of the warnings when building with clang. This allows more potentially interesting warnings to surface from the noise.
Tested on FreeBSD 11.2
Tree-SHA512: 5e6a0623188b9be59aeae52866799aefb4c3c9ab5e569b07ee8d43fc92e0b5f1f76b96bb54c35c7043148df84641b4a96927fb71f6eb00460c20cd19cf250900
| -rw-r--r-- | src/fs.h | 1 | ||||
| -rw-r--r-- | src/interfaces/node.cpp | 1 | ||||
| -rw-r--r-- | src/rpc/blockchain.cpp | 1 | ||||
| -rw-r--r-- | src/rpc/util.h | 2 | ||||
| -rw-r--r-- | src/util/system.cpp | 1 |
5 files changed, 0 insertions, 6 deletions
@@ -12,7 +12,6 @@ #endif #include <boost/filesystem.hpp> -#include <boost/filesystem/fstream.hpp> /** Filesystem operations and types */ namespace fs = boost::filesystem; diff --git a/src/interfaces/node.cpp b/src/interfaces/node.cpp index 1919e16a66..bd7e414ff3 100644 --- a/src/interfaces/node.cpp +++ b/src/interfaces/node.cpp @@ -35,7 +35,6 @@ #endif #include <atomic> -#include <boost/thread/thread.hpp> #include <univalue.h> class CWallet; diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp index 95915b5488..c48224b245 100644 --- a/src/rpc/blockchain.cpp +++ b/src/rpc/blockchain.cpp @@ -39,7 +39,6 @@ #include <univalue.h> -#include <boost/algorithm/string.hpp> #include <boost/thread/thread.hpp> // boost::thread::interrupt #include <memory> diff --git a/src/rpc/util.h b/src/rpc/util.h index 55ae2fa363..6d1e591f12 100644 --- a/src/rpc/util.h +++ b/src/rpc/util.h @@ -9,8 +9,6 @@ #include <script/standard.h> #include <univalue.h> -#include <boost/variant/static_visitor.hpp> - #include <string> #include <vector> diff --git a/src/util/system.cpp b/src/util/system.cpp index f6f36c2238..cc87d255a9 100644 --- a/src/util/system.cpp +++ b/src/util/system.cpp @@ -73,7 +73,6 @@ #include <malloc.h> #endif -#include <boost/thread.hpp> #include <openssl/crypto.h> #include <openssl/rand.h> #include <openssl/conf.h> |