diff options
| author | Andrew Chow <github@achow101.com> | 2023-06-15 14:44:30 -0400 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-06-15 15:11:32 -0400 |
| commit | b3db18a0126bc4181d2a0880c27f45d203d06179 (patch) | |
| tree | a1b25ab441c58fe67c35136d01cd294a1d743c62 /.github | |
| parent | 5b8e07725d5f46aa490f97a8f9221e617d0e4fbb (diff) | |
| parent | a97c59f12d50d11d8859f4bbfb9fcf66de667ca0 (diff) | |
Merge bitcoin/bitcoin#27712: test: p2p: check misbehavior for non-continuous headers messages
a97c59f12d50d11d8859f4bbfb9fcf66de667ca0 test: p2p: check misbehavior for non-continuous headers messages (Sebastian Falbesoner)
Pull request description:
This PR adds missing test coverage for a peer sending a `headers` message where the headers don't connect to each other, which should be treated as misbehaving (not disconnecting though, as the score increase is only 20). The relevant code path is `PeerManagerImpl::ProcessHeadersMessage` -> `PeerManagerImpl::CheckHeadersPoW` -> `PeerManagerImpl::CheckHeadersAreContinuous`:
https://github.com/bitcoin/bitcoin/blob/17acb2782a66f033238340e4fb81009e7f79e97a/src/net_processing.cpp#L2415-L2419
https://github.com/bitcoin/bitcoin/blob/17acb2782a66f033238340e4fb81009e7f79e97a/src/net_processing.cpp#L2474-L2484
ACKs for top commit:
sr-gi:
ACK https://github.com/bitcoin/bitcoin/commit/a97c59f12d50d11d8859f4bbfb9fcf66de667ca0
achow101:
ACK a97c59f12d50d11d8859f4bbfb9fcf66de667ca0
instagibbs:
ACK a97c59f12d50d11d8859f4bbfb9fcf66de667ca0
Tree-SHA512: 3f8d6a2492e5c8b63c7b11be2e4ec455f83581b2c58f2d4e705baadfe8d7c6377296d6cd0eda679d291a13d8930b09443f8e3d183795df34b780c703d5d3aeb3
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions