diff options
| author | fanquake <fanquake@gmail.com> | 2023-03-29 11:51:03 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-03-29 12:05:15 +0100 |
| commit | c0311b1dda278bbbb3e50acbfaf6bdcdbbf8ef11 (patch) | |
| tree | 8dc8e118e8f9fa6135592c39a2920a7f46cdb302 /.cirrus.yml | |
| parent | 68828288e5d35c17848ab3da8cd231d1b69651c0 (diff) | |
| parent | e47ce42f670fc43859c157766b342509ab5916f9 (diff) | |
| download | bitcoin-c0311b1dda278bbbb3e50acbfaf6bdcdbbf8ef11.tar.xz | |
Merge bitcoin/bitcoin#27349: test: use address_to_scriptpubkey instead of RPC call
e47ce42f670fc43859c157766b342509ab5916f9 refactor: use address_to_scriptpubkey to retrieve addresses scriptpubkey (ismaelsadeeq)
4142d19d741d6432ba95f3452f0d949941d89d5c refactor: move address_to_scriptpubkey to address.py (ismaelsadeeq)
Pull request description:
PR #27269 enables the function address_to_scriptpubkey() to decode all address types and return their corresponding scriptpubkeys. As a result, there is no longer any need to call getaddressinfo or validateaddress RPCs in order to retrieve an address scriptpubkey, as explained in the comments on this pull request (see https://github.com/bitcoin/bitcoin/pull/27269#pullrequestreview-1353681933 and https://github.com/bitcoin/bitcoin/pull/27269#issuecomment-1481016118).
Instead of using RPC calls, this update replaces the process of obtaining an address scriptPubkey with the address_to_scriptpubkey method, resulting in improved performance for functional tests.
ACKs for top commit:
josibake:
re-ACK https://github.com/bitcoin/bitcoin/pull/27349/commits/e47ce42f670fc43859c157766b342509ab5916f9
theStack:
ACK e47ce42f670fc43859c157766b342509ab5916f9 🌱
Tree-SHA512: 05285349a7d5ce7097b8f2582e573a5135c6deef85ea9936f68f6ce94e9ebb1d84d94f7fc7e5ed833a698e01585addd80deb52e6338f8aee985bf14db45417d2
Diffstat (limited to '.cirrus.yml')
0 files changed, 0 insertions, 0 deletions