diff options
| author | Ava Chow <github@achow101.com> | 2024-09-03 16:33:49 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-09-03 16:33:49 -0400 |
| commit | 27e89bc2f585e5bfef48de500c6c5ecd0565b437 (patch) | |
| tree | beb43ce650d5a3fc30d28a2c77bb72f7f308a2f9 /.appveyor.yml | |
| parent | d4b5553849665e873c386c1bdca7e4506ce4398a (diff) | |
| parent | b31a0cd0378184b2b9eb8f4bd3120cbd32c62005 (diff) | |
| download | bitcoin-27e89bc2f585e5bfef48de500c6c5ecd0565b437.tar.xz | |
Merge bitcoin/bitcoin#26619: log: expand BCLog::LogFlags (categories) to 64 bits
b31a0cd0378184b2b9eb8f4bd3120cbd32c62005 log: expand BCLog::LogFlags (categories) to 64 bits (Larry Ruane)
Pull request description:
Increase the maximum number of logging categories from 32 to 64.
We're currently using 29 of the 32 available logging categories (there are only 3 remaining). It would be good to increase the limit soon; the fourth PR to be merged that adds a new logging category will be blocked until something like this is done.
This PR also adds a `TEST` category that uses the new range (`1ULL << 63`) in case there's a hidden assumption somewhere that the `BCLog::LogFlags` type is 32 bits. (Also added a test for this test category.) It also provides an example showing that the expression must be `1ULL << <shift>` for shift value 31 and beyond.
ACKs for top commit:
achow101:
ACK b31a0cd0378184b2b9eb8f4bd3120cbd32c62005
vasild:
ACK b31a0cd0378184b2b9eb8f4bd3120cbd32c62005
ryanofsky:
Code review ACK b31a0cd0378184b2b9eb8f4bd3120cbd32c62005, just dropping mask_bit constant since last review. I still think
theStack:
Code-review ACK b31a0cd0378184b2b9eb8f4bd3120cbd32c62005
Tree-SHA512: de422dbeb479848d370aed42d415f42461457ab0eda62b245dc7ff9f0e111626e7d4c0d62ff13082ec664d05fbb0db04c71eb4b6f22eb8f19198826a67c4035e
Diffstat (limited to '.appveyor.yml')
0 files changed, 0 insertions, 0 deletions