summaryrefslogtreecommitdiff
path: root/bip-0155.mediawiki
AgeCommit message (Collapse)Author
2020-10-06Merge #1002: BIP155: Mention SHA3-256 explicitlyWladimir J. van der Laan
6ef71b344c51aebe1dab5ac47f87d8f926462a65 BIP155: Small text improvements (Hennadii Stepanov) 562f1d71883d1daa0dd5f438d25986fb18465800 BIP155: Mention SHA3-256 explicitly (Hennadii Stepanov) Pull request description: It seems better to clarify that `CHECKSUM` in Tor onion v3 address uses SHA3-256 hash function. ACKs for top commit: vasild: ACK 6ef71b344 laanwj: ACK 6ef71b344c51aebe1dab5ac47f87d8f926462a65 Tree-SHA512: b88c7dfeeda2a99cfe1042c9f4e7cbeb6047882bf97ce9c1dd5e1f4a30203a9a03702638cc4b6c3b573f6c0a05b73a5ca43a77352a5ca24a32d19be129f8b317
2020-10-01Merge pull request #967 from vasild/bip155_time_and_varintLuke Dashjr
BIP155: clarify variable integer format and change time to fixed 32 bit
2020-09-29BIP155: clarify that "services" uses CompactSizeVasil Dimov
The Bitcoin Core source code has `VARINT` type which is different than the "variable integer" format used all over the P2P protocol and also for the "services" field in this BIP. The latter is called `CompactSize` in some BIPs and also in the Bitcoin Core source code, thus use the word `CompactSize` to refer to it and link to its documentation.
2020-09-27BIP155: Small text improvementsHennadii Stepanov
2020-09-27BIP155: Mention SHA3-256 explicitlyHennadii Stepanov
2020-08-13BIP155: change "time" to fixed 32 bit unsignedVasil Dimov
32 bit unsigned can represent time up to year 2106 (32 bit signed is limited to just 2038). So, we don't need to have "time" encoded as variable integer which would take 5 bytes instead of 4.
2020-07-16BIP155: use a dedicated message for signallingVasil Dimov
Change signaling of support for the new `addrv2` messages to be done via a dedicated message `sendaddrv2` instead of protocol bump. The drawback of using a protocol bump is that the protocol version is not a bitmask and if a node wants to announce support for `addrv2` this would imply support for all prior features included in that protocol version.
2020-07-16BIP155: include changes from followup discussionsVasil Dimov
* Increase the maximum length of an address from 32 to 512 bytes and clarify that the entire message should be rejected if it contains a longer address. (from https://github.com/bitcoin/bips/pull/766#issuecomment-519248699) * Remove a contradiction about unknown address types - "MUST ignore" VS "MAY store and gossip". * Recommend gossiping addresses for networks to which the node is not currently connected to. (from https://github.com/bitcoin/bips/pull/766#issuecomment-545067608) * Clarify that the entire message should be rejected if it contains an address with unexpected size (e.g. IPv4 address with length 5).
2019-07-18bip155: Fix comments URLWladimir J. van der Laan
2019-07-18bip155: fill in BIP numberWladimir J. van der Laan