summaryrefslogtreecommitdiff
path: root/bip-0155.mediawiki
diff options
context:
space:
mode:
authorVasil Dimov <vd@FreeBSD.org>2020-08-13 11:30:55 +0200
committerVasil Dimov <vd@FreeBSD.org>2020-08-13 11:53:30 +0200
commit2c7630ec610712655119e40a218539e042c8d7b2 (patch)
tree7e8714801f1cfe967849792342231c875d9a3384 /bip-0155.mediawiki
parentcb071df902eafb7054635201a8b12e76f42774ad (diff)
BIP155: change "time" to fixed 32 bit unsigned
32 bit unsigned can represent time up to year 2106 (32 bit signed is limited to just 2038). So, we don't need to have "time" encoded as variable integer which would take 5 bytes instead of 4.
Diffstat (limited to 'bip-0155.mediawiki')
-rw-r--r--bip-0155.mediawiki8
1 files changed, 3 insertions, 5 deletions
diff --git a/bip-0155.mediawiki b/bip-0155.mediawiki
index 5914241..c41930f 100644
--- a/bip-0155.mediawiki
+++ b/bip-0155.mediawiki
@@ -46,7 +46,7 @@ The <code>addrv2</code> message is defined as a message where <code>pchCommand =
It is serialized in the standard encoding for P2P messages.
Its format is similar to the current <code>addr</code> message format
<ref>[https://bitcoin.org/en/developer-reference#addr Bitcoin Developer Reference: addr message]</ref>, with the difference that the
-fixed 16-byte IP address is replaced by a network ID and a variable-length address, and the time and services format has been changed to VARINT.
+fixed 16-byte IP address is replaced by a network ID and a variable-length address, and the services format has been changed to VARINT.
This means that the message contains a serialized <code>std::vector</code> of the following structure:
@@ -55,9 +55,9 @@ This means that the message contains a serialized <code>std::vector</code> of th
!Name
!Description
|-
-| <code>VARINT</code> (unsigned)
+| <code>uint32_t</code>
| <code>time</code>
-| Time that this node was last seen as connected to the network. A time in Unix epoch time format, up to 64 bits wide.
+| Time that this node was last seen as connected to the network. A time in Unix epoch time format.
|-
| <code>VARINT</code> (unsigned)
| <code>services</code>
@@ -144,8 +144,6 @@ The reference implementation is available at (to be done)
- Jonas Schnelli: change <code>services</code> field to VARINT, to make the message more compact in the likely case instead of always using 8 bytes.
-- Luke-Jr: change <code>time</code> field to VARINT, for post-2038 compatibility.
-
- Gregory Maxwell: various suggestions regarding extensibility
==Appendix A: Tor v2 address encoding==