diff options
author | Jeremy Rubin <j@rubin.io> | 2022-01-04 16:11:30 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-01-04 16:11:30 -0800 |
commit | b96b1712fcb0587b76f7c8eb15b8d6954070468a (patch) | |
tree | 09017a9753108c1eceb1ff613878a29811ea81da /bip-0084.mediawiki | |
parent | a3a397c82384220fc871852c809f73898a4d547c (diff) |
Fix BIP-119 Typo + Clarify the reasons for 32 bit lengths
when drafting the BIP I attempted to triangulate what the width of the fields for number of inputs/outputs should be from various sources in the codebase, and made an error in looking at the signing and encoding logic, and not the _decoding_ logic which restricts vectors (vin, vout) to MAX_SIZE which is 33554432. This fully justifies not using a wider type (uint64_t).
Also clarified arguments for not using a narrower type (uint16_t) which would be possible just for the vIn based on block size, because it's a leaky abstraction (you can still encode and decode such a transaction, just not mine it).
thanks to @roconnor-blockstream for pointing this out
Diffstat (limited to 'bip-0084.mediawiki')
0 files changed, 0 insertions, 0 deletions