aboutsummaryrefslogtreecommitdiff
path: root/youtube_dl/compat.py
diff options
context:
space:
mode:
authorPhilipp Hagemeister <phihag@phihag.de>2015-09-14 00:25:08 +0200
committerPhilipp Hagemeister <phihag@phihag.de>2015-09-14 00:25:08 +0200
commit953fed280f1a35bc6e8a701a25b8450ec08efdd3 (patch)
treee88ea4d31508547af59e548385eedda012e06da7 /youtube_dl/compat.py
parente2ff3df314c7e710d429ca311b2a22839d4aa3f9 (diff)
[compat] Do not use unicode
If the code ever runs on 3.x, it would fail. Even if it never does, the unicode name confuses Python 3 code analysis tools.
Diffstat (limited to 'youtube_dl/compat.py')
-rw-r--r--youtube_dl/compat.py14
1 files changed, 7 insertions, 7 deletions
diff --git a/youtube_dl/compat.py b/youtube_dl/compat.py
index e32bef279..1ff42d94b 100644
--- a/youtube_dl/compat.py
+++ b/youtube_dl/compat.py
@@ -81,6 +81,11 @@ except ImportError:
import BaseHTTPServer as compat_http_server
try:
+ compat_str = unicode # Python 2
+except NameError:
+ compat_str = str
+
+try:
from urllib.parse import unquote_to_bytes as compat_urllib_parse_unquote_to_bytes
from urllib.parse import unquote as compat_urllib_parse_unquote
from urllib.parse import unquote_plus as compat_urllib_parse_unquote_plus
@@ -100,7 +105,7 @@ except ImportError: # Python 2
# Is it a string-like object?
string.split
return b''
- if isinstance(string, unicode):
+ if isinstance(string, compat_str):
string = string.encode('utf-8')
bits = string.split(b'%')
if len(bits) == 1:
@@ -151,11 +156,6 @@ except ImportError: # Python 2
return compat_urllib_parse_unquote(string, encoding, errors)
try:
- compat_str = unicode # Python 2
-except NameError:
- compat_str = str
-
-try:
compat_basestring = basestring # Python 2
except NameError:
compat_basestring = str
@@ -234,7 +234,7 @@ else:
# Working around shlex issue with unicode strings on some python 2
# versions (see http://bugs.python.org/issue1548891)
def compat_shlex_split(s, comments=False, posix=True):
- if isinstance(s, unicode):
+ if isinstance(s, compat_str):
s = s.encode('utf-8')
return shlex.split(s, comments, posix)