Merge branch 'master' into fork_master

Conflicts:
	.travis.yml

1 files changed, 85 insertions, 73 deletions

diff --git a/test/test_download.py b/test/test_download.py
index 6926dd04e..f45c500c8 100644
--- a/test/test_download.py
+++ b/test/test_download.py
@@ -9,13 +9,28 @@ import os
 import json
 import unittest
 import sys
+import socket
 
 # Allow direct execution
 import os
 sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
-from youtube_dl.FileDownloader import FileDownloader
+import youtube_dl.FileDownloader
 import youtube_dl.InfoExtractors
+from youtube_dl.utils import *
+
+# General configuration (from __init__, not very elegant...)
+jar = compat_cookiejar.CookieJar()
+cookie_processor = compat_urllib_request.HTTPCookieProcessor(jar)
+proxy_handler = compat_urllib_request.ProxyHandler()
+opener = compat_urllib_request.build_opener(proxy_handler, cookie_processor, YoutubeDLHandler())
+compat_urllib_request.install_opener(opener)
+socket.setdefaulttimeout(300) # 5 minutes should be enough (famous last words)
+
+class FileDownloader(youtube_dl.FileDownloader):
+    def __init__(self, *args, **kwargs):
+        youtube_dl.FileDownloader.__init__(self, *args, **kwargs)
+        self.to_stderr = self.to_screen
 
 def _file_md5(fn):
     with open(fn, 'rb') as f:
@@ -48,137 +63,134 @@ class DownloadTest(unittest.TestCase):
 
     @_skip_unless(youtube_dl.InfoExtractors.YoutubeIE._WORKING, "IE marked as not _WORKING")
     def test_Youtube(self):
-        filename = 'BaW_jenozKc.mp4'
-        fd = FileDownloader(self.parameters)
+        filename = u'BaW_jenozKc.mp4'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.YoutubeIE())
-        fd.download(['http://www.youtube.com/watch?v=BaW_jenozKc'])
+        fd.download([u'http://www.youtube.com/watch?v=BaW_jenozKc'])
         self.assertTrue(os.path.exists(filename))
-        self.assertEqual(os.path.getsize(filename), 1993883)
 
     @_skip_unless(youtube_dl.InfoExtractors.DailymotionIE._WORKING, "IE marked as not _WORKING")
     def test_Dailymotion(self):
-        filename = 'x33vw9.mp4'
-        fd = FileDownloader(self.parameters)
+        filename = u'x33vw9.mp4'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.DailymotionIE())
-        fd.download(['http://www.dailymotion.com/video/x33vw9_tutoriel-de-youtubeur-dl-des-video_tech'])
+        fd.download([u'http://www.dailymotion.com/video/x33vw9_tutoriel-de-youtubeur-dl-des-video_tech'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, 'd363a50e9eb4f22ce90d08d15695bb47')
+        self.assertEqual(md5_for_file, u'392c4b85a60a90dc4792da41ce3144eb')
 
     @_skip_unless(youtube_dl.InfoExtractors.MetacafeIE._WORKING, "IE marked as not _WORKING")
     def test_Metacafe(self):
-        filename = '_aUehQsCQtM.flv'
-        fd = FileDownloader(self.parameters)
+        filename = u'_aUehQsCQtM.flv'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.MetacafeIE())
         fd.add_info_extractor(youtube_dl.InfoExtractors.YoutubeIE())
-        fd.download(['http://www.metacafe.com/watch/yt-_aUehQsCQtM/the_electric_company_short_i_pbs_kids_go/'])
+        fd.download([u'http://www.metacafe.com/watch/yt-_aUehQsCQtM/the_electric_company_short_i_pbs_kids_go/'])
         self.assertTrue(os.path.exists(filename))
-        self.assertEqual(os.path.getsize(filename), 5754305)
 
     @_skip_unless(youtube_dl.InfoExtractors.BlipTVIE._WORKING, "IE marked as not _WORKING")
     def test_BlipTV(self):
-        filename = '5779306.m4v'
-        fd = FileDownloader(self.parameters)
+        filename = u'5779306.m4v'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.BlipTVIE())
-        fd.download(['http://blip.tv/cbr/cbr-exclusive-gotham-city-imposters-bats-vs-jokerz-short-3-5796352'])
+        fd.download([u'http://blip.tv/cbr/cbr-exclusive-gotham-city-imposters-bats-vs-jokerz-short-3-5796352'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, '4962f94441605832eb1008eb820ef47a')
+        self.assertEqual(md5_for_file, u'b2d849efcf7ee18917e4b4d9ff37cafe')
 
     @_skip_unless(youtube_dl.InfoExtractors.XVideosIE._WORKING, "IE marked as not _WORKING")
     def test_XVideos(self):
-        filename = '939581.flv'
-        fd = FileDownloader(self.parameters)
+        filename = u'939581.flv'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.XVideosIE())
-        fd.download(['http://www.xvideos.com/video939581/funny_porns_by_s_-1'])
+        fd.download([u'http://www.xvideos.com/video939581/funny_porns_by_s_-1'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, 'aecab2ea59b7996110a7e409f0c55da3')
+        self.assertEqual(md5_for_file, u'1d0c835822f0a71a7bf011855db929d0')
 
     @_skip_unless(youtube_dl.InfoExtractors.VimeoIE._WORKING, "IE marked as not _WORKING")
-    @_skip("No output file specified")
     def test_Vimeo(self):
-        filename = ''
-        fd = FileDownloader(self.parameters)
+        filename = u'14160053.mp4'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.VimeoIE())
-        fd.download(['http://vimeo.com/14160053'])
+        fd.download([u'http://vimeo.com/14160053'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, '1ab4dedc01f771cb2a65e91caa801aaf')
+        self.assertEqual(md5_for_file, u'60540a4ec7cc378ec84b919c0aed5023')
 
     @_skip_unless(youtube_dl.InfoExtractors.SoundcloudIE._WORKING, "IE marked as not _WORKING")
     def test_Soundcloud(self):
-        filename = '62986583.mp3'
-        fd = FileDownloader(self.parameters)
+        filename = u'62986583.mp3'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.SoundcloudIE())
-        fd.download(['http://soundcloud.com/ethmusic/lostin-powers-she-so-heavy'])
+        fd.download([u'http://soundcloud.com/ethmusic/lostin-powers-she-so-heavy'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, 'c1b9b9ea8bfd620b96b2628664576e1c')
+        self.assertEqual(md5_for_file, u'ebef0a451b909710ed1d7787dddbf0d7')
 
     @_skip_unless(youtube_dl.InfoExtractors.StanfordOpenClassroomIE._WORKING, "IE marked as not _WORKING")
     def test_StanfordOpenClassroom(self):
-        filename = 'PracticalUnix_intro-environment.mp4'
-        fd = FileDownloader(self.parameters)
+        filename = u'PracticalUnix_intro-environment.mp4'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.StanfordOpenClassroomIE())
-        fd.download(['http://openclassroom.stanford.edu/MainFolder/VideoPage.php?course=PracticalUnix&video=intro-environment&speed=100'])
-        self.assertTrue(os.path.exists(filename))
-        md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, '8aac7873a07dcfaed66b1559ab128514')
-
-    @_skip_unless(youtube_dl.InfoExtractors.CollegeHumorIE._WORKING, "IE marked as not _WORKING")
-    @_skip("No output file specified")
-    def test_CollegeHumor(self):
-        filename = ''
-        fd = FileDownloader(self.parameters)
-        fd.add_info_extractor(youtube_dl.InfoExtractors.CollegeHumorIE())
-        fd.download(['http://www.collegehumor.com/video/6830834/mitt-romney-style-gangnam-style-parody'])
+        fd.download([u'http://openclassroom.stanford.edu/MainFolder/VideoPage.php?course=PracticalUnix&video=intro-environment&speed=100'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, '')
+        self.assertEqual(md5_for_file, u'544a9468546059d4e80d76265b0443b8')
 
     @_skip_unless(youtube_dl.InfoExtractors.XNXXIE._WORKING, "IE marked as not _WORKING")
     def test_XNXX(self):
-        filename = '1135332.flv'
-        fd = FileDownloader(self.parameters)
+        filename = u'1135332.flv'
+        params = self.parameters
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.XNXXIE())
-        fd.download(['http://video.xnxx.com/video1135332/lida_naked_funny_actress_5_'])
+        fd.download([u'http://video.xnxx.com/video1135332/lida_naked_funny_actress_5_'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, 'c5c67df477eb0d9b058200351448ba4c')
+        self.assertEqual(md5_for_file, u'0831677e2b4761795f68d417e0b7b445')
 
     @_skip_unless(youtube_dl.InfoExtractors.YoukuIE._WORKING, "IE marked as not _WORKING")
     def test_Youku(self):
-        filename = 'XNDgyMDQ2NTQw_part00.flv'
-        fd = FileDownloader(self.parameters)
+        filename = u'XNDgyMDQ2NTQw_part00.flv'
+        params = self.parameters
+        params["test"] = False
+        fd = FileDownloader(params)
         fd.add_info_extractor(youtube_dl.InfoExtractors.YoukuIE())
-        fd.download(['http://v.youku.com/v_show/id_XNDgyMDQ2NTQw.html'])
+        fd.download([u'http://v.youku.com/v_show/id_XNDgyMDQ2NTQw.html'])
         self.assertTrue(os.path.exists(filename))
         md5_for_file = _file_md5(filename)
-        self.assertEqual(md5_for_file, 'ffe3f2e435663dc2d1eea34faeff5b5b')
+        self.assertEqual(md5_for_file, u'ffe3f2e435663dc2d1eea34faeff5b5b')
 
 
     def tearDown(self):
-        if os.path.exists('BaW_jenozKc.mp4'):
-            os.remove('BaW_jenozKc.mp4')
-        if os.path.exists('x33vw9.mp4'):
-            os.remove('x33vw9.mp4')
-        if os.path.exists('_aUehQsCQtM.flv'):
-            os.remove('_aUehQsCQtM.flv')
-        if os.path.exists('5779306.m4v'):
-            os.remove('5779306.m4v')
-        if os.path.exists('939581.flv'):
-            os.remove('939581.flv')
-        # No file specified for Vimeo
-        if os.path.exists('62986583.mp3'):
-            os.remove('62986583.mp3')
-        if os.path.exists('PracticalUnix_intro-environment.mp4'):
-            os.remove('PracticalUnix_intro-environment.mp4')
-        # No file specified for CollegeHumor
-        if os.path.exists('1135332.flv'):
-            os.remove('1135332.flv')
-        if os.path.exists('XNDgyMDQ2NTQw_part00.flv'):
-            os.remove('XNDgyMDQ2NTQw_part00.flv')
+        if os.path.exists(u'BaW_jenozKc.mp4'):
+            os.remove(u'BaW_jenozKc.mp4')
+        if os.path.exists(u'x33vw9.mp4'):
+            os.remove(u'x33vw9.mp4')
+        if os.path.exists(u'_aUehQsCQtM.flv'):
+            os.remove(u'_aUehQsCQtM.flv')
+        if os.path.exists(u'5779306.m4v'):
+            os.remove(u'5779306.m4v')
+        if os.path.exists(u'939581.flv'):
+            os.remove(u'939581.flv')
+        if os.path.exists(u'14160053.mp4'):
+            os.remove(u'14160053.mp4')
+        if os.path.exists(u'62986583.mp3'):
+            os.remove(u'62986583.mp3')
+        if os.path.exists(u'PracticalUnix_intro-environment.mp4'):
+            os.remove(u'PracticalUnix_intro-environment.mp4')
+        if os.path.exists(u'1135332.flv'):
+            os.remove(u'1135332.flv')
+        if os.path.exists(u'XNDgyMDQ2NTQw_part00.flv'):
+            os.remove(u'XNDgyMDQ2NTQw_part00.flv')