aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergey M․ <dstftw@gmail.com>2019-05-20 23:23:18 +0700
committerSergey M․ <dstftw@gmail.com>2019-05-20 23:23:18 +0700
commitce2fe4c01cceef4b636995275b573baf51587fa8 (patch)
treed78af04e0e4ee2670ffd6a02dd80dbd9dad7d0c2
parenta9e03736dfb2038d6a569e6305f4ac727a8ac71b (diff)
downloadyoutube-dl-ce2fe4c01cceef4b636995275b573baf51587fa8.tar.xz
[extractor/common] Add doc string for _apply_first_set_cookie_header
-rw-r--r--youtube_dl/extractor/common.py22
1 files changed, 13 insertions, 9 deletions
diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py
index f994953bc..937237b3f 100644
--- a/youtube_dl/extractor/common.py
+++ b/youtube_dl/extractor/common.py
@@ -2818,15 +2818,19 @@ class InfoExtractor(object):
return compat_cookies.SimpleCookie(req.get_header('Cookie'))
def _apply_first_set_cookie_header(self, url_handle, cookie):
- # Some sites (e.g. [1-3]) may serve two cookies under the same name
- # in Set-Cookie header and expect the first (old) one to be set rather
- # than second (new). However, as of RFC6265 the newer one cookie
- # should be set into cookie store what actually happens.
- # We will workaround this issue by resetting the cookie to
- # the first one manually.
- # 1. https://new.vk.com/
- # 2. https://github.com/ytdl-org/youtube-dl/issues/9841#issuecomment-227871201
- # 3. https://learning.oreilly.com/
+ """
+ Apply first Set-Cookie header instead of the last. Experimental.
+
+ Some sites (e.g. [1-3]) may serve two cookies under the same name
+ in Set-Cookie header and expect the first (old) one to be set rather
+ than second (new). However, as of RFC6265 the newer one cookie
+ should be set into cookie store what actually happens.
+ We will workaround this issue by resetting the cookie to
+ the first one manually.
+ 1. https://new.vk.com/
+ 2. https://github.com/ytdl-org/youtube-dl/issues/9841#issuecomment-227871201
+ 3. https://learning.oreilly.com/
+ """
for header, cookies in url_handle.headers.items():
if header.lower() != 'set-cookie':
continue