aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKacper Michajłow <kasper93@gmail.com>2016-11-05 06:11:51 +0100
committerKacper Michajłow <kasper93@gmail.com>2016-11-11 15:36:57 +0100
commit189935f15960300d316e8b07108b076ac6c2186a (patch)
treee6a41b6feebe5a29ea18e30308d0202b460d71a7
parentbc40b3a5ba44006c23daf7fe0ed872af5e33bdc5 (diff)
[jsinterp] Fix function calls without arguments.
-rw-r--r--test/test_jsinterp.py7
-rw-r--r--youtube_dl/jsinterp.py4
2 files changed, 9 insertions, 2 deletions
diff --git a/test/test_jsinterp.py b/test/test_jsinterp.py
index 63c350b8f..a9abae5f5 100644
--- a/test/test_jsinterp.py
+++ b/test/test_jsinterp.py
@@ -104,6 +104,13 @@ class TestJSInterpreter(unittest.TestCase):
}''')
self.assertEqual(jsi.call_function('x'), [20, 20, 30, 40, 50])
+ def test_call(self):
+ jsi = JSInterpreter('''
+ function x() { return 2; }
+ function y(a) { return x() + a; }
+ function z() { return y(3); }
+ ''')
+ self.assertEqual(jsi.call_function('z'), 5)
if __name__ == '__main__':
unittest.main()
diff --git a/youtube_dl/jsinterp.py b/youtube_dl/jsinterp.py
index 9737f7002..a8df4aef0 100644
--- a/youtube_dl/jsinterp.py
+++ b/youtube_dl/jsinterp.py
@@ -198,12 +198,12 @@ class JSInterpreter(object):
return opfunc(x, y)
m = re.match(
- r'^(?P<func>%s)\((?P<args>[a-zA-Z0-9_$,]+)\)$' % _NAME_RE, expr)
+ r'^(?P<func>%s)\((?P<args>[a-zA-Z0-9_$,]*)\)$' % _NAME_RE, expr)
if m:
fname = m.group('func')
argvals = tuple([
int(v) if v.isdigit() else local_vars[v]
- for v in m.group('args').split(',')])
+ for v in m.group('args').split(',')]) if len(m.group('args')) > 0 else tuple()
if fname not in self._functions:
self._functions[fname] = self.extract_function(fname)
return self._functions[fname](argvals)