aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYen Chi Hsuan <yan12125@gmail.com>2016-10-20 15:07:19 +0800
committerYen Chi Hsuan <yan12125@gmail.com>2016-10-20 15:07:19 +0800
commit8e2915d70bf46ee84e2f88e0fa8152a528228f26 (patch)
tree223a7f07583a90cb22a69099cb0966888e68fcaa
parent19e447150d7f662e4c1552d9d3aae7677a182a93 (diff)
Revert "[postprocessor/embedthumbnail] Allow mkv to embed thumbnails"
This reverts commit 7360db05b43741c2dfa1fd024e9c2f013ed97c9e. This commit was added as an attempt to fix #6046. Unfortunately, the fix is completely wrong. As reported on #10359, embedded thumbnails are not displayed in VLC, and Se7en on IRC reports that the embedded thumbnail misleads mpv as well. The correct way is using -attachment of ffmpeg, while the current run_ffmpeg_multiple_files API can't handle it cleanly.
-rw-r--r--youtube_dl/postprocessor/embedthumbnail.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/youtube_dl/postprocessor/embedthumbnail.py b/youtube_dl/postprocessor/embedthumbnail.py
index 2e4789eb2..e606a58de 100644
--- a/youtube_dl/postprocessor/embedthumbnail.py
+++ b/youtube_dl/postprocessor/embedthumbnail.py
@@ -40,7 +40,7 @@ class EmbedThumbnailPP(FFmpegPostProcessor):
'Skipping embedding the thumbnail because the file is missing.')
return [], info
- if info['ext'] in ('mp3', 'mkv'):
+ if info['ext'] == 'mp3':
options = [
'-c', 'copy', '-map', '0', '-map', '1',
'-metadata:s:v', 'title="Album cover"', '-metadata:s:v', 'comment="Cover (Front)"']