diff options
| author | Sergey M․ <dstftw@gmail.com> | 2016-05-09 22:05:12 +0600 |
|---|---|---|
| committer | Sergey M․ <dstftw@gmail.com> | 2016-05-09 22:05:12 +0600 |
| commit | e62d9c5caaa972ef4b1ed5d6ab5ee4a087a4ba95 (patch) | |
| tree | 5410271a6c49acce9ecdbafa41eb445fd4ce69c7 | |
| parent | 20cfdcc910d0bc2ee4b0ee38bdf5e6ecb67e5731 (diff) | |
| download | youtube-dl-e62d9c5caaa972ef4b1ed5d6ab5ee4a087a4ba95.tar.xz | |
[downloader/external] Call ffmpeg with with HTTP_PROXY env variable set (#9437)
| -rw-r--r-- | youtube_dl/downloader/external.py | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/youtube_dl/downloader/external.py b/youtube_dl/downloader/external.py index 45f49c350..3a73cee1c 100644 --- a/youtube_dl/downloader/external.py +++ b/youtube_dl/downloader/external.py @@ -6,6 +6,7 @@ import sys import re from .common import FileDownloader +from ..compat import compat_setenv from ..postprocessor.ffmpeg import FFmpegPostProcessor, EXT_TO_OUT_FORMATS from ..utils import ( cli_option, @@ -198,6 +199,18 @@ class FFmpegFD(ExternalFD): '-headers', ''.join('%s: %s\r\n' % (key, val) for key, val in headers.items())] + env = None + proxy = self.params.get('proxy') + if proxy: + if not re.match(r'^[\da-zA-Z]+://', proxy): + proxy = 'http://%s' % proxy + # Since December 2015 ffmpeg supports -http_proxy option (see + # http://git.videolan.org/?p=ffmpeg.git;a=commit;h=b4eb1f29ebddd60c41a2eb39f5af701e38e0d3fd) + # We could switch to the following code if we are able to detect version properly + # args += ['-http_proxy', proxy] + env = os.environ.copy() + compat_setenv('HTTP_PROXY', proxy, env=env) + protocol = info_dict.get('protocol') if protocol == 'rtmp': @@ -239,7 +252,7 @@ class FFmpegFD(ExternalFD): self._debug_cmd(args) - proc = subprocess.Popen(args, stdin=subprocess.PIPE) + proc = subprocess.Popen(args, stdin=subprocess.PIPE, env=env) try: retval = proc.wait() except KeyboardInterrupt: |