diff options
| author | Jaime Marquínez Ferrándiz <jaime.marquinez.ferrandiz@gmail.com> | 2015-02-19 14:54:50 +0100 | 
|---|---|---|
| committer | Jaime Marquínez Ferrándiz <jaime.marquinez.ferrandiz@gmail.com> | 2015-02-19 14:54:50 +0100 | 
| commit | 8807f1277f8c69488046fc7215cc79165e976ff3 (patch) | |
| tree | 4f33f33333618c2c31f9786c028fc63ea38c7234 | |
| parent | 4f7cea6c5327fdda79877e34e630c478f0e5d4dd (diff) | |
[theplatform] Convert to new subtitles system
| -rw-r--r-- | test/test_subtitles.py | 15 | ||||
| -rw-r--r-- | youtube_dl/extractor/theplatform.py | 18 | 
2 files changed, 22 insertions, 11 deletions
| diff --git a/test/test_subtitles.py b/test/test_subtitles.py index 98d1afff4..c04fe6f22 100644 --- a/test/test_subtitles.py +++ b/test/test_subtitles.py @@ -24,6 +24,7 @@ from youtube_dl.extractor import (      NRKTVIE,      RaiIE,      VikiIE, +    ThePlatformIE,  ) @@ -385,5 +386,19 @@ class TestVikiSubtitles(BaseTestSubtitles):          self.assertEqual(md5(subtitles['en']), 'b0b781eeb45efd3f6398a925b259150b') +class TestThePlatformSubtitles(BaseTestSubtitles): +    # from http://www.3playmedia.com/services-features/tools/integrations/theplatform/ +    # (see http://theplatform.com/about/partners/type/subtitles-closed-captioning/) +    url = 'theplatform:JFUjUE1_ehvq' +    IE = ThePlatformIE + +    def test_allsubtitles(self): +        self.DL.params['writesubtitles'] = True +        self.DL.params['allsubtitles'] = True +        subtitles = self.getSubtitles() +        self.assertEqual(set(subtitles.keys()), set(['en'])) +        self.assertEqual(md5(subtitles['en']), '97e7670cbae3c4d26ae8bcc7fdd78d4b') + +  if __name__ == '__main__':      unittest.main() diff --git a/youtube_dl/extractor/theplatform.py b/youtube_dl/extractor/theplatform.py index 1579822f2..5f24189cc 100644 --- a/youtube_dl/extractor/theplatform.py +++ b/youtube_dl/extractor/theplatform.py @@ -8,7 +8,7 @@ import binascii  import hashlib -from .subtitles import SubtitlesInfoExtractor +from .common import InfoExtractor  from ..compat import (      compat_str,  ) @@ -22,7 +22,7 @@ from ..utils import (  _x = lambda p: xpath_with_ns(p, {'smil': 'http://www.w3.org/2005/SMIL21/Language'}) -class ThePlatformIE(SubtitlesInfoExtractor): +class ThePlatformIE(InfoExtractor):      _VALID_URL = r'''(?x)          (?:https?://(?:link|player)\.theplatform\.com/[sp]/(?P<provider_id>[^/]+)/             (?P<config>(?:[^/\?]+/(?:swf|config)|onsite)/select/)? @@ -104,15 +104,11 @@ class ThePlatformIE(SubtitlesInfoExtractor):          captions = info.get('captions')          if isinstance(captions, list):              for caption in captions: -                lang, src = caption.get('lang'), caption.get('src') -                if lang and src: -                    subtitles[lang] = src - -        if self._downloader.params.get('listsubtitles', False): -            self._list_available_subtitles(video_id, subtitles) -            return - -        subtitles = self.extract_subtitles(video_id, subtitles) +                lang, src, mime = caption.get('lang', 'en'), caption.get('src'), caption.get('type') +                subtitles[lang] = [{ +                    'ext': 'srt' if mime == 'text/srt' else 'ttml', +                    'url': src, +                }]          head = meta.find(_x('smil:head'))          body = meta.find(_x('smil:body')) | 
