aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilipp Hagemeister <phihag@phihag.de>2013-11-29 15:25:09 +0100
committerPhilipp Hagemeister <phihag@phihag.de>2013-11-29 15:25:11 +0100
commita3fb4675fb67b061e2a71cec78a5dbd8695b8ef0 (patch)
tree5266535b71cbbc0de76dfbf32bd031457ba74755
parent17769d5a6c24eb8f5d609aa99f84debc3fe4adec (diff)
Do not mutate default arguments
In this case, it looks rather harmless (since the conditions for --restrict-filenames should not change while a process is running), but just to be sure. This also simplifies the interface for callers, who can just pass in the idiomatic None for "I don't care, whatever is the default".
-rw-r--r--youtube_dl/YoutubeDL.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py
index 711b5d79e..b822930cb 100644
--- a/youtube_dl/YoutubeDL.py
+++ b/youtube_dl/YoutubeDL.py
@@ -146,7 +146,7 @@ class YoutubeDL(object):
_num_downloads = None
_screen_file = None
- def __init__(self, params={}):
+ def __init__(self, params=None):
"""Create a FileDownloader object with the given options."""
self._ies = []
self._ies_instances = {}
@@ -155,7 +155,7 @@ class YoutubeDL(object):
self._download_retcode = 0
self._num_downloads = 0
self._screen_file = [sys.stdout, sys.stderr][params.get('logtostderr', False)]
- self.params = params
+ self.params = {} if params is None else params
if (sys.version_info >= (3,) and sys.platform != 'win32' and
sys.getfilesystemencoding() in ['ascii', 'ANSI_X3.4-1968']