diff options
| author | Yen Chi Hsuan <yan12125@gmail.com> | 2016-10-22 13:04:05 +0800 |
|---|---|---|
| committer | Yen Chi Hsuan <yan12125@gmail.com> | 2016-10-22 13:04:05 +0800 |
| commit | b64d04c119cd835683b95c13667dbae5db8b939f (patch) | |
| tree | faa3980e92f9726434af0873fab5ff076d3b33e5 | |
| parent | 00ca7552317bb69ce8eb84582d658d5e52997394 (diff) | |
[utils] Clarify for redirecting STDIN in get_exe_version()
| -rw-r--r-- | youtube_dl/utils.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py index a89ff6908..2770c5f1c 100644 --- a/youtube_dl/utils.py +++ b/youtube_dl/utils.py @@ -1818,6 +1818,9 @@ def get_exe_version(exe, args=['--version'], """ Returns the version of the specified executable, or False if the executable is not present """ try: + # STDIN should be redirected too. On UNIX-like systems, ffmpeg triggers + # SIGTTOU if youtube-dl is run in the background. + # See https://github.com/rg3/youtube-dl/issues/955#issuecomment-209789656 out, _ = subprocess.Popen( [encodeArgument(exe)] + args, stdin=subprocess.PIPE, |