aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-09[cmake][modules] Rework libdvd* modulesfuzzard
Streamline, remove some redundancies, actually be a shared library target
2024-07-09[cmake][modules] FindLibDvd add explicit dependency to libdvdnav targetfuzzard
2024-07-09[cmake] create function to add dependency to a targetfuzzard
A target may not always use target_link_libraries to create dependency chains. export-files is an example, and we want to make sure it has a dependency on all libs to be acquired/built before trying to execute the export-files script
2024-07-09[addons][filesystem][docs] Add verifypeer to ADDON_CURL_OPTION_OPTIONCastagnaIT
2024-07-08Merge pull request #25022 from CrystalP/ref-deletemovieCrystalP
[videodb] Movie Deletion/Conversion to Version Refactor and Optimization
2024-07-08Estuary: Improve background texturessarbes
2024-07-08Merge pull request #25368 from enen92/edl_std_chronoMiguel Borges de Freitas
[EDL] Use std::chrono
2024-07-08[GUIWindowSlideShow] Close dialog if a video starts playingenen92
2024-07-08[EDL] Use std::chronoenen92
2024-07-08Merge pull request #25442 from CastagnaIT/ass_detectMiguel Borges de Freitas
[DVDFactorySubtitle] Improved ASS format detection
2024-07-08Merge pull request #25426 from enen92/deadlockaMiguel Borges de Freitas
[GUI][X11] Fix deadlock on dialog renderloop
2024-07-08[DVDFactorySubtitle] Improved ASS format detectionCastagnaIT
2024-07-07Merge pull request #25136 from CrystalP/extras-specialcharCrystalP
[video] Preserve special characters in default names of extras
2024-07-07[videodb] Preserve path hash when turning a movie into a versionCrystalP
This is a small optimization: the path hash is deleted when a movie is turned into a version, and during the next libray scan, the folder of the movie is scanned (unnecessary) and the same hash is recreated. The file of the version hasn't moved or changed, the hash is still valid, might as well not delete it in the first place and save the directory scan.
2024-07-07[videodb] Remove redundant deletion of stream details when setting movie detailsCrystalP
SetStreamDetailsForFileId clears existing details unconditionnally, then adds the new ones. Added doxygen.
2024-07-07[videodb] Remove KeepId from DeleteMovieCrystalP
DeleteMovie behaves very differently with KeepId=true and turns it into a "DeleteStreams" function. To simplify the logic, remove the parameter and make the only caller do the stream deletion directly.
2024-07-07Merge pull request #25232 from CrystalP/assettypechangeCrystalP
[video] Allow changing the type of a movie asset between version and extra
2024-07-07Fix texture edge clamping (#25444)sarbes
2024-07-07Remove duplicated EpgEventTitle from PVR listsMartin Vallevand
In the common PVRListItemLayout if the ListItem.Label is the same as the ListItem.EpgEventTitle the sub-labels will show the duplicated title and give priority screen space to it. This skips those displays
2024-07-06RecursiveMutex: Prevent initialization-order-fiasco of mutex attributeMarkus Härer
ASAN error: ==226990==ERROR: AddressSanitizer: initialization-order-fiasco on address 0x5a8f25b81ce0 at pc 0x5a8f17dd10ae bp 0x7ffe5391ce50 sp 0x7ffe5391ce48 READ of size 1 at 0x5a8f25b81ce0 thread T0 #0 0x5a8f17dd10ad in XbmcThreads::CRecursiveMutex::getRecursiveAttr() xbmc/platform/posix/threads/RecursiveMutex.cpp:37:8 #1 0x5a8f17817a4e in XbmcThreads::CRecursiveMutex::CRecursiveMutex() xbmc/platform/posix/threads/RecursiveMutex.h:35:60 #2 0x5a8f17817998 in XbmcThreads::CountingLockable<XbmcThreads::CRecursiveMutex>::CountingLockable() xbmc/threads/Lockables.h:47:12 #3 0x5a8f1780dae8 in CCriticalSection::CCriticalSection() xbmc/threads/CriticalSection.h:16:7 #4 0x5a8f1b27fd98 in CComponentContainer<IApplicationComponent>::CComponentContainer() xbmc/utils/ComponentContainer.h:26:7 #5 0x5a8f1b1f3273 in CApplication::CApplication() xbmc/application/Application.cpp:217:15 #6 0x5a8f17918fe0 in xbmcutil::GlobalsSingleton<CApplication>::getInstance() xbmc/utils/GlobalsHandling.h:147:23 #7 0x5a8f17918f0f in __cxx_global_var_init.1 xbmc/application/Application.h:250:1 #8 0x5a8f17918f49 in _GLOBAL__sub_I_UPnPRenderer.cpp xbmc/network/upnp/UPnPRenderer.cpp #9 0x7c5016639dc3 in __libc_start_main (/usr/lib/libc.so.6+0x25dc3) (BuildId: 32a656aa5562eece8c59a585f5eacd6cf5e2307b) #10 0x5a8f17636814 in _start (/home/mark/Coding/Repos/kodi-git/build_clang_debug_sanitizer/kodi.bin+0x9fa3814) (BuildId: 6cfd7dacce8a4a587ad47d2f082a4e50dad4c176) 0x5a8f25b81ce0 is located 32 bytes before global variable 'XbmcThreads::recursiveAttr' defined in 'xbmc/platform/posix/threads/RecursiveMutex.cpp' (0x5a8f25b81d00) of size 4 registered at: #0 0x5a8f17651629 in __asan_register_globals.part.0 (/home/mark/Coding/Repos/kodi-git/build_clang_debug_sanitizer/kodi.bin+0x9fbe629) (BuildId: 6cfd7dacce8a4a587ad47d2f082a4e50dad4c176) #1 0x5a8f17651cce in __asan_register_elf_globals (/home/mark/Coding/Repos/kodi-git/build_clang_debug_sanitizer/kodi.bin+0x9fbecce) (BuildId: 6cfd7dacce8a4a587ad47d2f082a4e50dad4c176) #2 0x7c5016639dc3 in __libc_start_main (/usr/lib/libc.so.6+0x25dc3) (BuildId: 32a656aa5562eece8c59a585f5eacd6cf5e2307b) #3 0x5a8f17636814 in _start (/home/mark/Coding/Repos/kodi-git/build_clang_debug_sanitizer/kodi.bin+0x9fa3814) (BuildId: 6cfd7dacce8a4a587ad47d2f082a4e50dad4c176) 0x5a8f25b81ce0 is located 0 bytes inside of global variable 'XbmcThreads::recursiveAttrSet' defined in 'xbmc/platform/posix/threads/RecursiveMutex.cpp' (0x5a8f25b81ce0) of size 1 'XbmcThreads::recursiveAttrSet' is ascii string '' registered at: #0 0x5a8f17651629 in __asan_register_globals.part.0 (/home/mark/Coding/Repos/kodi-git/build_clang_debug_sanitizer/kodi.bin+0x9fbe629) (BuildId: 6cfd7dacce8a4a587ad47d2f082a4e50dad4c176) #1 0x5a8f17651cce in __asan_register_elf_globals (/home/mark/Coding/Repos/kodi-git/build_clang_debug_sanitizer/kodi.bin+0x9fbecce) (BuildId: 6cfd7dacce8a4a587ad47d2f082a4e50dad4c176) #2 0x7c5016639dc3 in __libc_start_main (/usr/lib/libc.so.6+0x25dc3) (BuildId: 32a656aa5562eece8c59a585f5eacd6cf5e2307b) #3 0x5a8f17636814 in _start (/home/mark/Coding/Repos/kodi-git/build_clang_debug_sanitizer/kodi.bin+0x9fa3814) (BuildId: 6cfd7dacce8a4a587ad47d2f082a4e50dad4c176) SUMMARY: AddressSanitizer: initialization-order-fiasco xbmc/platform/posix/threads/RecursiveMutex.cpp:37:8 in XbmcThreads::CRecursiveMutex::getRecursiveAttr() Shadow bytes around the buggy address: 0x5a8f25b81a00: f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 00 00 00 00 0x5a8f25b81a80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x5a8f25b81b00: 00 00 f9 f9 f9 f9 f9 f9 00 f9 f9 f9 00 00 00 00 0x5a8f25b81b80: f6 f6 f6 f6 00 00 00 00 f6 f6 f6 f6 f6 f6 f6 f6 0x5a8f25b81c00: f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 =>0x5a8f25b81c80: 00 00 00 00 f6 f6 f6 f6 00 00 00 00[f6]f6 f6 f6 0x5a8f25b81d00: 04 f9 f9 f9 01 f9 f9 f9 00 00 00 00 f6 f6 f6 f6 0x5a8f25b81d80: 00 00 00 00 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 f6 0x5a8f25b81e00: 00 00 00 00 f6 f6 f6 f6 00 00 00 00 f9 f9 f9 f9 0x5a8f25b81e80: 00 f9 f9 f9 00 f9 f9 f9 f6 f6 f6 f6 f6 f6 f6 f6 0x5a8f25b81f00: f6 f6 f6 f6 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb
2024-07-05Merge pull request #25388 from garbear/android-fix-mapGarrett Brown
Android: Improve default button maps slightly
2024-07-05Android: Prevent duplicate mapping of surjective keysGarrett Brown
2024-07-05Android: Add missing mutex on object create/read/destroyGarrett Brown
2024-07-05Merge pull request #25435 from garbear/flatbuffer-namespaceGarrett Brown
RetroPlayer: Move FlatBuffer types to sub-namespace
2024-07-04Merge pull request #25413 from ksooo/pvr-fix-reminders-updateKai Sommerfeld
[PVR] Fix Reminders update special cases
2024-07-03RetroPlayer: Move FlatBuffer types to sub-namespaceGarrett Brown
2024-07-03Merge pull request #25412 from ksooo/pvr-channelgroupscontainer-pointersKai Sommerfeld
[PVR] CPVRChannelGroupsContainer: Replace raw pointers with std::shared_ptr
2024-07-03Merge pull request #25427 from a1rwulf/fix-queue-timesizeWolfgang Haupt
VP: Allow subsecond queue sizes
2024-07-03Merge pull request #25419 from fuzzard/cmake_pcre2_minorsfuzzard
[cmake][modules] FindPCRE2 minor build option updates
2024-07-02Merge pull request #25392 from Rechi/clang-tidy/performanceRechi
[clang-tidy] fix modernize-* and performance-* warnings
2024-07-02Upload XBT textures with right dimensionssarbes
2024-07-02VP: Allow subsecond queue sizesWolfgang Haupt
Signed-off-by: Wolfgang Haupt <haupt.wolfgang@gmail.com>
2024-07-02[GUI][X11] Fix deadlock on dialog renderloopenen92
2024-07-02Don't change fileending to pngKolja Lampe
2024-07-01[cmake][modules] FindPCRE2 minor build option updatesfuzzard
use PIC option when building, properly disable JIT for windows/darwinembedded, add newline option we have used previously in pcre1
2024-07-01Merge pull request #25418 from joseluismarti/android-makefilefuzzard
[Android] Remove unused variables in makefile
2024-07-01[clang-tidy] performance-unnecessary-copy-initializationRechi
2024-07-01[clang-tidy] modernize-make-sharedRechi
2024-06-30Remove unused variables in makefileJose Luis Marti
2024-06-30[PVR] CPVRChannelGroupsContainer: Replace raw pointers with std::shared_ptr.ksooo
2024-06-30Merge pull request #25387 from notspiff/add_artutilsArne Morten Kvarving
changed: move CFileItem::GetTBNFile to ArtUtils
2024-06-30drop str prefix for string variablesArne Morten Kvarving
2024-06-30changed: move CFileItem::GetTBNFile to ArtUtilsArne Morten Kvarving
2024-06-30Merge pull request #25390 from fuzzard/buildsteps_win_testfailjenkins4kodi
2024-06-30Merge pull request #25411 from thexai/no-bluethexai
[Windows] remove blue color from tests script
2024-06-30Merge pull request #25408 from notspiff/fix_mimejenkins4kodi
2024-06-30[PVR] Fix CPVRTimers::UpdateEntries: Re-insert timers with changed start ↵ksooo
time before checking whether new children for local timer rules need to be created. The timers with changed start time need to be found during that check. This fixes creation of duplicate timers.
2024-06-30[PVR] Fix CPVRTimers::UpdateEntries: Delete existing epg-based local timers ↵ksooo
if the respective EPG tag was re-used for an unrelated event that no longer matches the related timer rule.
2024-06-30[PVR] Fix CPVRTimers::UpdateEntries: Delete existing epg-based local timers ↵ksooo
if the respective EPG tag does no longer exist.
2024-06-30add std:: prefix to shut up ksooo-formatArne Morten Kvarving