| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
into the db
|
|
|
|
|
|
Core code cleanup
|
|
[python-api] - several additions
|
|
|
|
|
|
|
|
|
|
|
|
Eliminate a temporary std::string during construction.
|
|
Reduce runtime overhead.
|
|
May be cheaper.
|
|
Reduce runtime overhead.
|
|
Music library artist roles node showing all roles, both standard and TMCL/Performer
|
|
Better handling of mis-matching musicbrianz (album) artist id and hints tags
|
|
[PVR] EPG data import performance tuning.
|
|
and (Album) Artist tags when creating songs and albums.
Fix missing hints (ALBUMARTISTS tag) causing artist hints to be used to get album artist to match mbid rather than try album artist itself. Made mess when artist hints are broken and repair happening.
|
|
ffmpeg: reduce log spam
|
|
|
|
Format numbers with localized separators
|
|
DLL-Loader whitelist instead blacklist until sandboxing is an topic
|
|
CDebugRenderer: fix debug info overlays alignment
|
|
[win32][dependencies] New build of openssl that's not linked against debug vcruntime
|
|
|
|
and navigate to the artists with that role
Estuary change for Roles node to display with icon wall.
|
|
|
|
listing 'all'
|
|
versions are not included
|
|
|
|
|
|
[android] fix delay when opening programs window
|
|
CID1358574: Fixes warning
|
|
|
|
The "Deadcode" it complains of is the "break;" statement below. All of the
case labels are accounted for in the if branching, so the final "break;" is
never hit.
________________________________________________________________________________________________________
*** CID 1355584: Control flow issues (DEADCODE)
/xbmc/addons/AddonBuilder.cpp: 140 in ADDON::CAddonBuilder::Build()()
134 return CAudioDecoder::FromExtension(std::move(m_props), m_extPoint);
135 else if (type == ADDON_INPUTSTREAM)
136 return CInputStream::FromExtension(std::move(m_props), m_extPoint);
137 else if (type == ADDON_SCREENSAVER)
138 return std::make_shared<CScreenSaver>(std::move(m_props));
139 else if (type == ADDON_PERIPHERALDLL)
>>> CID 1355584: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "~unique_ptr" inside this statement: "<temporary>.~unique_ptr();".
140 return PERIPHERALS::CPeripheralAddon::FromExtension(std::move(m_props), m_extPoint);
141 break;
142 }
143 case ADDON_SKIN:
144 return CSkinInfo::FromExtension(std::move(m_props), m_extPoint);
145 case ADDON_RESOURCE_IMAGES:
|
|
________________________________________________________________________________________________________
*** CID 1355586: Control flow issues (MISMATCHED_ITERATOR)
/xbmc/games/controllers/windows/GUIControllerList.cpp: 185 in GAME::CGUIControllerList::RefreshControllers()()
179
180 // Remove old controllers
181 for (ControllerVector::iterator it = m_controllers.begin(); it != m_controllers.end(); /* ++it */)
182 {
183 ControllerPtr& controller = *it;
184
>>> CID 1355586: Control flow issues (MISMATCHED_ITERATOR)
>>> Comparing "std::find_if(controllers.begin(), controllers.end(), GAME::CGUIControllerList::RefreshControllers()::[lambda(std::shared_ptr<GAME::CController> const &) (instance 2)](GAME::CGUIControllerList::RefreshControllers()::[lambda(std::shared_ptr<GAME::CController> const &) (instance 2)]({controller})))" from "controllers" to "newControllers.end()" from "newControllers".
185 if (std::find_if(controllers.begin(), controllers.end(),
186 [controller](const ControllerPtr& ctrl)
187 {
188 return ctrl->ID() == controller->ID();
189 }) == newControllers.end())
190 {
|
|
________________________________________________________________________________________________________
*** CID 1355594: Uninitialized members (UNINIT_CTOR)
/xbmc/peripherals/addons/AddonButtonMapping.cpp: 51 in PERIPHERALS::CAddonButtonMapping::CAddonButtonMapping(PERIPHERALS::CPeripheral *, JOYSTICK::IButtonMapper *)()
45 m_buttonMap = new CAddonButtonMap(peripheral, addon, mapper->ControllerID());
46 if (m_buttonMap->Load())
47 m_driverHandler = new CButtonMapping(mapper, m_buttonMap);
48 else
49 SAFE_DELETE(m_buttonMap);
50 }
>>> CID 1355594: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_buttonMap" is not initialized in this constructor nor in any functions that it calls.
51 }
52
53 CAddonButtonMapping::~CAddonButtonMapping(void)
54 {
55 delete m_driverHandler;
56 delete m_buttonMap;
________________________________________________________________________________________________________
*** CID 1355593: Uninitialized members (UNINIT_CTOR)
/xbmc/peripherals/addons/AddonInputHandling.cpp: 51 in PERIPHERALS::CAddonInputHandling::CAddonInputHandling(PERIPHERALS::CPeripheral *, JOYSTICK::IInputHandler *)()
45 m_buttonMap = new CAddonButtonMap(peripheral, addon, handler->ControllerID());
46 if (m_buttonMap->Load())
47 m_driverHandler = new CInputHandling(handler, m_buttonMap);
48 else
49 SAFE_DELETE(m_buttonMap);
50 }
>>> CID 1355593: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_buttonMap" is not initialized in this constructor nor in any functions that it calls.
51 }
52
53 CAddonInputHandling::~CAddonInputHandling(void)
54 {
55 delete m_driverHandler;
56 delete m_buttonMap;
|
|
|
|
|
