aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CONTRIBUTING.md2
-rw-r--r--tools/darwin/packaging/atv2/mkdeb-atv2.sh.in2
-rw-r--r--tools/darwin/packaging/ios/mkdeb-ios.sh.in2
-rw-r--r--tools/depends/native/tar-native/Makefile2
-rw-r--r--xbmc/guilib/GUIEditControl.cpp1
-rw-r--r--xbmc/interfaces/json-rpc/JSONServiceDescription.cpp8
-rw-r--r--xbmc/interfaces/legacy/ListItem.cpp2
-rw-r--r--xbmc/interfaces/legacy/Window.cpp4
-rw-r--r--xbmc/interfaces/legacy/WindowInterceptor.h12
-rw-r--r--xbmc/video/VideoDatabase.cpp7
-rw-r--r--xbmc/windows/GUIMediaWindow.cpp12
11 files changed, 31 insertions, 23 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index f5bf07b95c..ad06859df0 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,6 +1,6 @@
## Questions about Kodi?
-To get your questions answered, please ask in the [Kodi community forums] (http://forum.kodi.tv/) or on IRC: #xbmc on freenode.net
+To get your questions answered, please ask in the [Kodi community forums] (http://forum.kodi.tv/) or on IRC: #kodi on freenode.net
Do not open an issue.
diff --git a/tools/darwin/packaging/atv2/mkdeb-atv2.sh.in b/tools/darwin/packaging/atv2/mkdeb-atv2.sh.in
index fefc6ce0a7..c309036b39 100644
--- a/tools/darwin/packaging/atv2/mkdeb-atv2.sh.in
+++ b/tools/darwin/packaging/atv2/mkdeb-atv2.sh.in
@@ -4,7 +4,7 @@
XBMC_DEPENDS_ROOT=@DEPENDS_ROOT_FOR_XCODE@
SWITCH=`echo $1 | tr [A-Z] [a-z]`
DIRNAME=`dirname $0`
-DSYM_TARGET_DIR=${XBMC_DEPENDS_ROOT}/dSyms
+DSYM_TARGET_DIR=/Users/Shared/xbmc-depends/dSyms
DSYM_FILENAME=@APP_NAME@.frappliance.dSYM
if [ ${SWITCH:-""} = "debug" ]; then
diff --git a/tools/darwin/packaging/ios/mkdeb-ios.sh.in b/tools/darwin/packaging/ios/mkdeb-ios.sh.in
index f159bf9a19..c868141889 100644
--- a/tools/darwin/packaging/ios/mkdeb-ios.sh.in
+++ b/tools/darwin/packaging/ios/mkdeb-ios.sh.in
@@ -5,7 +5,7 @@
XBMC_DEPENDS_ROOT=@DEPENDS_ROOT_FOR_XCODE@
SWITCH=`echo $1 | tr [A-Z] [a-z]`
DIRNAME=`dirname $0`
-DSYM_TARGET_DIR=${XBMC_DEPENDS_ROOT}/dSyms
+DSYM_TARGET_DIR=/Users/Shared/xbmc-depends/dSyms
DSYM_FILENAME=@APP_NAME@.app.dSYM
if [ ${SWITCH:-""} = "debug" ]; then
diff --git a/tools/depends/native/tar-native/Makefile b/tools/depends/native/tar-native/Makefile
index 274c74c588..5064d3f765 100644
--- a/tools/depends/native/tar-native/Makefile
+++ b/tools/depends/native/tar-native/Makefile
@@ -12,7 +12,7 @@ ARCHIVE=$(SOURCE).tar.gz
export LIBTOOL=builds/unix/libtool
export PATH:=$(PREFIX)/bin:$(PATH)
CONFIGURE=./configure --prefix=$(PREFIX) \
---program-transform-name=s/tar/gtar/ --disable-dependency-tracking
+--program-transform-name=s/tar/gtar/ --disable-dependency-tracking ac_cv_func_fdopendir=no
APP=$(SOURCE)/src/tar
APPBIN=$(PREFIX)/bin/tar
diff --git a/xbmc/guilib/GUIEditControl.cpp b/xbmc/guilib/GUIEditControl.cpp
index 96bcd87fa1..72f2f70d81 100644
--- a/xbmc/guilib/GUIEditControl.cpp
+++ b/xbmc/guilib/GUIEditControl.cpp
@@ -746,4 +746,5 @@ void CGUIEditControl::SetFocus(bool focus)
m_smsTimer.Stop();
g_Windowing.EnableTextInput(focus);
CGUIControl::SetFocus(focus);
+ SetInvalid();
}
diff --git a/xbmc/interfaces/json-rpc/JSONServiceDescription.cpp b/xbmc/interfaces/json-rpc/JSONServiceDescription.cpp
index ec889f3727..a5c1bfc7b0 100644
--- a/xbmc/interfaces/json-rpc/JSONServiceDescription.cpp
+++ b/xbmc/interfaces/json-rpc/JSONServiceDescription.cpp
@@ -1154,9 +1154,9 @@ void JSONSchemaTypeDefinition::Set(const JSONSchemaTypeDefinitionPtr typeDefinit
referencedTypeSet = true;
}
-JSONSchemaTypeDefinition::CJsonSchemaPropertiesMap::CJsonSchemaPropertiesMap()
+JSONSchemaTypeDefinition::CJsonSchemaPropertiesMap::CJsonSchemaPropertiesMap() :
+ m_propertiesmap(std::map<std::string, JSONSchemaTypeDefinitionPtr>())
{
- m_propertiesmap = std::map<std::string, JSONSchemaTypeDefinitionPtr>();
}
void JSONSchemaTypeDefinition::CJsonSchemaPropertiesMap::add(JSONSchemaTypeDefinitionPtr property)
@@ -2003,9 +2003,9 @@ void CJSONServiceDescription::getReferencedTypes(const JSONSchemaTypeDefinitionP
getReferencedTypes(type->unionTypes.at(index), referencedTypes);
}
-CJSONServiceDescription::CJsonRpcMethodMap::CJsonRpcMethodMap()
+CJSONServiceDescription::CJsonRpcMethodMap::CJsonRpcMethodMap():
+ m_actionmap(std::map<std::string, JsonRpcMethod>())
{
- m_actionmap = std::map<std::string, JsonRpcMethod>();
}
void CJSONServiceDescription::CJsonRpcMethodMap::clear()
diff --git a/xbmc/interfaces/legacy/ListItem.cpp b/xbmc/interfaces/legacy/ListItem.cpp
index aefea95daf..137c4cbaa9 100644
--- a/xbmc/interfaces/legacy/ListItem.cpp
+++ b/xbmc/interfaces/legacy/ListItem.cpp
@@ -218,7 +218,7 @@ namespace XBMCAddon
else
value = item->GetProperty(lowerKey).asString();
- return value.c_str();
+ return value;
}
void ListItem::setPath(const String& path)
diff --git a/xbmc/interfaces/legacy/Window.cpp b/xbmc/interfaces/legacy/Window.cpp
index a955364dcf..f8f8b3d37f 100644
--- a/xbmc/interfaces/legacy/Window.cpp
+++ b/xbmc/interfaces/legacy/Window.cpp
@@ -604,7 +604,7 @@ namespace XBMCAddon
XBMC_TRACE;
DelayedCallGuard dg(languageHook);
int count = 1; int size = pControls.size();
- for (std::vector<Control*>::iterator iter = pControls.begin(); iter != pControls.end(); count++, iter++)
+ for (std::vector<Control*>::iterator iter = pControls.begin(); iter != pControls.end(); count++, ++iter)
doRemoveControl(*iter,NULL, count == size);
}
@@ -782,7 +782,7 @@ namespace XBMCAddon
XBMC_TRACE;
SingleLockWithDelayGuard gslock(g_graphicsContext,languageHook);
int count = 1; int size = pControls.size();
- for (std::vector<Control*>::iterator iter = pControls.begin(); iter != pControls.end(); count++, iter++)
+ for (std::vector<Control*>::iterator iter = pControls.begin(); iter != pControls.end(); count++, ++iter)
doAddControl(*iter,NULL, count == size);
}
diff --git a/xbmc/interfaces/legacy/WindowInterceptor.h b/xbmc/interfaces/legacy/WindowInterceptor.h
index 5cdf68626c..6fefac0fcb 100644
--- a/xbmc/interfaces/legacy/WindowInterceptor.h
+++ b/xbmc/interfaces/legacy/WindowInterceptor.h
@@ -124,9 +124,9 @@ namespace XBMCAddon
public:
Interceptor(const char* specializedName,
- Window* _window, int windowid) : P(windowid, "")
- {
- ((classname = "Interceptor<") += specializedName) += ">";
+ Window* _window, int windowid) : P(windowid, ""),
+ classname("Interceptor<" + std::string(specializedName) + ">")
+ {
#ifdef ENABLE_XBMC_TRACE_API
XBMCAddonUtils::TraceGuard tg;
CLog::Log(LOGDEBUG, "%sNEWADDON constructing %s 0x%lx", tg.getSpaces(),classname.c_str(), (long)(((void*)this)));
@@ -137,9 +137,9 @@ namespace XBMCAddon
Interceptor(const char* specializedName,
Window* _window, int windowid,
- const char* xmlfile) : P(windowid, xmlfile)
- {
- ((classname = "Interceptor<") += specializedName) += ">";
+ const char* xmlfile) : P(windowid, xmlfile),
+ classname("Interceptor<" + std::string(specializedName) + ">")
+ {
#ifdef ENABLE_XBMC_TRACE_API
XBMCAddonUtils::TraceGuard tg;
CLog::Log(LOGDEBUG, "%sNEWADDON constructing %s 0x%lx", tg.getSpaces(),classname.c_str(), (long)(((void*)this)));
diff --git a/xbmc/video/VideoDatabase.cpp b/xbmc/video/VideoDatabase.cpp
index 7560ffe01e..0a7816a1be 100644
--- a/xbmc/video/VideoDatabase.cpp
+++ b/xbmc/video/VideoDatabase.cpp
@@ -574,6 +574,13 @@ bool CVideoDatabase::GetPathsForTvShow(int idShow, set<int>& paths)
{
if (NULL == m_pDB.get()) return false;
if (NULL == m_pDS.get()) return false;
+
+ // add base path
+ strSQL = PrepareSQL("SELECT strPath FROM tvshow_view WHERE idShow=%i", idShow);
+ if (m_pDS->query(strSQL.c_str()))
+ paths.insert(GetPathId(m_pDS->fv(0).get_asString()));
+
+ // add all other known paths
strSQL = PrepareSQL("SELECT DISTINCT idPath FROM files JOIN episode ON episode.idFile=files.idFile WHERE episode.idShow=%i",idShow);
m_pDS->query(strSQL.c_str());
while (!m_pDS->eof())
diff --git a/xbmc/windows/GUIMediaWindow.cpp b/xbmc/windows/GUIMediaWindow.cpp
index 3f1764e47a..6e909f2fcd 100644
--- a/xbmc/windows/GUIMediaWindow.cpp
+++ b/xbmc/windows/GUIMediaWindow.cpp
@@ -643,10 +643,6 @@ bool CGUIMediaWindow::GetDirectory(const std::string &strDirectory, CFileItemLis
{
const CURL pathToUrl(strDirectory);
- // cleanup items
- if (items.Size())
- items.Clear();
-
std::string strParentPath = m_history.GetParentPath();
CLog::Log(LOGDEBUG,"CGUIMediaWindow::GetDirectory (%s)",
@@ -665,9 +661,13 @@ bool CGUIMediaWindow::GetDirectory(const std::string &strDirectory, CFileItemLis
if (strDirectory.empty())
SetupShares();
-
- if (!m_rootDir.GetDirectory(pathToUrl, items))
+
+ CFileItemList dirItems;
+ if (!m_rootDir.GetDirectory(pathToUrl, dirItems))
return false;
+
+ // assign fetched directory items
+ items.Assign(dirItems);
// took over a second, and not normally cached, so cache it
if ((XbmcThreads::SystemClockMillis() - time) > 1000 && items.CacheToDiscIfSlow())