diff options
author | Dave Blake <oak99sky@yahoo.co.uk> | 2019-12-05 14:29:11 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-12-05 14:29:11 +0000 |
commit | 0b09b4820bea1ef8faa2afc7bee430921a81a0e3 (patch) | |
tree | 2d81a39ede455739a6391d790ea2b2b747e490f5 /docs | |
parent | 8de835893fe61be9341c7888ae5c468b6d7b960f (diff) | |
parent | 5b8d7bdc5e2142bf77fbca098f4db77ee9076c14 (diff) |
Merge pull request #16924 from DaveTBlake/docsKeepFormat
[docs]Update code guidelines for readability of setting table-like structures
Diffstat (limited to 'docs')
-rw-r--r-- | docs/CODE_GUIDELINES.md | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/docs/CODE_GUIDELINES.md b/docs/CODE_GUIDELINES.md index 479e2f25a0..7298d75ccc 100644 --- a/docs/CODE_GUIDELINES.md +++ b/docs/CODE_GUIDELINES.md @@ -244,6 +244,26 @@ void Test(); void Test(void); ``` +### 3.7. Exceptions to the Formating Rules For Beter Readability +There are some special situations where vertical alignment and longer lines does greatly aid readability, for example the initialization of some table-like multiple row structures. In these **rare** cases exceptions can be made to the formatting rules on vertical alignment, and the defined line length can be exceeded. + +The layout can be protected from being reformatted when `clang-format` is applied by adding `// clang-format off` and `// clang-format on` statements either side of the lines of code. +For example +``` +// clang-format off +static const CGUIDialogMediaFilter::Filter filterList[] = { + { "movies", FieldTitle, 556, SettingType::String, "edit", "string", CDatabaseQueryRule::OPERATOR_CONTAINS }, + { "movies", FieldRating, 563, SettingType::Number, "range", "number", CDatabaseQueryRule::OPERATOR_BETWEEN }, + { "movies", FieldUserRating, 38018, SettingType::Integer, "range", "integer", CDatabaseQueryRule::OPERATOR_BETWEEN }, + ... + { "songs", FieldSource, 39030, SettingType::List, "list", "string", CDatabaseQueryRule::OPERATOR_EQUALS }, +}; +// clang-format on + ``` +The other code guidelines will still need to be applied within the delimited lines of code, but with `clang-format` off care will be needed to check these manually. Using vertical alignment means that sometimes the entire block of code may need to be realigned, good judgement should be used in each case with the objective of preserving readability yet minimising impact. + +This is to be used with discretion, marking large amounts of code to be left unformatted by `clang-format` without reasonable justification will be rejected. + **[back to top](#table-of-contents)** ## 4. Statements |