aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorh.udo <hudokkow@gmail.com>2018-03-14 23:00:00 +0100
committerh.udo <hudokkow@gmail.com>2018-03-14 23:00:00 +0100
commitc25cbbaeee3a8ab04d0cd12ec5b88f4849e074e6 (patch)
treed8cab3846ef81bc47cd9d19f2b7304cb0a7bc6bc
parent46058c5dc3551831147ec5a4823ccd70767b12e9 (diff)
[swig] Revert PR #12490 now Trusty is no longer supported/able to build
-rw-r--r--xbmc/interfaces/legacy/Addon.h3
-rw-r--r--xbmc/interfaces/legacy/Control.h12
-rw-r--r--xbmc/interfaces/legacy/Dialog.h21
-rw-r--r--xbmc/interfaces/legacy/File.h3
-rw-r--r--xbmc/interfaces/legacy/InfoTagMusic.h3
-rw-r--r--xbmc/interfaces/legacy/InfoTagRadioRDS.h3
-rw-r--r--xbmc/interfaces/legacy/InfoTagVideo.h3
-rw-r--r--xbmc/interfaces/legacy/Keyboard.h3
-rw-r--r--xbmc/interfaces/legacy/ListItem.h3
-rw-r--r--xbmc/interfaces/legacy/Monitor.h3
-rw-r--r--xbmc/interfaces/legacy/PlayList.h3
-rw-r--r--xbmc/interfaces/legacy/Player.h3
-rw-r--r--xbmc/interfaces/legacy/RenderCapture.h3
-rw-r--r--xbmc/interfaces/legacy/Window.h3
-rw-r--r--xbmc/interfaces/legacy/WindowDialog.h3
-rw-r--r--xbmc/interfaces/legacy/WindowXML.h6
-rw-r--r--xbmc/interfaces/legacy/wsgi/WsgiErrorStream.h3
-rw-r--r--xbmc/interfaces/legacy/wsgi/WsgiInputStream.h6
-rw-r--r--xbmc/interfaces/legacy/wsgi/WsgiResponse.h3
-rw-r--r--xbmc/interfaces/legacy/wsgi/WsgiResponseBody.h3
20 files changed, 31 insertions, 62 deletions
diff --git a/xbmc/interfaces/legacy/Addon.h b/xbmc/interfaces/legacy/Addon.h
index 8a933c323c..7e32630e3f 100644
--- a/xbmc/interfaces/legacy/Addon.h
+++ b/xbmc/interfaces/legacy/Addon.h
@@ -80,8 +80,7 @@ namespace XBMCAddon
public:
explicit Addon(const char* id = NULL);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~Addon();
+ ~Addon() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/Control.h b/xbmc/interfaces/legacy/Control.h
index ddb4f636c2..ad3e3dd2c1 100644
--- a/xbmc/interfaces/legacy/Control.h
+++ b/xbmc/interfaces/legacy/Control.h
@@ -78,8 +78,7 @@ namespace XBMCAddon
iControlRight(0), pGUIControl(NULL) {}
public:
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~Control();
+ ~Control() override;
#ifndef SWIG
virtual CGUIControl* Create();
@@ -674,8 +673,7 @@ namespace XBMCAddon
class ControlSpin : public Control
{
public:
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~ControlSpin();
+ ~ControlSpin() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
/// \ingroup python_xbmcgui_control_spin
@@ -799,8 +797,7 @@ namespace XBMCAddon
long alignment = XBFONT_LEFT,
bool hasPath = false, long angle = 0);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~ControlLabel();
+ ~ControlLabel() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
/// \ingroup python_xbmcgui_control_label
@@ -1160,8 +1157,7 @@ namespace XBMCAddon
long _itemTextYOffset = CONTROL_TEXT_OFFSET_Y, long _itemHeight = 27, long _space = 2,
long _alignmentY = XBFONT_CENTER_Y);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~ControlList();
+ ~ControlList() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
/// \ingroup python_xbmcgui_control_list
diff --git a/xbmc/interfaces/legacy/Dialog.h b/xbmc/interfaces/legacy/Dialog.h
index a501f1e9ad..10f71ae1a1 100644
--- a/xbmc/interfaces/legacy/Dialog.h
+++ b/xbmc/interfaces/legacy/Dialog.h
@@ -60,8 +60,7 @@ namespace XBMCAddon
public:
inline Dialog() = default;
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~Dialog();
+ ~Dialog() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
@@ -603,14 +602,12 @@ namespace XBMCAddon
bool open;
protected:
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual void deallocating();
+ void deallocating() override;
public:
DialogProgress() : dlg(NULL), open(false) {}
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~DialogProgress();
+ ~DialogProgress() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
@@ -744,14 +741,12 @@ namespace XBMCAddon
bool open;
protected:
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual void deallocating();
+ void deallocating() override;
public:
DialogBusy() : dlg(NULL), open(false) {}
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~DialogBusy();
+ ~DialogBusy() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
@@ -854,14 +849,12 @@ namespace XBMCAddon
bool open;
protected:
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual void deallocating();
+ void deallocating() override;
public:
DialogProgressBG() : dlg(NULL), handle(NULL), open(false) {}
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~DialogProgressBG();
+ ~DialogProgressBG() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/File.h b/xbmc/interfaces/legacy/File.h
index a340d4c269..57f1b94e49 100644
--- a/xbmc/interfaces/legacy/File.h
+++ b/xbmc/interfaces/legacy/File.h
@@ -71,8 +71,7 @@ namespace XBMCAddon
file->Open(filepath, XFILE::READ_NO_CACHE);
}
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- inline virtual ~File() { delete file; }
+ inline ~File() override { delete file; }
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/InfoTagMusic.h b/xbmc/interfaces/legacy/InfoTagMusic.h
index 41da3d5ffc..587f654a83 100644
--- a/xbmc/interfaces/legacy/InfoTagMusic.h
+++ b/xbmc/interfaces/legacy/InfoTagMusic.h
@@ -62,8 +62,7 @@ namespace XBMCAddon
explicit InfoTagMusic(const MUSIC_INFO::CMusicInfoTag& tag);
#endif
InfoTagMusic();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~InfoTagMusic();
+ ~InfoTagMusic() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/InfoTagRadioRDS.h b/xbmc/interfaces/legacy/InfoTagRadioRDS.h
index cb69ba3300..e3f43635c3 100644
--- a/xbmc/interfaces/legacy/InfoTagRadioRDS.h
+++ b/xbmc/interfaces/legacy/InfoTagRadioRDS.h
@@ -64,8 +64,7 @@ namespace XBMCAddon
explicit InfoTagRadioRDS(const PVR::CPVRRadioRDSInfoTagPtr tag);
#endif
InfoTagRadioRDS();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~InfoTagRadioRDS();
+ ~InfoTagRadioRDS() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/InfoTagVideo.h b/xbmc/interfaces/legacy/InfoTagVideo.h
index f09194738b..ab7ec30f8e 100644
--- a/xbmc/interfaces/legacy/InfoTagVideo.h
+++ b/xbmc/interfaces/legacy/InfoTagVideo.h
@@ -63,8 +63,7 @@ namespace XBMCAddon
explicit InfoTagVideo(const CVideoInfoTag& tag);
#endif
InfoTagVideo();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~InfoTagVideo();
+ ~InfoTagVideo() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/Keyboard.h b/xbmc/interfaces/legacy/Keyboard.h
index bb23b852d5..4662b486ad 100644
--- a/xbmc/interfaces/legacy/Keyboard.h
+++ b/xbmc/interfaces/legacy/Keyboard.h
@@ -75,8 +75,7 @@ namespace XBMCAddon
#endif
Keyboard(const String& line = emptyString, const String& heading = emptyString, bool hidden = false);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~Keyboard();
+ ~Keyboard() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/ListItem.h b/xbmc/interfaces/legacy/ListItem.h
index e5acb9d84e..5c325bbcaa 100644
--- a/xbmc/interfaces/legacy/ListItem.h
+++ b/xbmc/interfaces/legacy/ListItem.h
@@ -106,8 +106,7 @@ namespace XBMCAddon
}
#endif
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~ListItem();
+ ~ListItem() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/Monitor.h b/xbmc/interfaces/legacy/Monitor.h
index 1eff88e1f9..6e665818b2 100644
--- a/xbmc/interfaces/legacy/Monitor.h
+++ b/xbmc/interfaces/legacy/Monitor.h
@@ -317,8 +317,7 @@ namespace XBMCAddon
#else
bool abortRequested();
#endif
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~Monitor();
+ ~Monitor() override;
};
/** @} */
}
diff --git a/xbmc/interfaces/legacy/PlayList.h b/xbmc/interfaces/legacy/PlayList.h
index caf2790ef2..da8edef7c9 100644
--- a/xbmc/interfaces/legacy/PlayList.h
+++ b/xbmc/interfaces/legacy/PlayList.h
@@ -66,8 +66,7 @@ namespace XBMCAddon
public:
explicit PlayList(int playList);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~PlayList();
+ ~PlayList() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/Player.h b/xbmc/interfaces/legacy/Player.h
index 66ccedc512..e2b93cfdbe 100644
--- a/xbmc/interfaces/legacy/Player.h
+++ b/xbmc/interfaces/legacy/Player.h
@@ -90,8 +90,7 @@ namespace XBMCAddon
// construction of a Player needs to identify whether or not any
// callbacks will be executed asynchronously or not.
explicit Player(int playerCore = 0);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~Player(void);
+ ~Player(void) override;
#endif
#ifdef DOXYGEN_SHOULD_USE_THIS
diff --git a/xbmc/interfaces/legacy/RenderCapture.h b/xbmc/interfaces/legacy/RenderCapture.h
index 1bc105614a..87ab3b1404 100644
--- a/xbmc/interfaces/legacy/RenderCapture.h
+++ b/xbmc/interfaces/legacy/RenderCapture.h
@@ -59,8 +59,7 @@ namespace XBMCAddon
m_width = 0;
m_height = 0;
}
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- inline virtual ~RenderCapture()
+ inline ~RenderCapture() override
{
g_application.GetAppPlayer().RenderCaptureRelease(m_captureId);
delete [] m_buffer;
diff --git a/xbmc/interfaces/legacy/Window.h b/xbmc/interfaces/legacy/Window.h
index 6e16d13bd5..9d6008db6e 100644
--- a/xbmc/interfaces/legacy/Window.h
+++ b/xbmc/interfaces/legacy/Window.h
@@ -267,8 +267,7 @@ namespace XBMCAddon
public:
explicit Window(int existingWindowId = -1);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~Window();
+ ~Window() override;
#ifndef SWIG
SWIGHIDDENVIRTUAL bool OnMessage(CGUIMessage& message);
diff --git a/xbmc/interfaces/legacy/WindowDialog.h b/xbmc/interfaces/legacy/WindowDialog.h
index fb1b644e25..0aa8a6ba5b 100644
--- a/xbmc/interfaces/legacy/WindowDialog.h
+++ b/xbmc/interfaces/legacy/WindowDialog.h
@@ -64,8 +64,7 @@ namespace XBMCAddon
{
public:
WindowDialog();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WindowDialog();
+ ~WindowDialog() override;
#ifndef SWIG
SWIGHIDDENVIRTUAL bool OnMessage(CGUIMessage& message) override;
diff --git a/xbmc/interfaces/legacy/WindowXML.h b/xbmc/interfaces/legacy/WindowXML.h
index 2254023ce6..c6607700e6 100644
--- a/xbmc/interfaces/legacy/WindowXML.h
+++ b/xbmc/interfaces/legacy/WindowXML.h
@@ -119,8 +119,7 @@ namespace XBMCAddon
const String& defaultSkin = "Default",
const String& defaultRes = "720p",
bool isMedia = false);
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WindowXML();
+ ~WindowXML() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
@@ -539,8 +538,7 @@ namespace XBMCAddon
const String& defaultSkin = "Default",
const String& defaultRes = "720p");
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WindowXMLDialog();
+ ~WindowXMLDialog() override;
#ifndef SWIG
SWIGHIDDENVIRTUAL bool OnMessage(CGUIMessage &message) override;
diff --git a/xbmc/interfaces/legacy/wsgi/WsgiErrorStream.h b/xbmc/interfaces/legacy/wsgi/WsgiErrorStream.h
index f34932a7a6..94c9004a04 100644
--- a/xbmc/interfaces/legacy/wsgi/WsgiErrorStream.h
+++ b/xbmc/interfaces/legacy/wsgi/WsgiErrorStream.h
@@ -45,8 +45,7 @@ namespace XBMCAddon
{
public:
WsgiErrorStream();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WsgiErrorStream();
+ ~WsgiErrorStream() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
///
diff --git a/xbmc/interfaces/legacy/wsgi/WsgiInputStream.h b/xbmc/interfaces/legacy/wsgi/WsgiInputStream.h
index 26b61d63e3..af4febbb10 100644
--- a/xbmc/interfaces/legacy/wsgi/WsgiInputStream.h
+++ b/xbmc/interfaces/legacy/wsgi/WsgiInputStream.h
@@ -34,8 +34,7 @@ namespace XBMCAddon
{
public:
WsgiInputStreamIterator();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WsgiInputStreamIterator();
+ ~WsgiInputStreamIterator() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
/// \ingroup python_xbmcwsgi_WsgiInputStream
@@ -116,8 +115,7 @@ namespace XBMCAddon
{
public:
WsgiInputStream();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WsgiInputStream();
+ ~WsgiInputStream() override;
#if !defined SWIG && !defined DOXYGEN_SHOULD_SKIP_THIS
WsgiInputStreamIterator* begin();
diff --git a/xbmc/interfaces/legacy/wsgi/WsgiResponse.h b/xbmc/interfaces/legacy/wsgi/WsgiResponse.h
index 7673e5cec5..24dbbaffe6 100644
--- a/xbmc/interfaces/legacy/wsgi/WsgiResponse.h
+++ b/xbmc/interfaces/legacy/wsgi/WsgiResponse.h
@@ -45,8 +45,7 @@ namespace XBMCAddon
{
public:
WsgiResponse();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WsgiResponse();
+ ~WsgiResponse() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
/// \ingroup python_xbmcwsgi_WsgiInputStreamIterator
diff --git a/xbmc/interfaces/legacy/wsgi/WsgiResponseBody.h b/xbmc/interfaces/legacy/wsgi/WsgiResponseBody.h
index 1915a412a7..b9d2e0f3e8 100644
--- a/xbmc/interfaces/legacy/wsgi/WsgiResponseBody.h
+++ b/xbmc/interfaces/legacy/wsgi/WsgiResponseBody.h
@@ -38,8 +38,7 @@ namespace XBMCAddon
{
public:
WsgiResponseBody();
- //! @todo Switch to 'override' usage once 14.04 (Trusty) hits EOL. swig <3.0 doesn't understand C++11
- virtual ~WsgiResponseBody();
+ ~WsgiResponseBody() override;
#ifdef DOXYGEN_SHOULD_USE_THIS
/// \ingroup python_xbmcwsgi_WsgiInputStreamIterator