diff options
| author | fuzzard <fuzzard@kodi.tv> | 2024-08-16 15:19:42 +1000 |
|---|---|---|
| committer | fuzzard <fuzzard@kodi.tv> | 2024-08-17 13:01:55 +1000 |
| commit | 980b1896e9a45ac37a4674418a0885f0dcb6cfd6 (patch) | |
| tree | 7a25820fa0111320b518d3cbb2a7136a58afe0a9 | |
| parent | 5862da7009e7053462c8ac4d10e012baa3bd038e (diff) | |
[cmake][addons] Dont quote variable passed to externalproject_add
Alwin partially fixed this in https://github.com/xbmc/xbmc/commit/2c1ef3dce244e4918b07f452d1c28a3b3b6d71a3
Reason he probably didnt see this was most of our addons use a sha256 file.
game.libretro.mrboom and game.libretro.2048 do not, and therefore fail to build with errors
such as:
CMake Error at /usr/share/cmake-3.30/Modules/ExternalProject/shared_internal_commands.cmake:1127 (message):
At least one entry of URL is a path (invalid in a list)
Call Stack (most recent call first):
/usr/share/cmake-3.30/Modules/ExternalProject.cmake:3035 (_ep_add_download_command)
/home/xxx/repos/xbmc/cmake/scripts/common/HandleDepends.cmake:272 (externalproject_add)
CMakeLists.txt:455 (add_addon_depends)
-- Configuring incomplete, errors occurred!
| -rw-r--r-- | cmake/scripts/common/HandleDepends.cmake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmake/scripts/common/HandleDepends.cmake b/cmake/scripts/common/HandleDepends.cmake index dc022bab64..de994b80e2 100644 --- a/cmake/scripts/common/HandleDepends.cmake +++ b/cmake/scripts/common/HandleDepends.cmake @@ -271,7 +271,7 @@ function(add_addon_depends addon searchpath) externalproject_add(${id} URL ${url} - "${URL_HASH_COMMAND}" + ${URL_HASH_COMMAND} DOWNLOAD_DIR ${DOWNLOAD_DIR} CONFIGURE_COMMAND ${CONFIGURE_COMMAND} ${EXTERNALPROJECT_SETUP}) |