diff options
| author | Rechi <Rechi@users.noreply.github.com> | 2018-09-22 10:59:59 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-09-22 10:59:59 +0200 |
| commit | 94f8b83777f26f0c85c74cbce7365e6ef8c3127d (patch) | |
| tree | 96fc3efd75cde37532c4767fbdc5400f94e74c7e | |
| parent | e00dd28982a143425d840aa826636c6fe30ad40e (diff) | |
| parent | 474cfbc55583770483fdb0339ceb81255ae14cb8 (diff) | |
Merge pull request #14456 from Rechi/fix/loop-convert
[fix] iterate over reference and only copy the variable if needed
| -rw-r--r-- | xbmc/dialogs/GUIDialogMediaFilter.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xbmc/dialogs/GUIDialogMediaFilter.cpp b/xbmc/dialogs/GUIDialogMediaFilter.cpp index f83584cbf3..7ea35275b0 100644 --- a/xbmc/dialogs/GUIDialogMediaFilter.cpp +++ b/xbmc/dialogs/GUIDialogMediaFilter.cpp @@ -391,11 +391,13 @@ void CGUIDialogMediaFilter::InitializeSettings() return; } - for (Filter filter : filterList) + for (const Filter& f : filterList) { - if (filter.mediaType != m_mediaType) + if (f.mediaType != m_mediaType) continue; + Filter filter = f; + // check the smartplaylist if it contains a matching rule for (CDatabaseQueryRules::iterator rule = m_filter->m_ruleCombination.m_rules.begin(); rule != m_filter->m_ruleCombination.m_rules.end(); rule++) { |