aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartijn Kaijser <mcm.kaijser@gmail.com>2015-06-04 20:05:29 +0200
committerMartijn Kaijser <mcm.kaijser@gmail.com>2015-06-04 20:08:35 +0200
commit317a17ff414534b9810341fc205daecd0a57b5d7 (patch)
tree6bee6bd62c04cd49a11ca97105b568d09afadede
parent81a115bba2f55dd0ca8a89a8a6c9ce6d67760362 (diff)
combine split strings into a single string and only use the textbox in dialogs
-rw-r--r--addons/resource.language.en_gb/resources/strings.po52
-rw-r--r--xbmc/GUIPassword.cpp2
-rw-r--r--xbmc/PlayListPlayer.cpp2
-rw-r--r--xbmc/dialogs/GUIDialogFileBrowser.cpp2
-rw-r--r--xbmc/dialogs/GUIDialogMediaSource.cpp2
-rw-r--r--xbmc/network/NetworkServices.cpp2
-rw-r--r--xbmc/pvr/PVRManager.cpp4
-rw-r--r--xbmc/pvr/addons/PVRClients.cpp2
-rw-r--r--xbmc/pvr/channels/PVRChannelGroupInternal.cpp2
-rw-r--r--xbmc/pvr/recordings/PVRRecording.cpp6
-rw-r--r--xbmc/pvr/timers/PVRTimerInfoTag.cpp8
-rw-r--r--xbmc/video/dialogs/GUIDialogAudioSubtitleSettings.cpp2
-rw-r--r--xbmc/video/dialogs/GUIDialogVideoSettings.cpp2
-rw-r--r--xbmc/video/windows/GUIWindowVideoBase.cpp8
-rw-r--r--xbmc/video/windows/GUIWindowVideoBase.h2
-rw-r--r--xbmc/video/windows/GUIWindowVideoNav.cpp2
16 files changed, 50 insertions, 50 deletions
diff --git a/addons/resource.language.en_gb/resources/strings.po b/addons/resource.language.en_gb/resources/strings.po
index 1e77e7222a..ea97270a52 100644
--- a/addons/resource.language.en_gb/resources/strings.po
+++ b/addons/resource.language.en_gb/resources/strings.po
@@ -3146,7 +3146,6 @@ msgid "Mirror image"
msgstr ""
#: xbmc/dialogs/GUIDialogContextMenu.cpp
-#: xbmc/video/dialogs/GUIDialogVideoSettings.cpp
msgctxt "#750"
msgid "Are you sure?"
msgstr ""
@@ -3407,21 +3406,12 @@ msgctxt "#1001"
msgid "Unable to connect"
msgstr ""
-msgctxt "#1002"
-msgid "The connection to the network location couldn't be established."
-msgstr ""
-
#: xbmc/dialogs/GUIDialogMediaSource.cpp
-msgctxt "#1003"
-msgid "This could be due to the network not being connected."
-msgstr ""
-
-#: xbmc/dialogs/GUIDialogMediaSource.cpp
-msgctxt "#1004"
-msgid "Would you like to add it anyway?"
+msgctxt "#1002"
+msgid "The connection to the network location couldn't be established. This could be due to the network not being connected. Would you like to add it anyway"
msgstr ""
-#empty string with id 1005
+#empty string from id 1003 to 1005
msgctxt "#1006"
msgid "IP address"
@@ -3514,7 +3504,7 @@ msgstr ""
#: xbmc/dialogs/GUIDialogMediaSource.cpp
msgctxt "#1025"
-msgid "Couldn't retrieve directory information."
+msgid "Couldn't retrieve directory information. This could be due to the network not being connected. Would you like to add it anyway?"
msgstr ""
#: xbmc/dialogs/GUIDialogContextMenu.cpp
@@ -5001,15 +4991,10 @@ msgstr ""
#: xbmc\GUIPassword.cpp
msgctxt "#12367"
-msgid "Master code is not valid"
-msgstr ""
-
-#: xbmc\GUIPassword.cpp
-msgctxt "#12368"
-msgid "Please enter a valid master code"
+msgid "Master code is not valid. Please enter a valid master code."
msgstr ""
-#empty strings from id 12369 to 12372
+#empty strings from id 12368 to 12372
#: unknown
msgctxt "#12373"
@@ -5027,7 +5012,7 @@ msgstr ""
#: xbmc\video\dialogs\GUIDialogAudioSubtitleSettings.cpp
#: xbmc\video\dialogs\GUIDialogVideoSettings.cpp
msgctxt "#12377"
-msgid "This will reset any previously saved values"
+msgid "This will reset any previously saved values. Are you sure?"
msgstr ""
#: system/settings/settings.xml
@@ -7281,8 +7266,9 @@ msgctxt "#16026"
msgid "Playback failed"
msgstr ""
+#: xbmc/PlaylistPlayer.cpp
msgctxt "#16027"
-msgid "One or more items failed to play."
+msgid "One or more items failed to play. Check the log for more information about this message."
msgstr ""
msgctxt "#16028"
@@ -7981,10 +7967,12 @@ msgid "Channel icons"
msgstr ""
#: xbmc/pvr/dialogs/GUIDialogPVRGuideInfo.cpp
+#: xbmc/pvr/timers/PVRTimerInfoTag.cpp
msgctxt "#19067"
msgid "This event is already being recorded."
msgstr ""
+#: xbmc/pvr/recording/PVRRecording.cpp
msgctxt "#19068"
msgid "This recording couldn't be deleted.[CR]Check the log for more information about this message."
msgstr ""
@@ -8125,6 +8113,7 @@ msgctxt "#19101"
msgid "Provider"
msgstr ""
+#: xbmc/pvr/channels/PVRChannelGroupInternal.cpp
msgctxt "#19102"
msgid "Please switch to another channel."
msgstr ""
@@ -8156,16 +8145,20 @@ msgctxt "#19108"
msgid "Fallback framerate"
msgstr ""
+#: xbmc/pvr/timers/PVRTimerInfoTag.cpp
#: xbmc/pvr/timers/PVRTimers.cpp
msgctxt "#19109"
msgid "Couldn't save timer.[CR]Check the log for more information about this message."
msgstr ""
+#: xbmc/pvr/timers/PVRTimerInfoTag.cpp
msgctxt "#19110"
msgid "An unexpected error occurred.[CR]Try again later or check the log for more information."
msgstr ""
#: xbmc/pvr/addons/PVRClients.cpp
+#: xbmc/pvr/recording/PVRRecording.cpp
+#: xbmc/pvr/timers/PVRTimerInfoTag.cpp
msgctxt "#19111"
msgid "PVR backend error.[CR]Check the log for more information about this message."
msgstr ""
@@ -8315,6 +8308,7 @@ msgctxt "#19146"
msgid "Groups"
msgstr ""
+#: xbmc/pvr/recording/PVRRecording.cpp
msgctxt "#19147"
msgid "The PVR backend does not support this action.[CR]Check the log for more information about this message."
msgstr ""
@@ -8494,7 +8488,7 @@ msgid "Reset PVR database"
msgstr ""
msgctxt "#19186"
-msgid "All data in the PVR database is being erased"
+msgid "All data in the PVR database is being erased. Are you sure?"
msgstr ""
#: system/settings/settings.xml
@@ -8503,7 +8497,7 @@ msgid "Reset guide database"
msgstr ""
msgctxt "#19188"
-msgid "Guide is being reset"
+msgid "Guide is being reset. Are you sure?"
msgstr ""
#: system/settings/settings.xml
@@ -10582,6 +10576,8 @@ msgctxt "#20339"
msgid "Director"
msgstr ""
+#: xbmc/video/windows/GUIWindowVideoBase.cpp
+#: xbmc/video/windows/GUIWindowVideoNav.cpp
#: xbmc/music/windows/GUIWindowMusicSongs.cpp
msgctxt "#20340"
msgid "Do you want to remove all items within this path from your library?"
@@ -10746,6 +10742,8 @@ msgctxt "#20374"
msgid "Downloading movie information"
msgstr ""
+#: xbmc/video/windows/GUIWindowVideoBase.cpp
+#: xbmc/video/windows/GUIWindowVideoNav.cpp
msgctxt "#20375"
msgid "Unassign content"
msgstr ""
@@ -11049,10 +11047,12 @@ msgctxt "#20441"
msgid "Remote fanart"
msgstr ""
+#: xbmc/video/windows/GUIWindowVideoBase.cpp
msgctxt "#20442"
msgid "Change content"
msgstr ""
+#: xbmc/video/windows/GUIWindowVideoBase.cpp
msgctxt "#20443"
msgid "Do you want to refresh information for all items within this path?"
msgstr ""
@@ -13715,7 +13715,7 @@ msgstr ""
#: xbmc/network/NetworkServices.cpp
msgctxt "#34302"
-msgid "AirPlay requires Zeroconf to be enabled."
+msgid "Failed to start AirPlay as it requires Zeroconf to be enabled."
msgstr ""
#: xbmc/network/NetworkServices.cpp
diff --git a/xbmc/GUIPassword.cpp b/xbmc/GUIPassword.cpp
index 4bb3baabe3..1fca5d647f 100644
--- a/xbmc/GUIPassword.cpp
+++ b/xbmc/GUIPassword.cpp
@@ -143,7 +143,7 @@ bool CGUIPassword::CheckStartUpLock()
std::string strLabel = StringUtils::Format("%i %s", iLeft, strLabel1.c_str());
// PopUp OK and Display: MasterLock mode has changed but no new Mastercode has been set!
- CGUIDialogOK::ShowAndGetInput(12360, 12367, 12368, strLabel);
+ CGUIDialogOK::ShowAndGetInput(12360, 12368, strLabel, "");
}
else
i=g_passwordManager.iMasterLockRetriesLeft;
diff --git a/xbmc/PlayListPlayer.cpp b/xbmc/PlayListPlayer.cpp
index eef8971163..27bbd6adaf 100644
--- a/xbmc/PlayListPlayer.cpp
+++ b/xbmc/PlayListPlayer.cpp
@@ -299,7 +299,7 @@ bool CPlayListPlayer::Play(int iSong, bool bAutoPlay /* = false */, bool bPlayPr
CLog::Log(LOGDEBUG,"Playlist Player: one or more items failed to play... aborting playback");
// open error dialog
- CGUIDialogOK::ShowAndGetInput(16026, 16027, 16029, 0);
+ CGUIDialogOK::ShowAndGetInput(16026, 16027);
CGUIMessage msg(GUI_MSG_PLAYLISTPLAYER_STOPPED, 0, 0, m_iCurrentPlayList, m_iCurrentSong);
g_windowManager.SendThreadMessage(msg);
diff --git a/xbmc/dialogs/GUIDialogFileBrowser.cpp b/xbmc/dialogs/GUIDialogFileBrowser.cpp
index b1b6744991..9a9d576c1a 100644
--- a/xbmc/dialogs/GUIDialogFileBrowser.cpp
+++ b/xbmc/dialogs/GUIDialogFileBrowser.cpp
@@ -895,7 +895,7 @@ void CGUIDialogFileBrowser::OnAddNetworkLocation()
{
// verify the path by doing a GetDirectory.
CFileItemList items;
- if (CDirectory::GetDirectory(path, items, "", DIR_FLAG_NO_FILE_DIRS | DIR_FLAG_ALLOW_PROMPT) || CGUIDialogYesNo::ShowAndGetInput(1001,1002,1003,1004))
+ if (CDirectory::GetDirectory(path, items, "", DIR_FLAG_NO_FILE_DIRS | DIR_FLAG_ALLOW_PROMPT) || CGUIDialogYesNo::ShowAndGetInput(1001, 1002))
{ // add the network location to the shares list
CMediaSource share;
share.strPath = path; //setPath(path);
diff --git a/xbmc/dialogs/GUIDialogMediaSource.cpp b/xbmc/dialogs/GUIDialogMediaSource.cpp
index 0881f62113..45237cc3c7 100644
--- a/xbmc/dialogs/GUIDialogMediaSource.cpp
+++ b/xbmc/dialogs/GUIDialogMediaSource.cpp
@@ -388,7 +388,7 @@ void CGUIDialogMediaSource::OnOK()
VECSOURCES *shares = CMediaSourceSettings::Get().GetSources(m_type);
if (shares)
shares->push_back(share);
- if (StringUtils::StartsWithNoCase(share.strPath, "plugin://") || CDirectory::GetDirectory(share.strPath, items, "", DIR_FLAG_NO_FILE_DIRS | DIR_FLAG_ALLOW_PROMPT) || CGUIDialogYesNo::ShowAndGetInput(1001,1025,1003,1004))
+ if (StringUtils::StartsWithNoCase(share.strPath, "plugin://") || CDirectory::GetDirectory(share.strPath, items, "", DIR_FLAG_NO_FILE_DIRS | DIR_FLAG_ALLOW_PROMPT) || CGUIDialogYesNo::ShowAndGetInput(1001, 1025))
{
m_confirmed = true;
Close();
diff --git a/xbmc/network/NetworkServices.cpp b/xbmc/network/NetworkServices.cpp
index eaeb1230c5..b749e828f1 100644
--- a/xbmc/network/NetworkServices.cpp
+++ b/xbmc/network/NetworkServices.cpp
@@ -223,7 +223,7 @@ bool CNetworkServices::OnSettingChanging(const CSetting *setting)
// AirPlay needs zeroconf
if (!CSettings::Get().GetBool("services.zeroconf"))
{
- CGUIDialogOK::ShowAndGetInput(g_localizeStrings.Get(1273), g_localizeStrings.Get(33100), g_localizeStrings.Get(34302), "");
+ CGUIDialogOK::ShowAndGetInput(1273, 34302);
return false;
}
#endif //HAS_ZEROCONF
diff --git a/xbmc/pvr/PVRManager.cpp b/xbmc/pvr/PVRManager.cpp
index 1340c97310..e1ee5c2ded 100644
--- a/xbmc/pvr/PVRManager.cpp
+++ b/xbmc/pvr/PVRManager.cpp
@@ -183,7 +183,7 @@ void CPVRManager::OnSettingAction(const CSetting *setting)
else if (settingId == "pvrmanager.resetdb")
{
if (CheckParentalPIN(g_localizeStrings.Get(19262)) &&
- CGUIDialogYesNo::ShowAndGetInput(19098, 19186, 750, 0))
+ CGUIDialogYesNo::ShowAndGetInput(19098, 19186))
{
CDateTime::ResetTimezoneBias();
ResetDatabase(false);
@@ -191,7 +191,7 @@ void CPVRManager::OnSettingAction(const CSetting *setting)
}
else if (settingId == "epg.resetepg")
{
- if (CGUIDialogYesNo::ShowAndGetInput(19098, 19188, 750, 0))
+ if (CGUIDialogYesNo::ShowAndGetInput(19098, 19188))
{
CDateTime::ResetTimezoneBias();
ResetDatabase(true);
diff --git a/xbmc/pvr/addons/PVRClients.cpp b/xbmc/pvr/addons/PVRClients.cpp
index 1bdc79b562..cdc986b574 100644
--- a/xbmc/pvr/addons/PVRClients.cpp
+++ b/xbmc/pvr/addons/PVRClients.cpp
@@ -1137,7 +1137,7 @@ bool CPVRClients::UpdateAndInitialiseClients(bool bInitialiseAllClients /* = fal
}
if (bDisabled && (g_PVRManager.IsStarted() || g_PVRManager.IsInitialising()))
- CGUIDialogOK::ShowAndGetInput(24070, 24071, 16029, 0);
+ CGUIDialogOK::ShowAndGetInput(24070, 16029);
}
}
diff --git a/xbmc/pvr/channels/PVRChannelGroupInternal.cpp b/xbmc/pvr/channels/PVRChannelGroupInternal.cpp
index 7e3f55f896..0f960da73c 100644
--- a/xbmc/pvr/channels/PVRChannelGroupInternal.cpp
+++ b/xbmc/pvr/channels/PVRChannelGroupInternal.cpp
@@ -168,7 +168,7 @@ bool CPVRChannelGroupInternal::RemoveFromGroup(const CPVRChannelPtr &channel)
CPVRChannelPtr currentChannel(g_PVRManager.GetCurrentChannel());
if (currentChannel && currentChannel == channel)
{
- CGUIDialogOK::ShowAndGetInput(19098,19101,0,19102);
+ CGUIDialogOK::ShowAndGetInput(19098, 19102);
return false;
}
diff --git a/xbmc/pvr/recordings/PVRRecording.cpp b/xbmc/pvr/recordings/PVRRecording.cpp
index d64743278d..8193a79caa 100644
--- a/xbmc/pvr/recordings/PVRRecording.cpp
+++ b/xbmc/pvr/recordings/PVRRecording.cpp
@@ -315,11 +315,11 @@ std::vector<PVR_EDL_ENTRY> CPVRRecording::GetEdl() const
void CPVRRecording::DisplayError(PVR_ERROR err) const
{
if (err == PVR_ERROR_SERVER_ERROR)
- CGUIDialogOK::ShowAndGetInput(19033,19111,19110,0); /* print info dialog "Server error!" */
+ CGUIDialogOK::ShowAndGetInput(19033, 19111); /* print info dialog "Server error!" */
else if (err == PVR_ERROR_REJECTED)
- CGUIDialogOK::ShowAndGetInput(19033,19068,19110,0); /* print info dialog "Couldn't delete recording!" */
+ CGUIDialogOK::ShowAndGetInput(19033, 19068); /* print info dialog "Couldn't delete recording!" */
else
- CGUIDialogOK::ShowAndGetInput(19033,19147,19110,0); /* print info dialog "Unknown error!" */
+ CGUIDialogOK::ShowAndGetInput(19033, 19147); /* print info dialog "Unknown error!" */
return;
}
diff --git a/xbmc/pvr/timers/PVRTimerInfoTag.cpp b/xbmc/pvr/timers/PVRTimerInfoTag.cpp
index 0fe493871d..8f305688f7 100644
--- a/xbmc/pvr/timers/PVRTimerInfoTag.cpp
+++ b/xbmc/pvr/timers/PVRTimerInfoTag.cpp
@@ -398,13 +398,13 @@ bool CPVRTimerInfoTag::UpdateOnClient()
void CPVRTimerInfoTag::DisplayError(PVR_ERROR err) const
{
if (err == PVR_ERROR_SERVER_ERROR)
- CGUIDialogOK::ShowAndGetInput(19033,19111,19110,0); /* print info dialog "Server error!" */
+ CGUIDialogOK::ShowAndGetInput(19033, 19111); /* print info dialog "Server error!" */
else if (err == PVR_ERROR_REJECTED)
- CGUIDialogOK::ShowAndGetInput(19033,19109,19110,0); /* print info dialog "Couldn't delete timer!" */
+ CGUIDialogOK::ShowAndGetInput(19033, 19109); /* print info dialog "Couldn't save timer!" */
else if (err == PVR_ERROR_ALREADY_PRESENT)
- CGUIDialogOK::ShowAndGetInput(19033,19109,0,19067); /* print info dialog */
+ CGUIDialogOK::ShowAndGetInput(19033, 19067); /* print info dialog */
else
- CGUIDialogOK::ShowAndGetInput(19033,19147,19110,0); /* print info dialog "Unknown error!" */
+ CGUIDialogOK::ShowAndGetInput(19033, 19110); /* print info dialog "Unknown error!" */
}
void CPVRTimerInfoTag::SetEpgInfoTag(CEpgInfoTagPtr &tag)
diff --git a/xbmc/video/dialogs/GUIDialogAudioSubtitleSettings.cpp b/xbmc/video/dialogs/GUIDialogAudioSubtitleSettings.cpp
index 5e091eb8d1..fcbafaed53 100644
--- a/xbmc/video/dialogs/GUIDialogAudioSubtitleSettings.cpp
+++ b/xbmc/video/dialogs/GUIDialogAudioSubtitleSettings.cpp
@@ -228,7 +228,7 @@ void CGUIDialogAudioSubtitleSettings::Save()
return;
// prompt user if they are sure
- if (!CGUIDialogYesNo::ShowAndGetInput(12376, 750, 0, 12377))
+ if (!CGUIDialogYesNo::ShowAndGetInput(12376, 12377))
return;
// reset the settings
diff --git a/xbmc/video/dialogs/GUIDialogVideoSettings.cpp b/xbmc/video/dialogs/GUIDialogVideoSettings.cpp
index eb814ca11c..9f25fa549a 100644
--- a/xbmc/video/dialogs/GUIDialogVideoSettings.cpp
+++ b/xbmc/video/dialogs/GUIDialogVideoSettings.cpp
@@ -169,7 +169,7 @@ void CGUIDialogVideoSettings::Save()
return;
// prompt user if they are sure
- if (CGUIDialogYesNo::ShowAndGetInput(12376, 750, 0, 12377))
+ if (CGUIDialogYesNo::ShowAndGetInput(12376, 12377))
{ // reset the settings
CVideoDatabase db;
if (!db.Open())
diff --git a/xbmc/video/windows/GUIWindowVideoBase.cpp b/xbmc/video/windows/GUIWindowVideoBase.cpp
index 583eebad80..50e7571259 100644
--- a/xbmc/video/windows/GUIWindowVideoBase.cpp
+++ b/xbmc/video/windows/GUIWindowVideoBase.cpp
@@ -1883,12 +1883,12 @@ void CGUIWindowVideoBase::AppendAndClearSearchItems(CFileItemList &searchItems,
searchItems.Clear();
}
-bool CGUIWindowVideoBase::OnUnAssignContent(const std::string &path, int label1, int label2, int label3)
+bool CGUIWindowVideoBase::OnUnAssignContent(const std::string &path, int header, int text)
{
bool bCanceled;
CVideoDatabase db;
db.Open();
- if (CGUIDialogYesNo::ShowAndGetInput(label1, label2, label3, "", bCanceled))
+ if (CGUIDialogYesNo::ShowAndGetInput(header, text, bCanceled, "", ""))
{
CGUIDialogProgress *progress = (CGUIDialogProgress *)g_windowManager.GetWindow(WINDOW_DIALOG_PROGRESS);
db.RemoveContentForPath(path, progress);
@@ -1926,11 +1926,11 @@ void CGUIWindowVideoBase::OnAssignContent(const std::string &path)
{
if(settings.exclude || (!info && info2))
{
- OnUnAssignContent(path,20375,20340,20341);
+ OnUnAssignContent(path,20375,20340);
}
else if (info != info2)
{
- if (OnUnAssignContent(path,20442,20443,20444))
+ if (OnUnAssignContent(path, 20442, 20443))
bScan = true;
}
}
diff --git a/xbmc/video/windows/GUIWindowVideoBase.h b/xbmc/video/windows/GUIWindowVideoBase.h
index 4ef7ec1b93..b23ce807a5 100644
--- a/xbmc/video/windows/GUIWindowVideoBase.h
+++ b/xbmc/video/windows/GUIWindowVideoBase.h
@@ -132,7 +132,7 @@ protected:
void OnSearchItemFound(const CFileItem* pSelItem);
int GetScraperForItem(CFileItem *item, ADDON::ScraperPtr &info, VIDEO::SScanSettings& settings);
- static bool OnUnAssignContent(const std::string &path, int label1, int label2, int label3);
+ static bool OnUnAssignContent(const std::string &path, int header, int text);
static bool StackingAvailable(const CFileItemList &items);
diff --git a/xbmc/video/windows/GUIWindowVideoNav.cpp b/xbmc/video/windows/GUIWindowVideoNav.cpp
index f42059c094..da888c2955 100644
--- a/xbmc/video/windows/GUIWindowVideoNav.cpp
+++ b/xbmc/video/windows/GUIWindowVideoNav.cpp
@@ -992,7 +992,7 @@ bool CGUIWindowVideoNav::OnContextButton(int itemNumber, CONTEXT_BUTTON button)
if (button == CONTEXT_BUTTON_REMOVE_SOURCE && !item->IsPlugin()
&& !item->IsLiveTV() &&!item->IsRSS() && !URIUtils::IsUPnP(item->GetPath()))
{
- OnUnAssignContent(item->GetPath(),20375,20340,20341);
+ OnUnAssignContent(item->GetPath(), 20375, 20340);
}
Refresh();
return true;