diff options
author | Rechi <Rechi@users.noreply.github.com> | 2022-04-08 11:15:56 +0200 |
---|---|---|
committer | Rechi <Rechi@users.noreply.github.com> | 2022-04-08 11:15:56 +0200 |
commit | 258d514e6bfc9bf038f2e848159f0087c50dfa01 (patch) | |
tree | e0de43ca5b792ee1ef7df021bc5b488678c96eeb | |
parent | ed9869b082d8df79ae4e5c6b6bd790f809f177e8 (diff) |
[clang-tidy] performance-unnecessary-value-param
-rw-r--r-- | xbmc/games/dialogs/osd/DialogGameSaves.cpp | 8 | ||||
-rw-r--r-- | xbmc/games/dialogs/osd/DialogGameSaves.h | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/xbmc/games/dialogs/osd/DialogGameSaves.cpp b/xbmc/games/dialogs/osd/DialogGameSaves.cpp index d4c2136e25..cf66220472 100644 --- a/xbmc/games/dialogs/osd/DialogGameSaves.cpp +++ b/xbmc/games/dialogs/osd/DialogGameSaves.cpp @@ -54,7 +54,7 @@ bool CDialogGameSaves::OnMessage(CGUIMessage& message) if (selectedItem >= 0 && selectedItem < m_vecList->Size()) { CFileItemPtr item = m_vecList->Get(selectedItem); - OnPopupMenu(std::move(item)); + OnPopupMenu(item); return true; } } @@ -79,7 +79,7 @@ void CDialogGameSaves::FrameMove() if (selectedItem >= 0 && selectedItem < m_vecList->Size()) { CFileItemPtr item = m_vecList->Get(selectedItem); - OnFocus(std::move(item)); + OnFocus(item); } } else @@ -99,7 +99,7 @@ std::string CDialogGameSaves::GetSelectedItemPath() return ""; } -void CDialogGameSaves::OnFocus(CFileItemPtr item) +void CDialogGameSaves::OnFocus(const CFileItemPtr& item) { const std::string caption = item->GetProperty(SAVESTATE_CAPTION).asString(); @@ -111,7 +111,7 @@ void CDialogGameSaves::OnFocusLost() HandleCaption(""); } -void CDialogGameSaves::OnPopupMenu(CFileItemPtr item) +void CDialogGameSaves::OnPopupMenu(const CFileItemPtr& item) { const std::string& savePath = item->GetPath(); diff --git a/xbmc/games/dialogs/osd/DialogGameSaves.h b/xbmc/games/dialogs/osd/DialogGameSaves.h index bfd1a84485..61b1fcfcbc 100644 --- a/xbmc/games/dialogs/osd/DialogGameSaves.h +++ b/xbmc/games/dialogs/osd/DialogGameSaves.h @@ -36,7 +36,7 @@ private: /*! * \brief Called every frame with the item being focused */ - void OnFocus(CFileItemPtr item); + void OnFocus(const CFileItemPtr& item); /*! * \brief Called every frame if no item is focused @@ -46,7 +46,7 @@ private: /*! * \brief Called when a popup menu is opened for an item */ - void OnPopupMenu(CFileItemPtr item); + void OnPopupMenu(const CFileItemPtr& item); /*! * \brief Called every frame with the caption to set |