aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyle Hill <kyle.hill@tacomafia.net>2012-09-06 17:29:11 -0500
committerKyle Hill <kyleh@kyle-laptop.(none)>2012-11-28 21:23:04 -0600
commitf574332197dd730cb3b0559548364a9b02c8f4f7 (patch)
tree2b2341f1830dc79a3014cfc2555e49ef26d6a0ca
parentbb7ba45623332ecd01004c41ffb93be577896304 (diff)
Fix unreachable code in GUIDialogMediaSource.cpp
Guidance on this issue is greatly appreciated. I beleive this is correct given how other methods in this class or implemented, but another set of eyes is welcome.
-rw-r--r--xbmc/dialogs/GUIDialogMediaSource.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/xbmc/dialogs/GUIDialogMediaSource.cpp b/xbmc/dialogs/GUIDialogMediaSource.cpp
index e0e015972c..1e3be6ffce 100644
--- a/xbmc/dialogs/GUIDialogMediaSource.cpp
+++ b/xbmc/dialogs/GUIDialogMediaSource.cpp
@@ -165,8 +165,7 @@ bool CGUIDialogMediaSource::ShowAndAddMediaSource(const CStdString &type)
bool CGUIDialogMediaSource::ShowAndEditMediaSource(const CStdString &type, const CStdString&share)
{
- VECSOURCES* pShares=NULL;
-
+ VECSOURCES* pShares = g_settings.GetSourcesFromType(type);
if (pShares)
{
for (unsigned int i=0;i<pShares->size();++i)
@@ -175,7 +174,6 @@ bool CGUIDialogMediaSource::ShowAndEditMediaSource(const CStdString &type, const
return ShowAndEditMediaSource(type,(*pShares)[i]);
}
}
-
return false;
}