diff options
| author | Memphiz <memphis@machzwo.de> | 2012-07-18 13:46:07 -0700 |
|---|---|---|
| committer | Memphiz <memphis@machzwo.de> | 2012-07-18 13:46:07 -0700 |
| commit | 6d6af6bc1fcc8feeef35ccfdc8cfdf970bbd8d8d (patch) | |
| tree | 7ef57419bdd9e1e9021f84353a4b9ea413f31e91 | |
| parent | 204514728e4cace1cd1e3ce9e6719bc6e4bdcb44 (diff) | |
| parent | c34f35bb984f914fdd43a7434dae78e65045cddb (diff) | |
Merge pull request #1180 from jabbera/CKaraokeLyricsCDG-buff-overflow
Fix potential buffer overflow using karaoke.
| -rw-r--r-- | xbmc/music/karaoke/karaokelyricscdg.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xbmc/music/karaoke/karaokelyricscdg.cpp b/xbmc/music/karaoke/karaokelyricscdg.cpp index e4e50f7c2b..204b649fc3 100644 --- a/xbmc/music/karaoke/karaokelyricscdg.cpp +++ b/xbmc/music/karaoke/karaokelyricscdg.cpp @@ -89,7 +89,7 @@ void CKaraokeLyricsCDG::setPixel( int x, int y, BYTE color ) { unsigned int offset = x + y * CDG_FULL_WIDTH; - if ( x < 0 || y < 0 || offset > CDG_FULL_HEIGHT * CDG_FULL_WIDTH ) + if ( x < 0 || y < 0 || offset >= CDG_FULL_HEIGHT * CDG_FULL_WIDTH ) { CLog::Log( LOGERROR, "CDG renderer: set pixel (%d,%d) is out of boundary", x, y ); return; |