1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
|
"use strict";
/**
* @license
* Copyright 2016 Palantir Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Object.defineProperty(exports, "__esModule", { value: true });
var tslib_1 = require("tslib");
var ts = require("typescript");
var Lint = require("../index");
var Rule = (function (_super) {
tslib_1.__extends(Rule, _super);
function Rule() {
return _super !== null && _super.apply(this, arguments) || this;
}
Rule.prototype.apply = function (sourceFile) {
var objectLiteralShorthandWalker = new ObjectLiteralShorthandWalker(sourceFile, this.getOptions());
return this.applyWithWalker(objectLiteralShorthandWalker);
};
return Rule;
}(Lint.Rules.AbstractRule));
/* tslint:disable:object-literal-sort-keys */
Rule.metadata = {
ruleName: "object-literal-shorthand",
description: "Enforces use of ES6 object literal shorthand when possible.",
hasFix: true,
optionsDescription: "Not configurable.",
options: null,
optionExamples: [true],
type: "style",
typescriptOnly: false,
};
/* tslint:enable:object-literal-sort-keys */
Rule.LONGHAND_PROPERTY = "Expected property shorthand in object literal ";
Rule.LONGHAND_METHOD = "Expected method shorthand in object literal ";
exports.Rule = Rule;
var ObjectLiteralShorthandWalker = (function (_super) {
tslib_1.__extends(ObjectLiteralShorthandWalker, _super);
function ObjectLiteralShorthandWalker() {
return _super !== null && _super.apply(this, arguments) || this;
}
ObjectLiteralShorthandWalker.prototype.visitPropertyAssignment = function (node) {
var name = node.name;
var value = node.initializer;
if (name.kind === ts.SyntaxKind.Identifier &&
value.kind === ts.SyntaxKind.Identifier &&
name.getText() === value.getText()) {
// Delete from name start up to value to include the ':'.
var lengthToValueStart = value.getStart() - name.getStart();
var fix = this.deleteText(name.getStart(), lengthToValueStart);
this.addFailureAtNode(node, Rule.LONGHAND_PROPERTY + "('{" + name.getText() + "}').", fix);
}
if (value.kind === ts.SyntaxKind.FunctionExpression) {
var fnNode = value;
if (fnNode.name !== undefined) {
return; // named function expressions are OK.
}
var star = fnNode.asteriskToken !== undefined ? fnNode.asteriskToken.getText() : "";
this.addFailureAtNode(node, Rule.LONGHAND_METHOD + "('{" + name.getText() + star + "() {...}}').");
}
_super.prototype.visitPropertyAssignment.call(this, node);
};
return ObjectLiteralShorthandWalker;
}(Lint.RuleWalker));
|