1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
"use strict";
/**
* @license
* Copyright 2016 Palantir Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Object.defineProperty(exports, "__esModule", { value: true });
var tslib_1 = require("tslib");
var ts = require("typescript");
var Lint = require("../index");
var utils_1 = require("../language/utils");
var Rule = (function (_super) {
tslib_1.__extends(Rule, _super);
function Rule() {
return _super !== null && _super.apply(this, arguments) || this;
}
Rule.prototype.applyWithProgram = function (sourceFile, program) {
return this.applyWithWalker(new NoInferredEmptyObjectTypeRule(sourceFile, this.ruleName, program.getTypeChecker()));
};
return Rule;
}(Lint.Rules.TypedRule));
/* tslint:disable:object-literal-sort-keys */
Rule.metadata = {
ruleName: "no-inferred-empty-object-type",
description: "Disallow type inference of {} (empty object type) at function and constructor call sites",
optionsDescription: "Not configurable.",
options: null,
optionExamples: [true],
type: "functionality",
typescriptOnly: true,
requiresTypeInfo: true,
};
/* tslint:enable:object-literal-sort-keys */
Rule.EMPTY_INTERFACE_INSTANCE = "Explicit type parameter needs to be provided to the constructor";
Rule.EMPTY_INTERFACE_FUNCTION = "Explicit type parameter needs to be provided to the function call";
exports.Rule = Rule;
var NoInferredEmptyObjectTypeRule = (function (_super) {
tslib_1.__extends(NoInferredEmptyObjectTypeRule, _super);
function NoInferredEmptyObjectTypeRule(sourceFile, ruleName, checker) {
var _this = _super.call(this, sourceFile, ruleName, undefined) || this;
_this.checker = checker;
return _this;
}
NoInferredEmptyObjectTypeRule.prototype.walk = function (sourceFile) {
var _this = this;
var cb = function (node) {
if (node.kind === ts.SyntaxKind.CallExpression) {
_this.checkCallExpression(node);
}
else if (node.kind === ts.SyntaxKind.NewExpression) {
_this.checkNewExpression(node);
}
return ts.forEachChild(node, cb);
};
return ts.forEachChild(sourceFile, cb);
};
NoInferredEmptyObjectTypeRule.prototype.checkNewExpression = function (node) {
var _this = this;
if (node.typeArguments === undefined) {
var objType = this.checker.getTypeAtLocation(node);
if (utils_1.isTypeFlagSet(objType, ts.TypeFlags.Object) && objType.typeArguments !== undefined) {
var typeArgs = objType.typeArguments;
if (typeArgs.some(function (a) { return _this.isEmptyObjectInterface(a); })) {
this.addFailureAtNode(node, Rule.EMPTY_INTERFACE_INSTANCE);
}
}
}
};
NoInferredEmptyObjectTypeRule.prototype.checkCallExpression = function (node) {
if (node.typeArguments !== undefined) {
return;
}
var callSig = this.checker.getResolvedSignature(node);
if (callSig === undefined) {
return;
}
var retType = this.checker.getReturnTypeOfSignature(callSig);
if (this.isEmptyObjectInterface(retType)) {
this.addFailureAtNode(node, Rule.EMPTY_INTERFACE_FUNCTION);
}
};
NoInferredEmptyObjectTypeRule.prototype.isEmptyObjectInterface = function (objType) {
var _this = this;
var isAnonymous = utils_1.isObjectFlagSet(objType, ts.ObjectFlags.Anonymous);
var hasProblematicCallSignatures = false;
var hasProperties = (objType.getProperties() !== undefined && objType.getProperties().length > 0);
var hasNumberIndexType = objType.getNumberIndexType() !== undefined;
var hasStringIndexType = objType.getStringIndexType() !== undefined;
var callSig = objType.getCallSignatures();
if (callSig !== undefined && callSig.length > 0) {
var isClean = callSig.every(function (sig) {
var csigRetType = _this.checker.getReturnTypeOfSignature(sig);
return _this.isEmptyObjectInterface(csigRetType);
});
if (!isClean) {
hasProblematicCallSignatures = true;
}
}
return (isAnonymous && !hasProblematicCallSignatures && !hasProperties && !hasNumberIndexType && !hasStringIndexType);
};
return NoInferredEmptyObjectTypeRule;
}(Lint.AbstractWalker));
|
