diff options
author | Florian Dold <florian.dold@gmail.com> | 2017-04-20 03:09:25 +0200 |
---|---|---|
committer | Florian Dold <florian.dold@gmail.com> | 2017-04-24 16:14:29 +0200 |
commit | 82f2b76e25a4a67e01ec67e5ebe39d14ad771ea8 (patch) | |
tree | 965f6eb89b84d65a62b49008fd972c004832ccd1 /src/http.ts | |
parent | e6e0cbc387c2a77b48e4065c229daa65bf1aa0fa (diff) |
Reorganize module loading.
We now use webpack instead of SystemJS, effectively bundling modules
into one file (plus commons chunks) for every entry point. This results
in a much smaller extension size (almost half). Furthermore we use
yarn/npm even for extension run-time dependencies. This relieves us
from manually vendoring and building dependencies. It's also easier to
understand for new developers familiar with node.
Diffstat (limited to 'src/http.ts')
-rw-r--r-- | src/http.ts | 28 |
1 files changed, 10 insertions, 18 deletions
diff --git a/src/http.ts b/src/http.ts index 1d22c4eb2..5e6580016 100644 --- a/src/http.ts +++ b/src/http.ts @@ -22,7 +22,6 @@ "use strict"; - export interface HttpResponse { status: number; responseText: string; @@ -31,31 +30,24 @@ export interface HttpResponse { export interface HttpRequestLibrary { req(method: string, - url: string | uri.URI, + url: string, options?: any): Promise<HttpResponse>; - get(url: string | uri.URI): Promise<HttpResponse>; + get(url: string): Promise<HttpResponse>; - postJson(url: string | uri.URI, body: any): Promise<HttpResponse>; + postJson(url: string, body: any): Promise<HttpResponse>; - postForm(url: string | uri.URI, form: any): Promise<HttpResponse>; + postForm(url: string, form: any): Promise<HttpResponse>; } export class BrowserHttpLib { req(method: string, - url: string|uri.URI, + url: string, options?: any): Promise<HttpResponse> { - let urlString: string; - if (url instanceof URI) { - urlString = url.href(); - } else if (typeof url === "string") { - urlString = url; - } - - return new Promise((resolve, reject) => { + return new Promise<HttpResponse>((resolve, reject) => { let myRequest = new XMLHttpRequest(); - myRequest.open(method, urlString); + myRequest.open(method, url); if (options && options.req) { myRequest.send(options.req); } else { @@ -74,17 +66,17 @@ export class BrowserHttpLib { } - get(url: string|uri.URI) { + get(url: string) { return this.req("get", url); } - postJson(url: string|uri.URI, body: any) { + postJson(url: string, body: any) { return this.req("post", url, {req: JSON.stringify(body)}); } - postForm(url: string|uri.URI, form: any) { + postForm(url: string, form: any) { return this.req("post", url, {req: form}); } } |