add test for zero-value payments

2 files changed, 89 insertions, 1 deletions

diff --git a/packages/taler-wallet-cli/src/integrationtests/test-payment-zero.ts b/packages/taler-wallet-cli/src/integrationtests/test-payment-zero.ts
new file mode 100644
index 000000000..3ab12e392
--- /dev/null
+++ b/packages/taler-wallet-cli/src/integrationtests/test-payment-zero.ts
@@ -0,0 +1,86 @@
+/*
+ This file is part of GNU Taler
+ (C) 2020 Taler Systems S.A.
+
+ GNU Taler is free software; you can redistribute it and/or modify it under the
+ terms of the GNU General Public License as published by the Free Software
+ Foundation; either version 3, or (at your option) any later version.
+
+ GNU Taler is distributed in the hope that it will be useful, but WITHOUT ANY
+ WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+ A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License along with
+ GNU Taler; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
+ */
+
+/**
+ * Imports.
+ */
+import { WalletApiOperation } from "@gnu-taler/taler-wallet-core";
+import { GlobalTestState } from "./harness";
+import {
+  createSimpleTestkudosEnvironment,
+  withdrawViaBank,
+  makeTestPayment,
+} from "./helpers";
+
+/**
+ * Run test for a payment for a "free" order with
+ * an amount of zero.
+ */
+export async function runPaymentZeroTest(t: GlobalTestState) {
+  // Set up test environment
+
+  const {
+    wallet,
+    bank,
+    exchange,
+    merchant,
+  } = await createSimpleTestkudosEnvironment(t);
+
+  // First, make a "free" payment when we don't even have
+  // any money in the
+
+  // Withdraw digital cash into the wallet.
+  await withdrawViaBank(t, { wallet, bank, exchange, amount: "TESTKUDOS:20" });
+
+  await wallet.runUntilDone();
+
+  await makeTestPayment(t, {
+    wallet,
+    merchant,
+    order: {
+      summary: "I am free!",
+      amount: "TESTKUDOS:0",
+      fulfillment_url: "taler://fulfillment-success/thx",
+    },
+  });
+
+  await wallet.runUntilDone();
+
+  // Now try to "pay" for something where we don't even have the
+  // currency.
+  await makeTestPayment(t, {
+    wallet,
+    merchant,
+    order: {
+      summary: "I am also free!",
+      amount: "BLURP:0",
+      fulfillment_url: "taler://fulfillment-success/thx",
+    },
+  });
+
+  await wallet.runUntilDone();
+
+  const transactions = await wallet.client.call(
+    WalletApiOperation.GetTransactions,
+    {},
+  );
+
+  for (const tr of transactions.transactions) {
+    t.assertDeepEqual(tr.pending, false);
+  }
+}
+
+runPaymentZeroTest.suites = ["wallet"];
diff --git a/packages/taler-wallet-cli/src/integrationtests/testrunner.ts b/packages/taler-wallet-cli/src/integrationtests/testrunner.ts
index 82f4c24a7..8162eccd0 100644
--- a/packages/taler-wallet-cli/src/integrationtests/testrunner.ts
+++ b/packages/taler-wallet-cli/src/integrationtests/testrunner.ts
@@ -73,6 +73,7 @@ import { runWalletBackupBasicTest } from "./test-wallet-backup-basic";
 import { runMerchantInstancesDeleteTest } from "./test-merchant-instances-delete";
 import { runWalletBackupDoublespendTest } from "./test-wallet-backup-doublespend";
 import { runPaymentForgettableTest } from "./test-payment-forgettable.js";
+import { runPaymentZeroTest } from "./test-payment-zero.js";
 
 /**
  * Test runner.
@@ -118,6 +119,7 @@ const allTests: TestMainFunction[] = [
   runPaymentTest,
   runPaymentDemoTest,
   runPaymentTransientTest,
+  runPaymentZeroTest,
   runPayPaidTest,
   runPaywallFlowTest,
   runRefundAutoTest,
@@ -150,7 +152,7 @@ export interface TestInfo {
 function updateCurrentSymlink(testDir: string): void {
   const currLink = path.join(
     os.tmpdir(),
-    `taler-integrationtests-${os.userInfo().username}-current`
+    `taler-integrationtests-${os.userInfo().username}-current`,
   );
   try {
     fs.unlinkSync(currLink);