diff options
author | Florian Dold <florian@dold.me> | 2021-03-11 13:08:41 +0100 |
---|---|---|
committer | Florian Dold <florian@dold.me> | 2021-03-11 13:08:41 +0100 |
commit | fb3da3a28d6ed6a16ca7d0fa8ec775de51c7df6b (patch) | |
tree | 0087855f00b92505ebfadca5003315b631c0178e /packages/taler-wallet-core/src/operations | |
parent | 1392dc47c6489fca1b3a4c036852873495190c36 (diff) | |
download | wallet-core-fb3da3a28d6ed6a16ca7d0fa8ec775de51c7df6b.tar.xz |
towards recovering from accidental double spends
Diffstat (limited to 'packages/taler-wallet-core/src/operations')
-rw-r--r-- | packages/taler-wallet-core/src/operations/pay.ts | 44 |
1 files changed, 44 insertions, 0 deletions
diff --git a/packages/taler-wallet-core/src/operations/pay.ts b/packages/taler-wallet-core/src/operations/pay.ts index 03bf9e119..3add9bbbf 100644 --- a/packages/taler-wallet-core/src/operations/pay.ts +++ b/packages/taler-wallet-core/src/operations/pay.ts @@ -84,6 +84,8 @@ import { throwUnexpectedRequestError, getHttpResponseErrorDetails, readSuccessResponseJsonOrErrorCode, + HttpResponseStatus, + readTalerErrorResponse, } from "../util/http"; import { TalerErrorCode } from "../TalerErrorCode"; import { URL } from "../util/url"; @@ -1002,6 +1004,22 @@ async function storePayReplaySuccess( } /** + * Handle a 409 Conflict response from the merchant. + * + * We do this by going through the coin history provided by the exchange and + * (1) verifying the signatures from the exchange + * (2) adjusting the remaining coin value + * (3) re-do coin selection. + */ +async function handleInsufficientFunds( + ws: InternalWalletState, + proposalId: string, + err: TalerErrorDetails, +): Promise<void> { + throw Error("payment re-denomination not implemented yet"); +} + +/** * Submit a payment to the merchant. * * If the wallet has previously paid, it just transmits the merchant's @@ -1078,6 +1096,32 @@ async function submitPay( }; } + if (resp.status === HttpResponseStatus.Conflict) { + const err = await readTalerErrorResponse(resp); + if ( + err.code === + TalerErrorCode.MERCHANT_POST_ORDERS_ID_PAY_INSUFFICIENT_FUNDS + ) { + // Do this in the background, as it might take some time + handleInsufficientFunds(ws, proposalId, err).catch(async (e) => { + await incrementProposalRetry(ws, proposalId, { + code: TalerErrorCode.WALLET_UNEXPECTED_EXCEPTION, + message: "unexpected exception", + hint: "unexpected exception", + details: { + exception: e, + }, + }); + }); + + return { + type: ConfirmPayResultType.Pending, + // FIXME: should we return something better here? + lastError: err, + }; + } + } + const merchantResp = await readSuccessResponseJsonOrThrow( resp, codecForMerchantPayResponse(), |