fix pg_insert_transfer_details.sql: narrow non-transferred deposits to relevant deposits

1 files changed, 4 insertions, 4 deletions

diff --git a/src/backenddb/pg_insert_transfer_details.sql b/src/backenddb/pg_insert_transfer_details.sql
index bf57bc74..a64d0139 100644
--- a/src/backenddb/pg_insert_transfer_details.sql
+++ b/src/backenddb/pg_insert_transfer_details.sql
@@ -194,7 +194,6 @@ LOOP
     FETCH NEXT FROM curs INTO my_affected_orders;
     EXIT WHEN NOT FOUND;
 
-    -- FIXME: statement below is messy, likely buggy (as we don't set WIRED to TRUE correctly...)
     RAISE NOTICE 'checking affected order for completion';
     UPDATE merchant_contract_terms
        SET wired=TRUE
@@ -205,13 +204,14 @@ LOOP
            order_serial=my_affected_orders.order_serial
            AND NOT EXISTS
            (SELECT 1
-              FROM merchant_deposits dep
+              FROM merchant_deposit_confirmations dcon
+              JOIN merchant_deposits dep
+                USING (deposit_confirmation_serial)
               JOIN merchant_deposit_to_transfer
                 USING (deposit_serial)
               JOIN merchant_transfers mtrans
                 USING (credit_serial)
-             WHERE
-               dep.deposit_confirmation_serial = dcon.deposit_confirmation_serial
+             WHERE dcon.order_serial=my_affected_orders.order_serial
                AND NOT mtrans.confirmed));
   END LOOP; -- END curs LOOP
   CLOSE curs;