Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-05-30 | -generate 404 on non-existing accounts for fakebank, use payto://-URIs with ↵ | Christian Grothoff | |
receiver-name in tests | |||
2022-04-06 | -complete va coin parser of purse_create_deposit CMD | Christian Grothoff | |
2022-03-20 | towards support for new reserve history/status APIs | Christian Grothoff | |
2022-02-11 | -get tests to pass | Christian Grothoff | |
2022-02-07 | fix FTBFS of main logic | Christian Grothoff | |
2022-02-06 | -fix recoup testing cmds | Christian Grothoff | |
2022-01-11 | The current recoup API is broken. I guess this is another example where ↵ | Christian Grothoff | |
"trivial" API changes turn out to have (multiple!) unexpected consequences. The current "/recoup" API does not have clear idempotency semantics, as we've discussed on the phone. This is already bad by itself, as it makes it hard to write down what the API does other than "whatever the implementation does". However, it actually breaks correctness in this (admittedly kinda contrived, but not impossible) case: Say that we have a coin A obtained via withdrawal and a coin B obtained via refreshing coin A. Now the denominations of A gets revoked.. The wallet does a recoup of A for EUR:1. Now the denomination of B also gets revoked. The wallet recoups B (incidentally also for EUR:1) and now A can be recouped again for EUR:1. But now the exchange is in a state where it will refuse a legitimate recoup request for A because the detection for an idempotent request kicks in. This is IMHO bad API design, and the exchange should simply always recoup the maximum amount. Furthermore, we usually follow the principle of "API calls that take up DB space are paid". With the current recoup API, I can do many tiny recoup requests which the exchange then has to store, right? I guess it would not be a big change to remove the "amount" value from the recoup/recoup-refresh request bodies, right? - Florian | |||
2021-12-25 | protocol v12 changes (/recoup split, signature changes) plus database ↵ | Christian Grothoff | |
sharding plus O(n^2)=>O(n) worst-case complexity reduction on coin balance checks | |||
2021-12-14 | introducing GNUNET_TIME_Timestamp, recoup now with amounts | Christian Grothoff | |
2021-11-05 | -fixes | Christian Grothoff | |
2021-11-01 | bugfix! | Christian Grothoff | |
2021-10-27 | -work on testing FTBFS | Christian Grothoff | |
2020-04-05 | make exchange API more uniform in how information is returned | Christian Grothoff | |
2020-03-29 | remove bogus warnings | Christian Grothoff | |
2020-03-28 | split recoup and revoke commands into two files for better readability | Christian Grothoff | |
2020-03-22 | doxygen updates | Christian Grothoff | |
2020-03-20 | make recoup idempotent and simplify response | Florian Dold | |
2020-01-20 | spelling of 'mismatch' | Florian Dold | |
2020-01-19 | move testing logic and integration tests into separate directory | Florian Dold | |