Age | Commit message (Collapse) | Author | |
---|---|---|---|
2023-10-25 | new blind signing code builds | Christian Grothoff | |
2023-09-18 | remove coin and reserve histories from exchange replies | Christian Grothoff | |
2023-06-25 | next round of exchange API atomization | Christian Grothoff | |
2023-05-01 | breaking protocol changes towards fixing #7810 (incomplete, ↵ | Christian Grothoff | |
taler-exchange-offline still unfinished) | |||
2022-07-05 | -annotate bugs | Christian Grothoff | |
2022-06-05 | complete P2P/W2W conflict handling, deduplicate code across handlers | Christian Grothoff | |
2022-02-21 | -big renaming of structs for consistent naming with P suffix | Christian Grothoff | |
2022-02-17 | -fix CS nonce reuse check logic | Christian Grothoff | |
2022-02-14 | -towards fixing the protocol | Christian Grothoff | |
2022-02-12 | -remove addessed documentation FIXMEs | Christian Grothoff | |
2022-02-11 | -simplify: nonce no longer hashed | Christian Grothoff | |
2022-02-11 | -get tests to pass | Christian Grothoff | |
2022-02-10 | -get recoup/refresh to pass | Christian Grothoff | |
2022-02-09 | also pass ewvs during recoup-refresh | Christian Grothoff | |
2022-02-06 | -work on refresh_common FTBFS | Christian Grothoff | |
2022-02-06 | -fix refresh FTBFS | Christian Grothoff | |
2022-01-11 | The current recoup API is broken. I guess this is another example where ↵ | Christian Grothoff | |
"trivial" API changes turn out to have (multiple!) unexpected consequences. The current "/recoup" API does not have clear idempotency semantics, as we've discussed on the phone. This is already bad by itself, as it makes it hard to write down what the API does other than "whatever the implementation does". However, it actually breaks correctness in this (admittedly kinda contrived, but not impossible) case: Say that we have a coin A obtained via withdrawal and a coin B obtained via refreshing coin A. Now the denominations of A gets revoked.. The wallet does a recoup of A for EUR:1. Now the denomination of B also gets revoked. The wallet recoups B (incidentally also for EUR:1) and now A can be recouped again for EUR:1. But now the exchange is in a state where it will refuse a legitimate recoup request for A because the detection for an idempotent request kicks in. This is IMHO bad API design, and the exchange should simply always recoup the maximum amount. Furthermore, we usually follow the principle of "API calls that take up DB space are paid". With the current recoup API, I can do many tiny recoup requests which the exchange then has to store, right? I guess it would not be a big change to remove the "amount" value from the recoup/recoup-refresh request bodies, right? - Florian | |||
2021-12-25 | protocol v12 changes (/recoup split, signature changes) plus database ↵ | Christian Grothoff | |
sharding plus O(n^2)=>O(n) worst-case complexity reduction on coin balance checks |