Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-01-11 | The current recoup API is broken. I guess this is another example where ↵ | Christian Grothoff | |
"trivial" API changes turn out to have (multiple!) unexpected consequences. The current "/recoup" API does not have clear idempotency semantics, as we've discussed on the phone. This is already bad by itself, as it makes it hard to write down what the API does other than "whatever the implementation does". However, it actually breaks correctness in this (admittedly kinda contrived, but not impossible) case: Say that we have a coin A obtained via withdrawal and a coin B obtained via refreshing coin A. Now the denominations of A gets revoked.. The wallet does a recoup of A for EUR:1. Now the denomination of B also gets revoked. The wallet recoups B (incidentally also for EUR:1) and now A can be recouped again for EUR:1. But now the exchange is in a state where it will refuse a legitimate recoup request for A because the detection for an idempotent request kicks in. This is IMHO bad API design, and the exchange should simply always recoup the maximum amount. Furthermore, we usually follow the principle of "API calls that take up DB space are paid". With the current recoup API, I can do many tiny recoup requests which the exchange then has to store, right? I guess it would not be a big change to remove the "amount" value from the recoup/recoup-refresh request bodies, right? - Florian | |||
2021-12-25 | v12: also do not sign over merchant_pub in REFUND signature, centralize logic | Christian Grothoff | |
2021-12-25 | protocol v12 changes (/recoup split, signature changes) plus database ↵ | Christian Grothoff | |
sharding plus O(n^2)=>O(n) worst-case complexity reduction on coin balance checks | |||
2021-12-16 | -fix recoup ugliness | Christian Grothoff | |
2021-12-14 | introducing GNUNET_TIME_Timestamp, recoup now with amounts | Christian Grothoff | |
2021-12-11 | fix #7123 | Christian Grothoff | |
2021-12-06 | -fix balance calculation | Christian Grothoff | |
2021-12-05 | -add FIXMEs | Christian Grothoff | |
2021-11-19 | -fix leaks and compiler warnings | Christian Grothoff | |
2021-11-06 | introduce TALER_wallet_deposit_verify | Christian Grothoff | |
2021-10-27 | fix lib/ FTBFS | Christian Grothoff | |
2021-10-27 | -work on FTBFS; | Christian Grothoff | |
2021-10-27 | -fix misc FTBFS | Christian Grothoff | |
2021-10-17 | implement /kyc-wallet in libtalerexchange | Christian Grothoff | |
2021-10-10 | -finish implemnetation of /kyc-check client library | Christian Grothoff | |
2021-08-01 | -allow 0 for refund deadline | Christian Grothoff | |
2021-07-24 | fix #6939 in exchange | Christian Grothoff | |
2021-07-23 | -rename TALER_amount_get_zero to TALER_amount_set_zero | Christian Grothoff | |
2021-01-08 | change wire_reference to be uint64_t always; more work on lrbt_callbacks | Christian Grothoff | |
2020-08-13 | extend tests to discover corner cases from #6478, fix code to actually work ↵ | Christian Grothoff | |
for those cases | |||
2020-08-12 | implement #6478, but untested as shown by FIXMEs | Christian Grothoff | |
2020-07-10 | remove unused/unusable coin_sig, return correct coin_pub in recoup-reveal ↵ | Christian Grothoff | |
failure context | |||
2020-07-08 | implement new behavior in exchange httpd and libtalerexchange (for #6416) | Christian Grothoff | |
2020-07-08 | add h_denom to melt signatures (for #6416) | Christian Grothoff | |
2020-07-08 | add h_denom_pub to deposit signatures | Christian Grothoff | |
2020-07-05 | fix #6408: make sure all timestamps are always rounded when they arrive over ↵ | Christian Grothoff | |
JSON, or 400 the requester; similarly don't tolerate anything else as client | |||
2020-07-05 | GNUNET_free_non_null is gone, use GNUNET_free | Christian Grothoff | |
2020-07-05 | towards changing timestamp in deposit confirmation (tests failing) | Christian Grothoff | |
2020-07-05 | fix status code | Christian Grothoff | |
2020-04-08 | fix #6170 and rest of #6164 | Christian Grothoff | |
2020-04-08 | adapt to new GNUnet sign API (#6164) | Christian Grothoff | |
2020-04-03 | check amount compatibility in history logic | Christian Grothoff | |
2020-04-01 | better types/scoping/indentation | Christian Grothoff | |
2020-03-30 | match updated specification, use CREDIT instead of DEPOSIT for transfers ↵ | Christian Grothoff | |
into a reserve | |||
2020-03-28 | do return fees in history | Christian Grothoff | |
2020-03-17 | style, indentation and type fixes for lib/ | Christian Grothoff | |
2020-03-01 | bad FIXME, we should not | Christian Grothoff | |
2020-02-29 | big rename fest related to #6067 API renaming | Christian Grothoff | |
2020-02-27 | rename fest, make symbols better match new endpoint names | Christian Grothoff | |
2020-01-18 | payback -> recoup stranglers | Christian Grothoff | |
2020-01-18 | fix compiler warnings | Christian Grothoff | |
2020-01-18 | allow skipping of denom fees check | Florian Dold | |
2020-01-17 | doxygen fixes | Christian Grothoff | |
2020-01-17 | sort out URL types more nicely | Christian Grothoff | |
2020-01-17 | check currencies match first | Christian Grothoff | |
2020-01-17 | TODO is already done | Christian Grothoff | |
2020-01-17 | prepare API to enable verification of fees in coin history check | Christian Grothoff | |
2020-01-17 | help crappy indenter | Christian Grothoff | |
2019-10-31 | tighten formatting rules | Christian Grothoff | |
2019-08-25 | re-format code | Florian Dold | |