aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Grothoff <christian@grothoff.org>2022-02-14 23:15:29 +0100
committerChristian Grothoff <christian@grothoff.org>2022-02-14 23:15:29 +0100
commit8ecbdeb55b5f9dfcd39d0ee1eaa2fc3f00aa9c5d (patch)
tree268bd237357c0b36455c17557e80ef0acc3e9241
parentbd77bcb52dcad4b761f3db0acaa6b71b112a31c2 (diff)
-actually, commit phase does take care of this
-rw-r--r--src/exchange/taler-exchange-httpd_refreshes_reveal.c7
-rw-r--r--src/util/denom.c4
2 files changed, 2 insertions, 9 deletions
diff --git a/src/exchange/taler-exchange-httpd_refreshes_reveal.c b/src/exchange/taler-exchange-httpd_refreshes_reveal.c
index 779b9df45..0d8f7bf9b 100644
--- a/src/exchange/taler-exchange-httpd_refreshes_reveal.c
+++ b/src/exchange/taler-exchange-httpd_refreshes_reveal.c
@@ -634,13 +634,6 @@ resolve_refreshes_reveal_denominations (struct MHD_Connection *connection,
rrc->blinded_planchet = rcds[i].blinded_planchet;
}
- // FIXME: in CS-case, we MUST check if signatures
- // already exist under the given nonce
- // (TODO: check: refresh session hash OK?), and if so,
- // we MUST return the existing signatures (c0/c1 may have changed!)
- // and MUST NOT return the fresh signatures!
- // => change this to a 'do_refresh_reveal' and
- // change SQL to return existing signatures (if any)!
qs = TEH_plugin->insert_refresh_reveal (TEH_plugin->cls,
melt_serial_id,
num_fresh_coins,
diff --git a/src/util/denom.c b/src/util/denom.c
index 30e8dc9d4..2e7b1264b 100644
--- a/src/util/denom.c
+++ b/src/util/denom.c
@@ -806,8 +806,8 @@ TALER_coin_ev_hash (const struct TALER_BlindedPlanchet *blinded_planchet,
blinded_planchet->details.rsa_blinded_planchet.blinded_msg_size);
break;
case TALER_DENOMINATION_CS:
- // FIMXE: c-values MUST NOT be included in idempotency check
- // during withdraw/refresh, but right now they are!!!
+ // FIXME: c-values MUST NOT be included in idempotency check
+ // during withdraw (or recoup), but right now they are!!!
GNUNET_CRYPTO_hash_context_read (
hash_context,
&blinded_planchet->details.cs_blinded_planchet.c[0],