removing warnings

17 files changed, 44 insertions, 12 deletions

diff --git a/src/auditor/taler-auditor-httpd_mhd.c b/src/auditor/taler-auditor-httpd_mhd.c
index 2a350fd09..a8322a830 100644
--- a/src/auditor/taler-auditor-httpd_mhd.c
+++ b/src/auditor/taler-auditor-httpd_mhd.c
@@ -52,6 +52,9 @@ TAH_MHD_handler_static_response (struct TAH_RequestHandler *rh,
 {
   size_t dlen;
 
+  (void) connection_cls;
+  (void) upload_data;
+  (void) upload_data_size;
   dlen = (0 == rh->data_size)
          ? strlen ((const char *) rh->data)
          : rh->data_size;
diff --git a/src/testing/testing_api_cmd_auditor_deposit_confirmation.c b/src/testing/testing_api_cmd_auditor_deposit_confirmation.c
index b3ca4dd48..31c6e850e 100644
--- a/src/testing/testing_api_cmd_auditor_deposit_confirmation.c
+++ b/src/testing/testing_api_cmd_auditor_deposit_confirmation.c
@@ -221,6 +221,7 @@ deposit_confirmation_run (void *cls,
   const struct TALER_EXCHANGE_Keys *keys;
   const struct TALER_EXCHANGE_SigningPublicKey *spk;
 
+  (void) cmd;
   dcs->is = is;
   GNUNET_assert (NULL != dcs->deposit_reference);
   deposit_cmd
@@ -385,6 +386,10 @@ deposit_confirmation_traits (void *cls,
                              const char *trait,
                              unsigned int index)
 {
+  (void) cls;
+  (void) ret;
+  (void) trait;
+  (void) index;
   /* Must define this function because some callbacks
    * look for certain traits on _all_ the commands. */
   return GNUNET_SYSERR;
diff --git a/src/testing/testing_api_cmd_auditor_exchanges.c b/src/testing/testing_api_cmd_auditor_exchanges.c
index 4b143f106..17099cb89 100644
--- a/src/testing/testing_api_cmd_auditor_exchanges.c
+++ b/src/testing/testing_api_cmd_auditor_exchanges.c
@@ -221,6 +221,7 @@ exchanges_run (void *cls,
 {
   struct ExchangesState *es = cls;
 
+  (void) cmd;
   es->is = is;
   es->leh = TALER_AUDITOR_list_exchanges
               (is->auditor,
@@ -283,6 +284,10 @@ exchanges_traits (void *cls,
                   const char *trait,
                   unsigned int index)
 {
+  (void) cls;
+  (void) ret;
+  (void) trait;
+  (void) index;
   /* Must define this function because some callbacks
    * look for certain traits on _all_ the commands. */
   return GNUNET_SYSERR;
diff --git a/src/testing/testing_api_cmd_auditor_exec_auditor.c b/src/testing/testing_api_cmd_auditor_exec_auditor.c
index 4e071d0c2..13cf59df1 100644
--- a/src/testing/testing_api_cmd_auditor_exec_auditor.c
+++ b/src/testing/testing_api_cmd_auditor_exec_auditor.c
@@ -61,6 +61,7 @@ auditor_run (void *cls,
 {
   struct AuditorState *ks = cls;
 
+  (void) cmd;
   ks->auditor_proc
     = GNUNET_OS_start_process (GNUNET_NO,
                                GNUNET_OS_INHERIT_STD_ALL,
@@ -92,6 +93,7 @@ auditor_cleanup (void *cls,
 {
   struct AuditorState *ks = cls;
 
+  (void) cmd;
   if (NULL != ks->auditor_proc)
   {
     GNUNET_break (0 ==
diff --git a/src/testing/testing_api_cmd_auditor_exec_auditor_dbinit.c b/src/testing/testing_api_cmd_auditor_exec_auditor_dbinit.c
index 005a606a9..bc807feae 100644
--- a/src/testing/testing_api_cmd_auditor_exec_auditor_dbinit.c
+++ b/src/testing/testing_api_cmd_auditor_exec_auditor_dbinit.c
@@ -61,6 +61,7 @@ auditor_dbinit_run (void *cls,
 {
   struct AuditorDbinitState *ks = cls;
 
+  (void) cmd;
   ks->auditor_dbinit_proc
     = GNUNET_OS_start_process (GNUNET_NO,
                                GNUNET_OS_INHERIT_STD_ALL,
@@ -93,6 +94,7 @@ auditor_dbinit_cleanup (void *cls,
 {
   struct AuditorDbinitState *ks = cls;
 
+  (void) cmd;
   if (NULL != ks->auditor_dbinit_proc)
   {
     GNUNET_break (0 ==
diff --git a/src/testing/testing_api_cmd_bank_admin_add_incoming.c b/src/testing/testing_api_cmd_bank_admin_add_incoming.c
index cf90e50e0..30ba83e2d 100644
--- a/src/testing/testing_api_cmd_bank_admin_add_incoming.c
+++ b/src/testing/testing_api_cmd_bank_admin_add_incoming.c
@@ -195,6 +195,7 @@ confirmation_cb (void *cls,
   struct AdminAddIncomingState *fts = cls;
   struct TALER_TESTING_Interpreter *is = fts->is;
 
+  (void) json;
   fts->aih = NULL;
   if (MHD_HTTP_OK != http_status)
   {
@@ -253,6 +254,7 @@ admin_add_incoming_run (void *cls,
 {
   struct AdminAddIncomingState *fts = cls;
 
+  (void) cmd;
   /* Use reserve public key as subject */
   if (NULL != fts->reserve_reference)
   {
diff --git a/src/testing/testing_api_cmd_bank_admin_check.c b/src/testing/testing_api_cmd_bank_admin_check.c
index ced2a8c84..473f3f3f2 100644
--- a/src/testing/testing_api_cmd_bank_admin_check.c
+++ b/src/testing/testing_api_cmd_bank_admin_check.c
@@ -83,6 +83,7 @@ check_bank_admin_transfer_run (void *cls,
   const struct TALER_ReservePublicKeyP *reserve_pub;
   const struct TALER_TESTING_Command *cmd_ref;
 
+  (void) cmd;
   cmd_ref
     = TALER_TESTING_interpreter_lookup_command (is,
                                                 bcs->reserve_pub_ref);
@@ -153,6 +154,7 @@ check_bank_admin_transfer_cleanup (void *cls,
 {
   struct BankAdminCheckState *bcs = cls;
 
+  (void) cmd;
   GNUNET_free (bcs);
 }
 
diff --git a/src/testing/testing_api_cmd_bank_check.c b/src/testing/testing_api_cmd_bank_check.c
index 9d1f3e8ef..c01bc709f 100644
--- a/src/testing/testing_api_cmd_bank_check.c
+++ b/src/testing/testing_api_cmd_bank_check.c
@@ -94,6 +94,7 @@ check_bank_transfer_run (void *cls,
   const char *debit_payto;
   const char *credit_payto;
 
+  (void) cmd;
   if (NULL == bcs->deposit_reference)
   {
     TALER_LOG_INFO ("Deposit reference NOT given\n");
@@ -194,6 +195,7 @@ check_bank_transfer_cleanup (void *cls,
 {
   struct BankCheckState *bcs = cls;
 
+  (void) cmd;
   GNUNET_free (bcs);
 }
 
diff --git a/src/testing/testing_api_cmd_bank_check_empty.c b/src/testing/testing_api_cmd_bank_check_empty.c
index a26fd9bb1..ee16e5a91 100644
--- a/src/testing/testing_api_cmd_bank_check_empty.c
+++ b/src/testing/testing_api_cmd_bank_check_empty.c
@@ -40,6 +40,8 @@ check_bank_empty_cleanup
   (void *cls,
   const struct TALER_TESTING_Command *cmd)
 {
+  (void) cls;
+  (void) cmd;
   return;
 }
 
@@ -56,6 +58,8 @@ check_bank_empty_run (void *cls,
                       const struct TALER_TESTING_Command *cmd,
                       struct TALER_TESTING_Interpreter *is)
 {
+  (void) cls;
+  (void) cmd;
   if (GNUNET_OK != TALER_FAKEBANK_check_empty (is->fakebank))
   {
     GNUNET_break (0);
@@ -76,6 +80,10 @@ check_bank_empty_traits (void *cls,
                          const char *trait,
                          unsigned int index)
 {
+  (void) cls;
+  (void) ret;
+  (void) trait;
+  (void) index;
   return GNUNET_SYSERR;
 }
 
diff --git a/src/testing/testing_api_cmd_bank_history_credit.c b/src/testing/testing_api_cmd_bank_history_credit.c
index aff50d830..0b71c7162 100644
--- a/src/testing/testing_api_cmd_bank_history_credit.c
+++ b/src/testing/testing_api_cmd_bank_history_credit.c
@@ -335,7 +335,6 @@ build_history (struct TALER_TESTING_Interpreter *is,
  * Check that the "/history/incoming" response matches the
  * CMD whose offset in the list of CMDs is @a off.
  *
- * @param is the interpreter state.
  * @param h expected history (array)
  * @param total length of @a h
  * @param off the offset (of the CMD list) where the command
@@ -344,8 +343,7 @@ build_history (struct TALER_TESTING_Interpreter *is,
  * @return #GNUNET_OK if the transaction is what we expect.
  */
 static int
-check_result (struct TALER_TESTING_Interpreter *is,
-              struct History *h,
+check_result (struct History *h,
               unsigned int total,
               unsigned int off,
               const struct TALER_BANK_CreditDetails *details)
@@ -455,8 +453,7 @@ history_cb (void *cls,
   }
 
   /* check current element */
-  if (GNUNET_OK != check_result (is,
-                                 hs->h,
+  if (GNUNET_OK != check_result (hs->h,
                                  hs->total,
                                  hs->results_obtained,
                                  details))
diff --git a/src/testing/testing_api_cmd_bank_history_debit.c b/src/testing/testing_api_cmd_bank_history_debit.c
index 38d7ab95e..ebabf8d94 100644
--- a/src/testing/testing_api_cmd_bank_history_debit.c
+++ b/src/testing/testing_api_cmd_bank_history_debit.c
@@ -343,7 +343,6 @@ build_history (struct TALER_TESTING_Interpreter *is,
  * Check that the "/history/outgoing" response matches the
  * CMD whose offset in the list of CMDs is @a off.
  *
- * @param is the interpreter state.
  * @param h expected history
  * @param total number of entries in @a h
  * @param off the offset (of the CMD list) where the command
@@ -352,8 +351,7 @@ build_history (struct TALER_TESTING_Interpreter *is,
  * @return #GNUNET_OK if the transaction is what we expect.
  */
 static int
-check_result (struct TALER_TESTING_Interpreter *is,
-              struct History *h,
+check_result (struct History *h,
               uint64_t total,
               unsigned int off,
               const struct TALER_BANK_DebitDetails *details)
@@ -457,8 +455,7 @@ history_cb (void *cls,
   }
 
   /* check current element */
-  if (GNUNET_OK != check_result (is,
-                                 hs->h,
+  if (GNUNET_OK != check_result (hs->h,
                                  hs->total,
                                  hs->results_obtained,
                                  details))
diff --git a/src/testing/testing_api_cmd_bank_transfer.c b/src/testing/testing_api_cmd_bank_transfer.c
index 6da7c99b0..7e7174b24 100644
--- a/src/testing/testing_api_cmd_bank_transfer.c
+++ b/src/testing/testing_api_cmd_bank_transfer.c
@@ -238,6 +238,7 @@ transfer_run (void *cls,
   void *buf;
   size_t buf_size;
 
+  (void) cmd;
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Transfer of %s from %s to %s\n",
               TALER_amount2s (&fts->amount),
diff --git a/src/testing/testing_api_cmd_batch.c b/src/testing/testing_api_cmd_batch.c
index 74ff0247b..48ccf55f1 100644
--- a/src/testing/testing_api_cmd_batch.c
+++ b/src/testing/testing_api_cmd_batch.c
@@ -72,7 +72,7 @@ batch_run (void *cls,
   }
   bs->batch[bs->batch_ip].start_time
     = bs->batch[bs->batch_ip].last_req_time
-        = GNUNET_TIME_absolute_get ();
+      = GNUNET_TIME_absolute_get ();
   bs->batch[bs->batch_ip].num_tries = 1;
   bs->batch[bs->batch_ip].run (bs->batch[bs->batch_ip].cls,
                                &bs->batch[bs->batch_ip],
@@ -93,6 +93,7 @@ batch_cleanup (void *cls,
 {
   struct BatchState *bs = cls;
 
+  (void) cmd;
   for (unsigned int i = 0;
        NULL != bs->batch[i].label;
        i++)
diff --git a/src/testing/testing_api_cmd_check_keys.c b/src/testing/testing_api_cmd_check_keys.c
index 397ace562..a0dca8cf9 100644
--- a/src/testing/testing_api_cmd_check_keys.c
+++ b/src/testing/testing_api_cmd_check_keys.c
@@ -186,6 +186,7 @@ check_keys_cleanup (void *cls,
 {
   struct CheckKeysState *cks = cls;
 
+  (void) cmd;
   GNUNET_free (cks);
 }
 
diff --git a/src/testing/testing_api_cmd_deposit.c b/src/testing/testing_api_cmd_deposit.c
index 7e97f544c..8e6e34a57 100644
--- a/src/testing/testing_api_cmd_deposit.c
+++ b/src/testing/testing_api_cmd_deposit.c
@@ -267,6 +267,7 @@ deposit_run (void *cls,
   struct TALER_MerchantPublicKeyP merchant_pub;
   struct GNUNET_HashCode h_contract_terms;
 
+  (void) cmd;
   ds->is = is;
   GNUNET_assert (ds->coin_reference);
   coin_cmd = TALER_TESTING_interpreter_lookup_command
diff --git a/src/testing/testing_api_cmd_exec_aggregator.c b/src/testing/testing_api_cmd_exec_aggregator.c
index 7602cf1d5..f11671888 100644
--- a/src/testing/testing_api_cmd_exec_aggregator.c
+++ b/src/testing/testing_api_cmd_exec_aggregator.c
@@ -60,6 +60,7 @@ aggregator_run (void *cls,
 {
   struct AggregatorState *as = cls;
 
+  (void) cmd;
   as->aggregator_proc
     = GNUNET_OS_start_process (GNUNET_NO,
                                GNUNET_OS_INHERIT_STD_ALL,
@@ -92,6 +93,7 @@ aggregator_cleanup (void *cls,
 {
   struct AggregatorState *as = cls;
 
+  (void) cmd;
   if (NULL != as->aggregator_proc)
   {
     GNUNET_break (0 ==
diff --git a/src/testing/testing_api_loop.c b/src/testing/testing_api_loop.c
index b4b1aaaad..7c3a7aaa9 100644
--- a/src/testing/testing_api_loop.c
+++ b/src/testing/testing_api_loop.c
@@ -274,7 +274,7 @@ interpreter_run (void *cls)
               cmd->label);
   cmd->start_time
     = cmd->last_req_time
-        = GNUNET_TIME_absolute_get ();
+      = GNUNET_TIME_absolute_get ();
   cmd->num_tries = 1;
   cmd->run (cmd->cls,
             cmd,
@@ -591,6 +591,7 @@ TALER_TESTING_cert_cb (void *cls,
   struct MainContext *main_ctx = cls;
   struct TALER_TESTING_Interpreter *is = main_ctx->is;
 
+  (void) compat;
   if (NULL == keys)
   {
     if (GNUNET_NO == is->working)