DCE, fix some doxygen issues

13 files changed, 42 insertions, 481 deletions

diff --git a/src/auditor/Makefile.am b/src/auditor/Makefile.am
index 884b68117..cc1cd3979 100644
--- a/src/auditor/Makefile.am
+++ b/src/auditor/Makefile.am
@@ -172,7 +172,6 @@ taler_auditor_httpd_SOURCES = \
   taler-auditor-httpd_amount-arithmetic-inconsistency-del.c taler-auditor-httpd_amount-arithmetic-inconsistency-del.h \
   taler-auditor-httpd_coin-inconsistency-del.c taler-auditor-httpd_coin-inconsistency-del.h \
   taler-auditor-httpd_row-inconsistency-del.c taler-auditor-httpd_row-inconsistency-del.h \
-  taler-auditor-httpd_amount-arithmetic-inconsistency-put.c taler-auditor-httpd_amount-arithmetic-inconsistency-put.h \
   taler-auditor-httpd_amount-arithmetic-inconsistency-upd.c taler-auditor-httpd_amount-arithmetic-inconsistency-upd.h \
   taler-auditor-httpd_coin-inconsistency-put.c taler-auditor-httpd_coin-inconsistency-put.h \
   taler-auditor-httpd_row-inconsistency-put.c taler-auditor-httpd_row-inconsistency-put.h \
@@ -191,7 +190,6 @@ taler_auditor_httpd_SOURCES = \
   taler-auditor-httpd_reserve-balance-insufficient-inconsistency-put.c taler-auditor-httpd_reserve-balance-insufficient-inconsistency-put.h \
   taler-auditor-httpd_reserve-balance-insufficient-inconsistency-get.c taler-auditor-httpd_reserve-balance-insufficient-inconsistency-get.h \
   taler-auditor-httpd_reserve-balance-insufficient-inconsistency-del.c taler-auditor-httpd_reserve-balance-insufficient-inconsistency-del.h \
-  taler-auditor-httpd_bad-sig-losses-put.c taler-auditor-httpd_bad-sig-losses-put.h \
   taler-auditor-httpd_bad-sig-losses-get.c taler-auditor-httpd_bad-sig-losses-get.h \
   taler-auditor-httpd_bad-sig-losses-del.c taler-auditor-httpd_bad-sig-losses-del.h \
   taler-auditor-httpd_bad-sig-losses-upd.c taler-auditor-httpd_bad-sig-losses-upd.h \
diff --git a/src/auditor/taler-auditor-httpd.c b/src/auditor/taler-auditor-httpd.c
index f1fa431ad..722d82946 100644
--- a/src/auditor/taler-auditor-httpd.c
+++ b/src/auditor/taler-auditor-httpd.c
@@ -34,7 +34,6 @@
 #include "taler-auditor-httpd_deposit-confirmation-del.h"
 #include "taler-auditor-httpd_deposit-confirmation-get.h"
 #include "taler-auditor-httpd_amount-arithmetic-inconsistency-get.h"
-#include "taler-auditor-httpd_amount-arithmetic-inconsistency-put.h"
 #include "taler-auditor-httpd_amount-arithmetic-inconsistency-del.h"
 #include "taler-auditor-httpd_amount-arithmetic-inconsistency-upd.h"
 #include "taler-auditor-httpd_coin-inconsistency-get.h"
@@ -68,7 +67,6 @@
 #include "taler-auditor-httpd_reserve-balance-insufficient-inconsistency-del.h"
 
 #include "taler-auditor-httpd_bad-sig-losses-get.h"
-#include "taler-auditor-httpd_bad-sig-losses-put.h"
 #include "taler-auditor-httpd_bad-sig-losses-del.h"
 #include "taler-auditor-httpd_bad-sig-losses-upd.h"
 
@@ -271,8 +269,9 @@ handle_mhd_completion_callback (void *cls,
  * @param[in,out] connection_cls the connection's closure (can be updated)
  * @param upload_data upload data
  * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
+ * @param args NULL-terminated array of remaining parts of the URI broken up at '/'
  * @return MHD result code
-  */
+ */
 static MHD_RESULT
 handle_config (struct TAH_RequestHandler *rh,
                struct MHD_Connection *connection,
@@ -446,10 +445,6 @@ handle_mhd_request (void *cls,
       "application/json",
       NULL, 0,
       &TAH_AMOUNT_ARITHMETIC_INCONSISTENCY_handler_get, MHD_HTTP_OK, true },
-    { "/monitoring/amount-arithmetic-inconsistency", MHD_HTTP_METHOD_PUT,
-      "application/json",
-      NULL, 0,
-      &TAH_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_handler, MHD_HTTP_OK, true },
     { "/monitoring/amount-arithmetic-inconsistency", MHD_HTTP_METHOD_DELETE,
       "application/json",
       NULL, 0,
@@ -495,11 +490,6 @@ handle_mhd_request (void *cls,
       NULL, 0,
       &TAH_BAD_SIG_LOSSES_handler_get,
       MHD_HTTP_OK, true },
-    { "/monitoring/bad-sig-losses", MHD_HTTP_METHOD_PUT,
-      "application/json",
-      NULL, 0,
-      &TAH_BAD_SIG_LOSSES_PUT_handler,
-      MHD_HTTP_OK, true },
     { "/monitoring/bad-sig-losses", MHD_HTTP_METHOD_DELETE,
       "application/json",
       NULL, 0,
diff --git a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-del.h b/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-del.h
index 138847768..90bc3696f 100644
--- a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-del.h
+++ b/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-del.h
@@ -25,8 +25,9 @@ TEAH_AMOUNT_ARITHMETIC_INCONSISTENCY_DELETE_done (void);
  * @param[in,out] connection_cls the connection's closure (can be updated)
  * @param upload_data upload data
  * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
+ * @param args NULL-terminated array of remaining parts of the URI broken up at '/'
  * @return MHD result code
-  */
+ */
 MHD_RESULT
 TAH_AMOUNT_ARITHMETIC_INCONSISTENCY_handler_delete (struct
                                                     TAH_RequestHandler *rh,
@@ -38,4 +39,4 @@ TAH_AMOUNT_ARITHMETIC_INCONSISTENCY_handler_delete (struct
                                                     const char *const args[]);
 
 
-#endif // SRC_TALER_AUDITOR_HTTPD_AMOUNT_ARITHMETIC_INCONSISTENCY_DEL_H
\ No newline at end of file
+#endif // SRC_TALER_AUDITOR_HTTPD_AMOUNT_ARITHMETIC_INCONSISTENCY_DEL_H
diff --git a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-get.h b/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-get.h
index 62269a14e..fac140bfb 100644
--- a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-get.h
+++ b/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-get.h
@@ -40,8 +40,9 @@ TEAH_AMOUNT_ARITHMETIC_INCONSISTENCY_GET_done (void);
  * @param[in,out] connection_cls the connection's closure (can be updated)
  * @param upload_data upload data
  * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
+ * @param args NULL-terminated array of remaining parts of the URI broken up at '/'
  * @return MHD result code
-  */
+ */
 MHD_RESULT
 TAH_AMOUNT_ARITHMETIC_INCONSISTENCY_handler_get (struct TAH_RequestHandler *rh,
                                                  struct MHD_Connection *
diff --git a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-put.c b/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-put.c
deleted file mode 100644
index 0806f32c6..000000000
--- a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-put.c
+++ /dev/null
@@ -1,158 +0,0 @@
-/*
-   This file is part of TALER
-   Copyright (C) 2024 Taler Systems SA
-
-   TALER is free software; you can redistribute it and/or modify it under the
-   terms of the GNU General Public License as published by the Free Software
-   Foundation; either version 3, or (at your option) any later version.
-
-   TALER is distributed in the hope that it will be useful, but WITHOUT ANY
-   WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-   A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License along with
-   TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
- */
-
-#include "platform.h"
-#include <gnunet/gnunet_util_lib.h>
-#include <gnunet/gnunet_json_lib.h>
-#include <jansson.h>
-#include <microhttpd.h>
-#include <pthread.h>
-#include "taler_json_lib.h"
-#include "taler_mhd_lib.h"
-#include "taler-auditor-httpd.h"
-#include "taler-auditor-httpd_amount-arithmetic-inconsistency-put.h"
-
-/**
- * We have parsed the JSON information about the deposit, do some
- * basic sanity checks (especially that the signature on the coin is
- * valid, and that this type of coin exists) and then execute the
- * deposit.
- *
- * @param connection the MHD connection to handle
- * @param dc information about the deposit confirmation
- * @param es information about the exchange's signing key
- * @return MHD result code
- */
-static MHD_RESULT
-process_inconsistency (
-  struct MHD_Connection *connection,
-  const struct TALER_AUDITORDB_AmountArithmeticInconsistency *dc)
-{
-
-  enum GNUNET_DB_QueryStatus qs;
-
-  if (GNUNET_SYSERR ==
-      TAH_plugin->preflight (TAH_plugin->cls))
-  {
-    GNUNET_break (0);
-    return TALER_MHD_reply_with_error (connection,
-                                       MHD_HTTP_INTERNAL_SERVER_ERROR,
-                                       TALER_EC_GENERIC_DB_SETUP_FAILED,
-                                       NULL);
-  }
-
-  /* execute transaction */
-  qs = TAH_plugin->insert_amount_arithmetic_inconsistency (TAH_plugin->cls,
-                                                           dc);
-  if (0 > qs)
-  {
-    GNUNET_break (GNUNET_DB_STATUS_HARD_ERROR == qs);
-    TALER_LOG_WARNING (
-      "Failed to store /insert-amount-arithmetic in database\n");
-    return TALER_MHD_reply_with_error (connection,
-                                       MHD_HTTP_INTERNAL_SERVER_ERROR,
-                                       TALER_EC_GENERIC_DB_STORE_FAILED,
-                                       "insert amount arithmetic");
-  }
-  return TALER_MHD_REPLY_JSON_PACK (connection,
-                                    MHD_HTTP_OK,
-                                    GNUNET_JSON_pack_string ("status",
-                                                             "INSERT_AMOUNT_ARITHMETIC_OK"));
-}
-
-
-MHD_RESULT
-TAH_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_handler (
-  struct TAH_RequestHandler *rh,
-  struct MHD_Connection *connection,
-  void **connection_cls,
-  const char *upload_data,
-  size_t *upload_data_size,
-  const char *const args[])
-{
-
-  struct TALER_AUDITORDB_AmountArithmeticInconsistency dc = {
-
-  };
-
-
-  struct GNUNET_JSON_Specification spec[] = {
-    GNUNET_JSON_spec_fixed_auto ("operation", &dc.operation),
-    TALER_JSON_spec_amount ("exchange_amount", TAH_currency,
-                            &dc.exchange_amount),
-    TALER_JSON_spec_amount ("auditor_amount", TAH_currency,&dc.auditor_amount),
-    GNUNET_JSON_spec_bool ("profitable", &dc.profitable),
-    GNUNET_JSON_spec_end ()
-  };
-
-
-  json_t *json;
-
-  (void) rh;
-  (void) connection_cls;
-  (void) upload_data;
-  (void) upload_data_size;
-  {
-    enum GNUNET_GenericReturnValue res;
-
-    res = TALER_MHD_parse_post_json (connection,
-                                     connection_cls,
-                                     upload_data,
-                                     upload_data_size,
-                                     &json);
-    if (GNUNET_SYSERR == res)
-      return MHD_NO;
-    if ((GNUNET_NO == res) ||
-        (NULL == json))
-      return MHD_YES;
-    res = TALER_MHD_parse_json_data (connection,
-                                     json,
-                                     spec);
-    if (GNUNET_SYSERR == res)
-    {
-      json_decref (json);
-      return MHD_NO;             /* hard failure */
-    }
-    if (GNUNET_NO == res)
-    {
-      json_decref (json);
-      return MHD_YES;             /* failure */
-    }
-  }
-
-  MHD_RESULT res;
-
-  res = process_inconsistency (connection, &dc);
-
-  GNUNET_JSON_parse_free (spec);
-  json_decref (json);
-  return res;
-
-}
-
-
-void
-TEAH_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_init (void)
-{
-
-}
-
-
-void
-TEAH_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_done (void)
-{
-
-}
\ No newline at end of file
diff --git a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-put.h b/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-put.h
deleted file mode 100644
index 9f8e15fd4..000000000
--- a/src/auditor/taler-auditor-httpd_amount-arithmetic-inconsistency-put.h
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
-   This file is part of TALER
-   Copyright (C) 2024 Taler Systems SA
-
-   TALER is free software; you can redistribute it and/or modify it under the
-   terms of the GNU General Public License as published by the Free Software
-   Foundation; either version 3, or (at your option) any later version.
-
-   TALER is distributed in the hope that it will be useful, but WITHOUT ANY
-   WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-   A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License along with
-   TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
- */
-
-#ifndef SRC_TALER_AUDITOR_HTTPD_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_H
-#define SRC_TALER_AUDITOR_HTTPD_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_H
-
-#include <microhttpd.h>
-#include "taler-auditor-httpd.h"
-
-/**
- * Initialize subsystem.
- */
-void
-TEAH_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_init (void);
-
-/**
- * Shut down subsystem.
- */
-void
-TEAH_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_done (void);
-
-
-/**
- * Handle a "/deposit-confirmation" request.  Parses the JSON, and, if
- * successful, checks the signatures and stores the result in the DB.
- *
- * @param rh context of the handler
- * @param connection the MHD connection to handle
- * @param[in,out] connection_cls the connection's closure (can be updated)
- * @param upload_data upload data
- * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
- * @return MHD result code
-  */
-MHD_RESULT
-TAH_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_handler (struct TAH_RequestHandler *rh,
-                                                 struct MHD_Connection *
-                                                 connection,
-                                                 void **connection_cls,
-                                                 const char *upload_data,
-                                                 size_t *upload_data_size,
-                                                 const char *const args[]);
-
-
-#endif // SRC_TALER_AUDITOR_HTTPD_AMOUNT_ARITHMETIC_INCONSISTENCY_PUT_H
diff --git a/src/auditor/taler-auditor-httpd_bad-sig-losses-del.h b/src/auditor/taler-auditor-httpd_bad-sig-losses-del.h
index 18855c185..c55477849 100644
--- a/src/auditor/taler-auditor-httpd_bad-sig-losses-del.h
+++ b/src/auditor/taler-auditor-httpd_bad-sig-losses-del.h
@@ -14,8 +14,8 @@
    TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
  */
 
-#ifndef SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_DEL_H
-#define SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_DEL_H
+#ifndef TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_DEL_H
+#define TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_DEL_H
 
 
 #include <microhttpd.h>
@@ -42,8 +42,9 @@ TEAH_BAD_SIG_LOSSES_DELETE_done (void);
  * @param[in,out] connection_cls the connection's closure (can be updated)
  * @param upload_data upload data
  * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
+ * @param args NULL-terminated array of remaining parts of the URI broken up at '/'
  * @return MHD result code
-  */
+ */
 MHD_RESULT
 TAH_BAD_SIG_LOSSES_handler_delete (struct TAH_RequestHandler *rh,
                                    struct MHD_Connection *
@@ -54,4 +55,4 @@ TAH_BAD_SIG_LOSSES_handler_delete (struct TAH_RequestHandler *rh,
                                    const char *const args[]);
 
 
-#endif // SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_DEL_H
+#endif
diff --git a/src/auditor/taler-auditor-httpd_bad-sig-losses-get.h b/src/auditor/taler-auditor-httpd_bad-sig-losses-get.h
index ce630c4ec..81c98d818 100644
--- a/src/auditor/taler-auditor-httpd_bad-sig-losses-get.h
+++ b/src/auditor/taler-auditor-httpd_bad-sig-losses-get.h
@@ -15,8 +15,8 @@
  */
 
 
-#ifndef SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_GET_H
-#define SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_GET_H
+#ifndef TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_GET_H
+#define TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_GET_H
 
 #include <gnunet/gnunet_util_lib.h>
 #include <microhttpd.h>
@@ -35,15 +35,16 @@ void
 TEAH_BAD_SIG_LOSSES_GET_done (void);
 
 /**
-* Handle a "/bad-sig-losses" request.
-*
-* @param rh context of the handler
-* @param connection the MHD connection to handle
-* @param[in,out] connection_cls the connection's closure (can be updated)
-* @param upload_data upload data
-* @param[in,out] upload_data_size number of bytes (left) in @a upload_data
-* @return MHD result code
-*/
+ * Handle a "/bad-sig-losses" request.
+ *
+ * @param rh context of the handler
+ * @param connection the MHD connection to handle
+ * @param[in,out] connection_cls the connection's closure (can be updated)
+ * @param upload_data upload data
+ * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
+ * @param args NULL-terminated array of remaining parts of the URI broken up at '/'
+ * @return MHD result code
+ */
 MHD_RESULT
 TAH_BAD_SIG_LOSSES_handler_get (struct TAH_RequestHandler *rh,
                                 struct MHD_Connection *
@@ -54,4 +55,4 @@ TAH_BAD_SIG_LOSSES_handler_get (struct TAH_RequestHandler *rh,
                                 const char *const args[]);
 
 
-#endif // SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_GET_H
+#endif
diff --git a/src/auditor/taler-auditor-httpd_bad-sig-losses-put.c b/src/auditor/taler-auditor-httpd_bad-sig-losses-put.c
deleted file mode 100644
index eab074666..000000000
--- a/src/auditor/taler-auditor-httpd_bad-sig-losses-put.c
+++ /dev/null
@@ -1,156 +0,0 @@
-/*
-   This file is part of TALER
-   Copyright (C) 2024 Taler Systems SA
-
-   TALER is free software; you can redistribute it and/or modify it under the
-   terms of the GNU General Public License as published by the Free Software
-   Foundation; either version 3, or (at your option) any later version.
-
-   TALER is distributed in the hope that it will be useful, but WITHOUT ANY
-   WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-   A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License along with
-   TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
- */
-
-
-#include "platform.h"
-#include <gnunet/gnunet_util_lib.h>
-#include <gnunet/gnunet_json_lib.h>
-#include <jansson.h>
-#include <microhttpd.h>
-#include <pthread.h>
-#include "taler_json_lib.h"
-#include "taler_mhd_lib.h"
-#include "taler-auditor-httpd.h"
-#include "taler-auditor-httpd_bad-sig-losses-put.h"
-
-/**
-* We have parsed the JSON information about the bad-sig-losses, do some
-* basic sanity checks and then execute the
-* transaction.
-*
-* @param connection the MHD connection to handle
-* @param dc information about the bad-sig-losses
-* @return MHD result code
-*/
-static MHD_RESULT
-process_inconsistency (
-  struct MHD_Connection *connection,
-  const struct TALER_AUDITORDB_BadSigLosses *dc)
-{
-
-  enum GNUNET_DB_QueryStatus qs;
-
-  if (GNUNET_SYSERR ==
-      TAH_plugin->preflight (TAH_plugin->cls))
-  {
-    GNUNET_break (0);
-    return TALER_MHD_reply_with_error (connection,
-                                       MHD_HTTP_INTERNAL_SERVER_ERROR,
-                                       TALER_EC_GENERIC_DB_SETUP_FAILED,
-                                       NULL);
-  }
-
-  /* execute transaction */
-  qs = TAH_plugin->insert_bad_sig_losses (TAH_plugin->cls,
-                                          dc);
-  if (0 > qs)
-  {
-    GNUNET_break (GNUNET_DB_STATUS_HARD_ERROR == qs);
-    TALER_LOG_WARNING (
-      "Failed to store /bad-sig-losses in database\n");
-    return TALER_MHD_reply_with_error (connection,
-                                       MHD_HTTP_INTERNAL_SERVER_ERROR,
-                                       TALER_EC_GENERIC_DB_STORE_FAILED,
-                                       "bad-sig-losses");
-  }
-  return TALER_MHD_REPLY_JSON_PACK (connection,
-                                    MHD_HTTP_OK,
-                                    GNUNET_JSON_pack_string ("status",
-                                                             "BAD_SIG_LOSSES_OK"));
-}
-
-
-MHD_RESULT
-TAH_BAD_SIG_LOSSES_PUT_handler (
-  struct TAH_RequestHandler *rh,
-  struct MHD_Connection *connection,
-  void **connection_cls,
-  const char *upload_data,
-  size_t *upload_data_size,
-  const char *const args[])
-{
-
-  struct TALER_AUDITORDB_BadSigLosses dc;
-
-
-  struct GNUNET_JSON_Specification spec[] = {
-
-    GNUNET_JSON_spec_string ("operation", (const char **) &dc.operation),
-    TALER_JSON_spec_amount ("loss", TAH_currency, &dc.loss),
-    GNUNET_JSON_spec_fixed_auto ("operation_specific_pub",
-                                 &dc.operation_specific_pub),
-
-    GNUNET_JSON_spec_end ()
-  };
-
-
-  json_t *json;
-
-  (void) rh;
-  (void) connection_cls;
-  (void) upload_data;
-  (void) upload_data_size;
-  {
-    enum GNUNET_GenericReturnValue res;
-
-    res = TALER_MHD_parse_post_json (connection,
-                                     connection_cls,
-                                     upload_data,
-                                     upload_data_size,
-                                     &json);
-    if (GNUNET_SYSERR == res)
-      return MHD_NO;
-    if ((GNUNET_NO == res) ||
-        (NULL == json))
-      return MHD_YES;
-    res = TALER_MHD_parse_json_data (connection,
-                                     json,
-                                     spec);
-    if (GNUNET_SYSERR == res)
-    {
-      json_decref (json);
-      return MHD_NO;                   /* hard failure */
-    }
-    if (GNUNET_NO == res)
-    {
-      json_decref (json);
-      return MHD_YES;                   /* failure */
-    }
-  }
-
-  MHD_RESULT res;
-
-  res = process_inconsistency (connection, &dc);
-  GNUNET_JSON_parse_free (spec);
-
-  json_decref (json);
-  return res;
-
-}
-
-
-void
-TEAH_BAD_SIG_LOSSES_PUT_init (void)
-{
-
-}
-
-
-void
-TEAH_BAD_SIG_LOSSES_PUT_done (void)
-{
-
-}
diff --git a/src/auditor/taler-auditor-httpd_bad-sig-losses-put.h b/src/auditor/taler-auditor-httpd_bad-sig-losses-put.h
deleted file mode 100644
index 59d8b5a60..000000000
--- a/src/auditor/taler-auditor-httpd_bad-sig-losses-put.h
+++ /dev/null
@@ -1,58 +0,0 @@
-/*
-   This file is part of TALER
-   Copyright (C) 2024 Taler Systems SA
-
-   TALER is free software; you can redistribute it and/or modify it under the
-   terms of the GNU General Public License as published by the Free Software
-   Foundation; either version 3, or (at your option) any later version.
-
-   TALER is distributed in the hope that it will be useful, but WITHOUT ANY
-   WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-   A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License along with
-   TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
- */
-
-
-#ifndef SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_PUT_H
-#define SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_PUT_H
-
-#include <microhttpd.h>
-#include "taler-auditor-httpd.h"
-
-/**
-* Initialize subsystem.
-*/
-void
-TEAH_BAD_SIG_LOSSES_PUT_init (void);
-
-/**
-* Shut down subsystem.
-*/
-void
-TEAH_BAD_SIG_LOSSES_PUT_done (void);
-
-
-/**
-* Handle a "/bad-sig-losses" request.  Parses the JSON, and, if
-* successful, checks the signatures and stores the result in the DB.
-*
-* @param rh context of the handler
-* @param connection the MHD connection to handle
-* @param[in,out] connection_cls the connection's closure (can be updated)
-* @param upload_data upload data
-* @param[in,out] upload_data_size number of bytes (left) in @a upload_data
-* @return MHD result code
-*/
-MHD_RESULT
-TAH_BAD_SIG_LOSSES_PUT_handler (struct TAH_RequestHandler *rh,
-                                struct MHD_Connection *
-                                connection,
-                                void **connection_cls,
-                                const char *upload_data,
-                                size_t *upload_data_size,
-                                const char *const args[]);
-
-
-#endif // SRC_TALER_AUDITOR_HTTPD_BAD_SIG_LOSSES_PUT_H
diff --git a/src/auditor/taler-auditor-httpd_denominations-without-sigs-get.h b/src/auditor/taler-auditor-httpd_denominations-without-sigs-get.h
index dc42e7e94..111d48ee4 100644
--- a/src/auditor/taler-auditor-httpd_denominations-without-sigs-get.h
+++ b/src/auditor/taler-auditor-httpd_denominations-without-sigs-get.h
@@ -35,15 +35,16 @@ void
 TEAH_BAD_DENOMINATIONS_WITHOUT_SIGS_GET_done (void);
 
 /**
-* Handle a "/denominations-without-sigs" request.
-*
-* @param rh context of the handler
-* @param connection the MHD connection to handle
-* @param[in,out] connection_cls the connection's closure (can be updated)
-* @param upload_data upload data
-* @param[in,out] upload_data_size number of bytes (left) in @a upload_data
-* @return MHD result code
-*/
+ * Handle a "/denominations-without-sigs" request.
+ *
+ * @param rh context of the handler
+ * @param connection the MHD connection to handle
+ * @param[in,out] connection_cls the connection's closure (can be updated)
+ * @param upload_data upload data
+ * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
+ * @param args NULL-terminated array of remaining parts of the URI broken up at '/'
+ * @return MHD result code
+ */
 MHD_RESULT
 TAH_DENOMINATIONS_WITHOUT_SIGS_handler_get (struct TAH_RequestHandler *rh,
                                             struct MHD_Connection *
diff --git a/src/auditor/taler-auditor-httpd_deposit-confirmation-del.c b/src/auditor/taler-auditor-httpd_deposit-confirmation-del.c
index ed5a63ec9..fadd7d479 100644
--- a/src/auditor/taler-auditor-httpd_deposit-confirmation-del.c
+++ b/src/auditor/taler-auditor-httpd_deposit-confirmation-del.c
@@ -13,14 +13,12 @@
   You should have received a copy of the GNU Affero General Public License along with
   TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
 */
-
 /**
- * @file taler-auditor-httpd_deposit-confirmation-delete.c
+ * @file taler-auditor-httpd_deposit-confirmation-del.c
  * @brief Handle /deposit-confirmation delete request;
  * Remove the specified entry from the database
  * @author Cedric Zwahlen
  */
-
 #include "taler-auditor-httpd_deposit-confirmation-del.h"
 
 
diff --git a/src/auditor/taler-auditor-httpd_deposit-confirmation-del.h b/src/auditor/taler-auditor-httpd_deposit-confirmation-del.h
index ce07fc52b..bca6d0295 100644
--- a/src/auditor/taler-auditor-httpd_deposit-confirmation-del.h
+++ b/src/auditor/taler-auditor-httpd_deposit-confirmation-del.h
@@ -13,15 +13,13 @@
   You should have received a copy of the GNU Affero General Public License along with
   TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
 */
-
 /**
- * @file taler-auditor-httpd_deposit-confirmation-delete.h
+ * @file taler-auditor-httpd_deposit-confirmation-del.h
  * @brief Handle DELETE /deposit-confirmation requests
  * @author Cedric Zwahlen
  */
-
-#ifndef SRC_TALER_AUDITOR_HTTPD_DEPOSIT_CONFIRMATION_DEL_H
-#define SRC_TALER_AUDITOR_HTTPD_DEPOSIT_CONFIRMATION_DEL_H
+#ifndef TALER_AUDITOR_HTTPD_DEPOSIT_CONFIRMATION_DEL_H
+#define TALER_AUDITOR_HTTPD_DEPOSIT_CONFIRMATION_DEL_H
 
 #include <gnunet/gnunet_util_lib.h>
 #include <microhttpd.h>
@@ -48,8 +46,9 @@ TEAH_DEPOSIT_CONFIRMATION_DELETE_done (void);
  * @param[in,out] connection_cls the connection's closure (can be updated)
  * @param upload_data upload data
  * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
+ * @param args NULL-terminated array of remaining parts of the URI broken up at '/'
  * @return MHD result code
-  */
+ */
 MHD_RESULT
 TAH_DEPOSIT_CONFIRMATION_handler_delete (struct TAH_RequestHandler *rh,
                                          struct MHD_Connection *connection,
@@ -59,4 +58,4 @@ TAH_DEPOSIT_CONFIRMATION_handler_delete (struct TAH_RequestHandler *rh,
                                          const char *const args[]);
 
 
-#endif // SRC_TALER_AUDITOR_HTTPD_DEPOSIT_CONFIRMATION_DEL_H
+#endif