1 files changed, 18 insertions, 15 deletions
diff --git a/games/pioneer/pioneer.SlackBuild b/games/pioneer/pioneer.SlackBuild
index 1adf9754e42a..e6d4cfdd821c 100644
--- a/games/pioneer/pioneer.SlackBuild
+++ b/games/pioneer/pioneer.SlackBuild
@@ -23,7 +23,8 @@
 #  ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 PRGNAM=pioneer
-VERSION=${VERSION:-20161129}
+SRCNAM=$(printf %s $PRGNAM | tr [a-z] [A-Z])
+VERSION=${VERSION:-20170415}
 BUILD=${BUILD:-1}
 TAG=${TAG:-_SBo}
 
@@ -54,7 +55,7 @@ else
   LIBDIRSUFFIX=""
 fi
 
-set -e
+set -eu
 
 rm -rf $PKG
 mkdir -p $TMP $PKG $OUTPUT
@@ -69,15 +70,15 @@ find -L . \
  \( -perm 666 -o -perm 664 -o -perm 640 -o -perm 600 -o -perm 444 \
   -o -perm 440 -o -perm 400 \) -exec chmod 644 {} \;
 
-DATADIR=${DATADIR:-/usr/share/games}
+DATADIR="${DATADIR:-/usr/share/games}"
 
-if [ "${DEBUG:-no}" = "yes" ]; then
-  debug="--enable-debug \
+if [ "${DEBUG:-no}" = yes ]; then
+  debug='--enable-debug \
          --with-no-optimise \
-         --with-fno-inline"
-  SLKCFLAGS=$(echo $SLKCFLAGS | sed 's/-O2/-O0/')
+         --with-fno-inline'
+  SLKCFLAGS="$(printf %s "$SLKCFLAGS" | sed 's/-O2/-O0/')"
 else
-  debug="--with-strip"
+  debug='--with-strip'
 fi
 
 # Generate the configure file
@@ -99,25 +100,27 @@ make install DESTDIR=$PKG
 mkdir -p $PKG/usr/share/applications
 cat > $PKG/usr/share/applications/$PRGNAM.desktop <<EOF
 [Desktop Entry]
-Name=$(echo "${PRGNAM^}")
+Name=$SRCNAM
 Exec=$PRGNAM
 Icon=$PRGNAM
 Type=Application
-Comment=$(echo "${PRGNAM^}") (space adventure game)
+Comment=$SRCNAM (space adventure game)
 Categories=Game;AdventureGame;
 EOF
 
 # Add missing icons to package
 for pngicon in application-icon/pngs/*.png ; do
-  if [ -f $pngicon ]; then
-    size=$(basename "${pngicon##*-}" .png)
-    install -D -m644 $pngicon $PKG/usr/share/icons/hicolor/$size/apps/$PRGNAM.png
+  if [ -f "$pngicon" ]; then
+    size="$(basename "${pngicon##*-}" .png)"
+    install -D -m644 "$pngicon" \
+      $PKG/usr/share/icons/hicolor/$size/apps/$PRGNAM.png
   fi
 done
-install -D -m644 application-icon/badge-full.svg $PKG/usr/share/icons/hicolor/scalable/apps/$PRGNAM.svg
+install -D -m644 application-icon/badge-full.svg \
+  $PKG/usr/share/icons/hicolor/scalable/apps/$PRGNAM.svg
 
 # Remove empty .gitignore files
-find $PKG -name ".gitignore" -exec rm -f {} \;
+find $PKG -name '.gitignore' -exec rm -f {} \;
 
 mkdir -p $PKG/usr/doc/$PRGNAM-$VERSION
 cp -a licenses *.txt README.md $PKG/usr/doc/$PRGNAM-$VERSION