factored out "open my $fh, $op, $file" and made it robust in one fell swoop

1 files changed, 3 insertions, 3 deletions

diff --git a/sboupgrade b/sboupgrade
index 0cd946e..8bf2831 100755
--- a/sboupgrade
+++ b/sboupgrade
@@ -198,13 +198,13 @@ sub readme_prompt {
 	script_error ('readme_prompt requires an argument.') unless exists $_[0];
 	my $sbo = shift;
 	my $readme_path = get_readme_path ($sbo);
-	open my $readme_file, '<', $readme_path;
-	my $readme = do {local $/; <$readme_file>};
+	my $fh = open_read ($readme_path);
+	my $readme = do {local $/; <$fh>};
+	close $fh;
 	unless (grok_requirements ($sbo, $readme) ) {
 		grok_user_group ($readme);
 		my $opts = grok_options ($readme);
 		print "\n". $readme if $opts eq "7";
-		close $readme_file;
 		my $name = $compat32 eq 'TRUE' ? "$sbo-compat32" : $sbo;
 		print "\nProceed with $name? [y]: ";
 		my $test = <STDIN>;