aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
Diffstat (limited to 'hw')
-rw-r--r--hw/core/loader-fit.c62
-rw-r--r--hw/mips/boston.c6
-rw-r--r--hw/pci/pci.c2
-rw-r--r--hw/timer/hpet.c2
-rw-r--r--hw/vfio/pci.c19
5 files changed, 54 insertions, 37 deletions
diff --git a/hw/core/loader-fit.c b/hw/core/loader-fit.c
index 447f60857d..f27b6af942 100644
--- a/hw/core/loader-fit.c
+++ b/hw/core/loader-fit.c
@@ -18,6 +18,7 @@
*/
#include "qemu/osdep.h"
+#include "qapi/error.h"
#include "qemu/units.h"
#include "exec/memory.h"
#include "hw/loader.h"
@@ -33,7 +34,7 @@
#define FIT_LOADER_MAX_PATH (128)
static const void *fit_load_image_alloc(const void *itb, const char *name,
- int *poff, size_t *psz)
+ int *poff, size_t *psz, Error **errp)
{
const void *data;
const char *comp;
@@ -46,6 +47,7 @@ static const void *fit_load_image_alloc(const void *itb, const char *name,
off = fdt_path_offset(itb, path);
if (off < 0) {
+ error_setg(errp, "can't find node %s", path);
return NULL;
}
if (poff) {
@@ -54,6 +56,7 @@ static const void *fit_load_image_alloc(const void *itb, const char *name,
data = fdt_getprop(itb, off, "data", &sz);
if (!data) {
+ error_setg(errp, "can't get %s/data", path);
return NULL;
}
@@ -73,7 +76,7 @@ static const void *fit_load_image_alloc(const void *itb, const char *name,
uncomp_len = gunzip(uncomp_data, uncomp_len, (void *) data, sz);
if (uncomp_len < 0) {
- error_printf("unable to decompress %s image\n", name);
+ error_setg(errp, "unable to decompress %s image", name);
g_free(uncomp_data);
return NULL;
}
@@ -85,18 +88,19 @@ static const void *fit_load_image_alloc(const void *itb, const char *name,
return data;
}
- error_printf("unknown compression '%s'\n", comp);
+ error_setg(errp, "unknown compression '%s'", comp);
return NULL;
}
static int fit_image_addr(const void *itb, int img, const char *name,
- hwaddr *addr)
+ hwaddr *addr, Error **errp)
{
const void *prop;
int len;
prop = fdt_getprop(itb, img, name, &len);
if (!prop) {
+ error_setg(errp, "can't find %s address", name);
return -ENOENT;
}
@@ -108,13 +112,14 @@ static int fit_image_addr(const void *itb, int img, const char *name,
*addr = fdt64_to_cpu(*(fdt64_t *)prop);
return 0;
default:
- error_printf("invalid %s address length %d\n", name, len);
+ error_setg(errp, "invalid %s address length %d", name, len);
return -EINVAL;
}
}
static int fit_load_kernel(const struct fit_loader *ldr, const void *itb,
- int cfg, void *opaque, hwaddr *pend)
+ int cfg, void *opaque, hwaddr *pend,
+ Error **errp)
{
const char *name;
const void *data;
@@ -126,26 +131,26 @@ static int fit_load_kernel(const struct fit_loader *ldr, const void *itb,
name = fdt_getprop(itb, cfg, "kernel", NULL);
if (!name) {
- error_printf("no kernel specified by FIT configuration\n");
+ error_setg(errp, "no kernel specified by FIT configuration");
return -EINVAL;
}
- load_data = data = fit_load_image_alloc(itb, name, &img_off, &sz);
+ load_data = data = fit_load_image_alloc(itb, name, &img_off, &sz, errp);
if (!data) {
- error_printf("unable to load kernel image from FIT\n");
+ error_prepend(errp, "unable to load kernel image from FIT: ");
return -EINVAL;
}
- err = fit_image_addr(itb, img_off, "load", &load_addr);
+ err = fit_image_addr(itb, img_off, "load", &load_addr, errp);
if (err) {
- error_printf("unable to read kernel load address from FIT\n");
+ error_prepend(errp, "unable to read kernel load address from FIT: ");
ret = err;
goto out;
}
- err = fit_image_addr(itb, img_off, "entry", &entry_addr);
+ err = fit_image_addr(itb, img_off, "entry", &entry_addr, errp);
if (err) {
- error_printf("unable to read kernel entry address from FIT\n");
+ error_prepend(errp, "unable to read kernel entry address from FIT: ");
ret = err;
goto out;
}
@@ -172,7 +177,7 @@ out:
static int fit_load_fdt(const struct fit_loader *ldr, const void *itb,
int cfg, void *opaque, const void *match_data,
- hwaddr kernel_end)
+ hwaddr kernel_end, Error **errp)
{
const char *name;
const void *data;
@@ -187,16 +192,18 @@ static int fit_load_fdt(const struct fit_loader *ldr, const void *itb,
return 0;
}
- load_data = data = fit_load_image_alloc(itb, name, &img_off, &sz);
+ load_data = data = fit_load_image_alloc(itb, name, &img_off, &sz, errp);
if (!data) {
- error_printf("unable to load FDT image from FIT\n");
+ error_prepend(errp, "unable to load FDT image from FIT: ");
return -EINVAL;
}
- err = fit_image_addr(itb, img_off, "load", &load_addr);
+ err = fit_image_addr(itb, img_off, "load", &load_addr, errp);
if (err == -ENOENT) {
load_addr = ROUND_UP(kernel_end, 64 * KiB) + (10 * MiB);
+ error_free(*errp);
} else if (err) {
+ error_prepend(errp, "unable to read FDT load address from FIT: ");
ret = err;
goto out;
}
@@ -229,7 +236,7 @@ static bool fit_cfg_compatible(const void *itb, int cfg, const char *compat)
return false;
}
- fdt = fit_load_image_alloc(itb, fdt_name, NULL, NULL);
+ fdt = fit_load_image_alloc(itb, fdt_name, NULL, NULL, NULL);
if (!fdt) {
return false;
}
@@ -252,11 +259,12 @@ out:
int load_fit(const struct fit_loader *ldr, const char *filename, void *opaque)
{
+ Error *err = NULL;
const struct fit_loader_match *match;
const void *itb, *match_data = NULL;
const char *def_cfg_name;
char path[FIT_LOADER_MAX_PATH];
- int itb_size, configs, cfg_off, off, err;
+ int itb_size, configs, cfg_off, off;
hwaddr kernel_end;
int ret;
@@ -267,6 +275,7 @@ int load_fit(const struct fit_loader *ldr, const char *filename, void *opaque)
configs = fdt_path_offset(itb, "/configurations");
if (configs < 0) {
+ error_report("can't find node /configurations");
ret = configs;
goto out;
}
@@ -301,20 +310,21 @@ int load_fit(const struct fit_loader *ldr, const char *filename, void *opaque)
}
if (cfg_off < 0) {
- /* couldn't find a configuration to use */
+ error_report("can't find configuration");
ret = cfg_off;
goto out;
}
- err = fit_load_kernel(ldr, itb, cfg_off, opaque, &kernel_end);
- if (err) {
- ret = err;
+ ret = fit_load_kernel(ldr, itb, cfg_off, opaque, &kernel_end, &err);
+ if (ret) {
+ error_report_err(err);
goto out;
}
- err = fit_load_fdt(ldr, itb, cfg_off, opaque, match_data, kernel_end);
- if (err) {
- ret = err;
+ ret = fit_load_fdt(ldr, itb, cfg_off, opaque, match_data, kernel_end,
+ &err);
+ if (ret) {
+ error_report_err(err);
goto out;
}
diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index e5bab3cadc..a8b29f62f5 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -528,21 +528,21 @@ static void boston_mach_init(MachineState *machine)
fw_size = load_image_targphys(machine->firmware,
0x1fc00000, 4 * MiB);
if (fw_size == -1) {
- error_printf("unable to load firmware image '%s'\n",
+ error_report("unable to load firmware image '%s'",
machine->firmware);
exit(1);
}
} else if (machine->kernel_filename) {
fit_err = load_fit(&boston_fit_loader, machine->kernel_filename, s);
if (fit_err) {
- error_printf("unable to load FIT image\n");
+ error_report("unable to load FIT image");
exit(1);
}
gen_firmware(memory_region_get_ram_ptr(flash) + 0x7c00000,
s->kernel_entry, s->fdt_base, is_64b);
} else if (!qtest_enabled()) {
- error_printf("Please provide either a -kernel or -bios argument\n");
+ error_report("Please provide either a -kernel or -bios argument");
exit(1);
}
}
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 6d13ef877b..1808b242dd 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -951,7 +951,7 @@ static uint16_t pci_req_id_cache_extract(PCIReqIDCache *cache)
result = PCI_BUILD_BDF(bus_n, 0);
break;
default:
- error_printf("Invalid PCI requester ID cache type: %d\n",
+ error_report("Invalid PCI requester ID cache type: %d",
cache->type);
exit(1);
break;
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index d97436bc7b..41024f39fb 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -744,7 +744,7 @@ static void hpet_realize(DeviceState *dev, Error **errp)
HPETTimer *timer;
if (!s->intcap) {
- error_printf("Hpet's intcap not initialized.\n");
+ warn_report("Hpet's intcap not initialized");
}
if (hpet_cfg.count == UINT8_MAX) {
/* first instance */
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 504019c458..0142819ea6 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -947,8 +947,10 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
if (vdev->pdev.romfile || !vdev->pdev.rom_bar) {
/* Since pci handles romfile, just print a message and return */
if (vfio_blacklist_opt_rom(vdev) && vdev->pdev.romfile) {
- error_printf("Warning : Device at %s is known to cause system instability issues during option rom execution. Proceeding anyway since user specified romfile\n",
- vdev->vbasedev.name);
+ warn_report("Device at %s is known to cause system instability"
+ " issues during option rom execution",
+ vdev->vbasedev.name);
+ error_printf("Proceeding anyway since user specified romfile\n");
}
return;
}
@@ -973,11 +975,16 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
if (vfio_blacklist_opt_rom(vdev)) {
if (dev->opts && qemu_opt_get(dev->opts, "rombar")) {
- error_printf("Warning : Device at %s is known to cause system instability issues during option rom execution. Proceeding anyway since user specified non zero value for rombar\n",
- vdev->vbasedev.name);
+ warn_report("Device at %s is known to cause system instability"
+ " issues during option rom execution",
+ vdev->vbasedev.name);
+ error_printf("Proceeding anyway since user specified"
+ " non zero value for rombar\n");
} else {
- error_printf("Warning : Rom loading for device at %s has been disabled due to system instability issues. Specify rombar=1 or romfile to force\n",
- vdev->vbasedev.name);
+ warn_report("Rom loading for device at %s has been disabled"
+ " due to system instability issues",
+ vdev->vbasedev.name);
+ error_printf("Specify rombar=1 or romfile to force\n");
return;
}
}
generated by cgit v1.2.3 (git 2.26.2) at 2025-02-28 16:45:42 +0000