diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-08-26 14:02:53 +0200 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2015-09-11 10:21:38 +0300 |
| commit | 012aef073461fd24a901d7a8742532093b7f6ae5 (patch) | |
| tree | 4ee28d5cedea44f2af2b5b3a7fe482d9e80a3fad /xen-mapcache.c | |
| parent | ef1e1e0782e99c9dcf2b35e5310cdd8ca9211374 (diff) | |
maint: avoid useless "if (foo) free(foo)" pattern
My Coccinelle semantic patch finds a few more, because it also fixes up
the equally pointless conditional
if (foo) {
free(foo);
foo = NULL;
}
Result (feel free to squash it into your patch):
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'xen-mapcache.c')
| -rw-r--r-- | xen-mapcache.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/xen-mapcache.c b/xen-mapcache.c index 8cefd0c62f..97fece2358 100644 --- a/xen-mapcache.c +++ b/xen-mapcache.c @@ -169,10 +169,8 @@ static void xen_remap_bucket(MapCacheEntry *entry, exit(-1); } } - if (entry->valid_mapping != NULL) { - g_free(entry->valid_mapping); - entry->valid_mapping = NULL; - } + g_free(entry->valid_mapping); + entry->valid_mapping = NULL; for (i = 0; i < nb_pfn; i++) { pfns[i] = (address_index << (MCACHE_BUCKET_SHIFT-XC_PAGE_SHIFT)) + i; |