diff options
author | Eric Blake <eblake@redhat.com> | 2016-01-29 06:48:42 -0700 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2016-02-08 17:29:55 +0100 |
commit | 7019738d4c9ce49b8fad09e9774393ad127b835d (patch) | |
tree | 44bbdf582bf22e32f4c26ffb4566ee01514a4245 /vl.c | |
parent | e408311546b633b232312450d9017f4db21df0dc (diff) |
hmp: Drop pointless allocation during qapi visit
The qapi visitor contract allows us to visit a virtual structure,
where we don't have any corresponding qapi struct. Most such uses
pass NULL for @obj; but these two callers were passing a dummy
pointer, which then gets allocated to heap memory but then
immediately freed without use. Clean this up to suppress unwanted
allocation, like we do elsewhere.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1454075341-13658-7-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'vl.c')
-rw-r--r-- | vl.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -2821,7 +2821,6 @@ static int object_create(void *opaque, QemuOpts *opts, Error **errp) Error *err = NULL; char *type = NULL; char *id = NULL; - void *dummy = NULL; OptsVisitor *ov; QDict *pdict; bool (*type_predicate)(const char *) = opaque; @@ -2829,7 +2828,7 @@ static int object_create(void *opaque, QemuOpts *opts, Error **errp) ov = opts_visitor_new(opts); pdict = qemu_opts_to_qdict(opts, NULL); - visit_start_struct(opts_get_visitor(ov), &dummy, NULL, NULL, 0, &err); + visit_start_struct(opts_get_visitor(ov), NULL, NULL, NULL, 0, &err); if (err) { goto out; } @@ -2864,7 +2863,6 @@ out: QDECREF(pdict); g_free(id); g_free(type); - g_free(dummy); if (err) { error_report_err(err); return -1; |