diff options
author | Li Qiang <liq3ea@gmail.com> | 2018-11-20 21:10:25 -0800 |
---|---|---|
committer | Philippe Mathieu-Daudé <philmd@redhat.com> | 2019-01-04 15:30:52 +0100 |
commit | ee5d0f89de3e53cdb0dcf51acc1502b310ed3bd2 (patch) | |
tree | cf2978fedf0fa852333168ba137cddb58500d520 /vl.c | |
parent | 6912bb0b3d3b140c70d8cdfd2dff77f9890d7f12 (diff) |
fw_cfg: Fix -boot reboot-timeout error checking
fw_cfg_reboot() gets option parameter "reboot-timeout" with
qemu_opt_get(), then converts it to an integer by hand. It neglects to
check that conversion for errors, and fails to reject negative values.
Positive values above the limit get reported and replaced by the limit.
This patch checks for conversion errors properly, and reject all values
outside 0...0xffff.
Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <1542777026-2788-3-git-send-email-liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'vl.c')
-rw-r--r-- | vl.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -341,7 +341,7 @@ static QemuOptsList qemu_boot_opts = { .type = QEMU_OPT_NUMBER, }, { .name = "reboot-timeout", - .type = QEMU_OPT_STRING, + .type = QEMU_OPT_NUMBER, }, { .name = "strict", .type = QEMU_OPT_BOOL, |