aboutsummaryrefslogtreecommitdiff
path: root/util/throttle.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2015-08-04 11:22:12 +0100
committerStefan Hajnoczi <stefanha@redhat.com>2015-08-05 12:53:48 +0100
commitee2bdc33c913b7d765baa5aa338c29fb30a05c9a (patch)
tree265d6b583e53dd9341919bea5233998b61801f6d /util/throttle.c
parent2be4f242b50a84bf360df02480b173bfed161107 (diff)
throttle: refuse bps_max/iops_max without bps/iops
The bps_max/iops_max values are meaningless without corresponding bps/iops values. Reported an error if bps_max/iops_max is given without bps/iops. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Message-id: 1438683733-21111-2-git-send-email-stefanha@redhat.com
Diffstat (limited to 'util/throttle.c')
-rw-r--r--util/throttle.c15
1 files changed, 15 insertions, 0 deletions
diff --git a/util/throttle.c b/util/throttle.c
index 706c13111e..1113671ecf 100644
--- a/util/throttle.c
+++ b/util/throttle.c
@@ -300,6 +300,21 @@ bool throttle_is_valid(ThrottleConfig *cfg)
return !invalid;
}
+/* check if bps_max/iops_max is used without bps/iops
+ * @cfg: the throttling configuration to inspect
+ */
+bool throttle_max_is_missing_limit(ThrottleConfig *cfg)
+{
+ int i;
+
+ for (i = 0; i < BUCKETS_COUNT; i++) {
+ if (cfg->buckets[i].max && !cfg->buckets[i].avg) {
+ return true;
+ }
+ }
+ return false;
+}
+
/* fix bucket parameters */
static void throttle_fix_bucket(LeakyBucket *bkt)
{