diff options
| author | Eduardo Habkost <ehabkost@redhat.com> | 2020-09-16 14:25:17 -0400 |
|---|---|---|
| committer | Eduardo Habkost <ehabkost@redhat.com> | 2020-09-18 14:12:32 -0400 |
| commit | 30b5707c269cac1ad80b72f777e52c8e08b2ff19 (patch) | |
| tree | 7201b93d5b438b3a608040e71b10ffec73f9c980 /ui | |
| parent | c734cd40a10943753a4d015c9d0a6c08c8f0159e (diff) | |
qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros
One of the goals of having less boilerplate on QOM declarations
is to avoid human error. Requiring an extra argument that is
never used is an opportunity for mistakes.
Remove the unused argument from OBJECT_DECLARE_TYPE and
OBJECT_DECLARE_SIMPLE_TYPE.
Coccinelle patch used to convert all users of the macros:
@@
declarer name OBJECT_DECLARE_TYPE;
identifier InstanceType, ClassType, lowercase, UPPERCASE;
@@
OBJECT_DECLARE_TYPE(InstanceType, ClassType,
- lowercase,
UPPERCASE);
@@
declarer name OBJECT_DECLARE_SIMPLE_TYPE;
identifier InstanceType, lowercase, UPPERCASE;
@@
OBJECT_DECLARE_SIMPLE_TYPE(InstanceType,
- lowercase,
UPPERCASE);
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Paul Durrant <paul@xen.org>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200916182519.415636-4-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/input-barrier.c | 2 | ||||
| -rw-r--r-- | ui/input-linux.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ui/input-barrier.c b/ui/input-barrier.c index b76697be93..a047919fde 100644 --- a/ui/input-barrier.c +++ b/ui/input-barrier.c @@ -20,7 +20,7 @@ #include "input-barrier.h" #define TYPE_INPUT_BARRIER "input-barrier" -OBJECT_DECLARE_SIMPLE_TYPE(InputBarrier, input_barrier, +OBJECT_DECLARE_SIMPLE_TYPE(InputBarrier, INPUT_BARRIER) diff --git a/ui/input-linux.c b/ui/input-linux.c index f02557b012..ab351a4187 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -31,7 +31,7 @@ static bool linux_is_button(unsigned int lnx) } #define TYPE_INPUT_LINUX "input-linux" -OBJECT_DECLARE_SIMPLE_TYPE(InputLinux, input_linux, +OBJECT_DECLARE_SIMPLE_TYPE(InputLinux, INPUT_LINUX) |