diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:59 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:37:36 +0200 |
| commit | 54d31236b906c8f03eb011717de7bc47000720c3 (patch) | |
| tree | cc3e5f84c89e946a78df8deb8bc939ae25d2ef6b /ui | |
| parent | 2f780b6a91fe99652266004bf78191ceddfae09c (diff) | |
sysemu: Split sysemu/runstate.h off sysemu/sysemu.h
sysemu/sysemu.h is a rather unfocused dumping ground for stuff related
to the system-emulator. Evidence:
* It's included widely: in my "build everything" tree, changing
sysemu/sysemu.h still triggers a recompile of some 1100 out of 6600
objects (not counting tests and objects that don't depend on
qemu/osdep.h, down from 5400 due to the previous two commits).
* It pulls in more than a dozen additional headers.
Split stuff related to run state management into its own header
sysemu/runstate.h.
Touching sysemu/sysemu.h now recompiles some 850 objects. qemu/uuid.h
also drops from 1100 to 850, and qapi/qapi-types-run-state.h from 4400
to 4200. Touching new sysemu/runstate.h recompiles some 500 objects.
Since I'm touching MAINTAINERS to add sysemu/runstate.h anyway, also
add qemu/main-loop.h.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-30-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
[Unbreak OS-X build]
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/cocoa.m | 1 | ||||
| -rw-r--r-- | ui/gtk.c | 1 | ||||
| -rw-r--r-- | ui/input.c | 1 | ||||
| -rw-r--r-- | ui/sdl2.c | 1 | ||||
| -rw-r--r-- | ui/spice-core.c | 2 |
5 files changed, 5 insertions, 1 deletions
diff --git a/ui/cocoa.m b/ui/cocoa.m index c5a0d33c29..f023d5166f 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -31,6 +31,7 @@ #include "ui/console.h" #include "ui/input.h" #include "sysemu/sysemu.h" +#include "sysemu/runstate.h" #include "qapi/error.h" #include "qapi/qapi-commands-block.h" #include "qapi/qapi-commands-misc.h" @@ -47,6 +47,7 @@ #include "trace.h" #include "ui/input.h" +#include "sysemu/runstate.h" #include "sysemu/sysemu.h" #include "keymaps.h" #include "chardev/char.h" diff --git a/ui/input.c b/ui/input.c index 9494688295..4791b089c7 100644 --- a/ui/input.c +++ b/ui/input.c @@ -8,6 +8,7 @@ #include "ui/input.h" #include "ui/console.h" #include "sysemu/replay.h" +#include "sysemu/runstate.h" struct QemuInputHandlerState { DeviceState *dev; @@ -28,6 +28,7 @@ #include "ui/console.h" #include "ui/input.h" #include "ui/sdl2.h" +#include "sysemu/runstate.h" #include "sysemu/sysemu.h" static int sdl2_num_outputs; diff --git a/ui/spice-core.c b/ui/spice-core.c index a395d7ccd4..ecc2ec2c55 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -19,7 +19,7 @@ #include <spice.h> #include "sysemu/sysemu.h" - +#include "sysemu/runstate.h" #include "ui/qemu-spice.h" #include "qemu/error-report.h" #include "qemu/main-loop.h" |