aboutsummaryrefslogtreecommitdiff
path: root/ui/util.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2024-07-31 14:32:06 +0200
committerKevin Wolf <kwolf@redhat.com>2024-08-06 20:12:39 +0200
commit8a0495624f23f8f01dfb1484f367174f3b3572e8 (patch)
tree53f49c5e122ba99847e11d5ea72894c5fa853312 /ui/util.c
parent622a70161ac258e4a166a7dca4b5be267e0652d9 (diff)
scsi-disk: Add warning comments that host_status errors take a shortcut
scsi_block_sgio_complete() has surprising behaviour in that there are error cases in which it directly completes the request and never calls the passed callback. In the current state of the code, this doesn't seem to result in bugs, but with future code changes, we must be careful to never rely on the callback doing some cleanup until this code smell is fixed. For now, just add warnings to make people aware of the trap. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Acked-by: Paolo Bonzini <pbonzini@redhat.com> Message-ID: <20240731123207.27636-4-kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'ui/util.c')
0 files changed, 0 insertions, 0 deletions