aboutsummaryrefslogtreecommitdiff
path: root/trace
diff options
context:
space:
mode:
authorHelge Deller <deller@gmx.de>2020-04-26 12:55:39 +0200
committerMichael Roth <mdroth@linux.vnet.ibm.com>2020-08-24 19:12:04 -0500
commitd723a57acd985cf5c9fdf8a2761d1ca53a3179c0 (patch)
tree4ca2eec620c3e9bcdcb4d633360a31e68762af01 /trace
parentdd506af071328eae57995eacc4aa4128c5f6d8c8 (diff)
Fix tulip breakage
The tulip network driver in a qemu-system-hppa emulation is broken in the sense that bigger network packages aren't received any longer and thus even running e.g. "apt update" inside the VM fails. The breakage was introduced by commit 8ffb7265af ("check frame size and r/w data length") which added checks to prevent accesses outside of the rx/tx buffers. But the new checks were implemented wrong. The variable rx_frame_len counts backwards, from rx_frame_size down to zero, and the variable len is never bigger than rx_frame_len, so accesses just can't happen and the checks are unnecessary. On the contrary the checks now prevented bigger packages to be moved into the rx buffers. This patch reverts the wrong checks and were sucessfully tested with a qemu-system-hppa emulation. Fixes: 8ffb7265af ("check frame size and r/w data length") Buglink: https://bugs.launchpad.net/bugs/1874539 Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Jason Wang <jasowang@redhat.com> (cherry picked from commit d9b69640391618045949f7c500b87fc129f862ed) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'trace')
0 files changed, 0 insertions, 0 deletions